Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 1.8.2
-
Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
-
Component/s: Framework
-
Labels:None
-
Environment:All
Description
This is a follow-on issue related to ICE-1900.
Neil Griffin added a comment - 28/Nov/09 08:39 AM
The new ICEfaces RequestStateManagerDelegate.clearMessages(FacesContext fc, String clientID) method is only working for messages associated with a component. The "FacesMessage(s) have been enqueued" annoyance is still happening for GLOBAL messages (where clientID == null).
Request that the "if" condition in the clearMessages method be changed to the following, so that it clears out GLOBAL messages too:
public static void clearMessages(FacesContext fc, String clientID) {
// if (!detected || fc == null || clientID == null) {
if (!detected || fc == null) {
return;
}
Set pendingMessageIds = getPendingMessageIds(fc);
if (pendingMessageIds != null && !pendingMessageIds.isEmpty()) {
pendingMessageIds.remove(clientID);
}
}
Neil Griffin added a comment - 28/Nov/09 08:39 AM
The new ICEfaces RequestStateManagerDelegate.clearMessages(FacesContext fc, String clientID) method is only working for messages associated with a component. The "FacesMessage(s) have been enqueued" annoyance is still happening for GLOBAL messages (where clientID == null).
Request that the "if" condition in the clearMessages method be changed to the following, so that it clears out GLOBAL messages too:
public static void clearMessages(FacesContext fc, String clientID) {
// if (!detected || fc == null || clientID == null) {
if (!detected || fc == null) {
return;
}
Set pendingMessageIds = getPendingMessageIds(fc);
if (pendingMessageIds != null && !pendingMessageIds.isEmpty()) {
pendingMessageIds.remove(clientID);
}
}
Activity
Ken Fyten
created issue -
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [] | |
Fix Version/s | 1.8.2-EE-GA_P01 [ 10220 ] | |
Fix Version/s | 1.8.3 [ 10211 ] | |
Assignee | Deryk Sinotte [ deryk.sinotte ] | |
Priority | Major [ 3 ] | Minor [ 4 ] |
Ken Fyten
made changes -
Summary | warning messages to server that state problems exist in application (no noticeable functional deficiencies though) | "FacesMessage(s) have been enqueued" annoyance logging is still happening for GLOBAL messages |
Salesforce Case | [] |
Deryk Sinotte
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee | Deryk Sinotte [ deryk.sinotte ] |
I've removed the extra check for clientIDs that are null so that global messages will also be cleared. Resolving as fixed.