ICEfaces
  1. ICEfaces
  2. ICE-5177

"FacesMessage(s) have been enqueued" annoyance logging is still happening for GLOBAL messages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      All

      Description

      This is a follow-on issue related to ICE-1900.

      Neil Griffin added a comment - 28/Nov/09 08:39 AM
      The new ICEfaces RequestStateManagerDelegate.clearMessages(FacesContext fc, String clientID) method is only working for messages associated with a component. The "FacesMessage(s) have been enqueued" annoyance is still happening for GLOBAL messages (where clientID == null).

      Request that the "if" condition in the clearMessages method be changed to the following, so that it clears out GLOBAL messages too:

          public static void clearMessages(FacesContext fc, String clientID) {

              // if (!detected || fc == null || clientID == null) {
              if (!detected || fc == null) {
                  return;
              }

              Set pendingMessageIds = getPendingMessageIds(fc);
              if (pendingMessageIds != null && !pendingMessageIds.isEmpty()) {
                  pendingMessageIds.remove(clientID);
              }

          }

        Activity

        Hide
        Deryk Sinotte added a comment -

        I've removed the extra check for clientIDs that are null so that global messages will also be cleared. Resolving as fixed.

        Show
        Deryk Sinotte added a comment - I've removed the extra check for clientIDs that are null so that global messages will also be cleared. Resolving as fixed.
        Hide
        Joanne Bai added a comment -

        Verified successfully using ICE-1900 test case.

        Tested on ICEfaces-1.8.2-ee branch revision #20380 with tomcat 6 + FF3.5

        Show
        Joanne Bai added a comment - Verified successfully using ICE-1900 test case. Tested on ICEfaces-1.8.2-ee branch revision #20380 with tomcat 6 + FF3.5

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: