[ICE-5010] dataPaginator immediate=true partly ignored - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.2
Fix Version/s: 1.8.2-EE-GA, 1.8.3
Component/s: ICE-Components
Labels:
None
Environment:
Apache Tomcat, Icefaces 1.8.2, Windows XP/Vista

Description

I attached an example project that clearly shows that the validation of the calendar component is fired whenever you click an page number in the dataTable paginator component although the attribute immediate=true is set on it.

If you set immediate="true" on the ice:dataPaginator it is only applied on the page 'jumper' arrow images [page jumper controller] but not on the navigation of the individual page images [page controller].

Ugly workaround:
Set paginator="false" on the dataTable which will just show the page-jumper-controller-images (which are working well with the immediate=true ) not the page-controller-images

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
8715.war

14/Oct/09 6:21 AM

9.78 MB

Patrick Dobler
META-INF/MANIFEST.MF 0.0 kB

WEB-INF/classes/.../ProgressBarBean.class 3 kB

WEB-INF/lib/jboss-el.jar 130 kB

WEB-INF/.../AttendeeFileValidationBean.class 5 kB

test.jspx 1 kB

WEB-INF/lib/commons-fileupload-1.2.1.jar 56 kB

WEB-INF/lib/jxl-2.6.3.jar 1023 kB

WEB-INF/lib/commons-logging-1.1.1.jar 59 kB

error.jspx 1 kB

WEB-INF/lib/commons-collections-3.2.jar 558 kB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/lib/jsf-api_1.2_12.jar 350 kB

popupAttendeesValidationProgress.jspx 2 kB

WEB-INF/.../backport-util-concurrent-2.1.jar 322 kB

WEB-INF/lib/jsf-impl.jar 1.15 MB

WEB-INF/classes/.../test/MyTestBean.class 4 kB

WEB-INF/lib/jsf-impl_1.2_12.jar 816 kB

WEB-INF/web.xml 3 kB

WEB-INF/lib/commons-digester-1.8.jar 140 kB

WEB-INF/classes/.../ProgressBarBean.java 4 kB

MyJsp.jspx 4 kB

WEB-INF/lib/icefaces-facelets-1.8.2.jar 596 kB

popupSelectionError.jspx 0.3 kB

WEB-INF/lib/commons-beanutils-1.6.1.jar 116 kB

WEB-INF/classes/.../test/TestServlet.java 0.8 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/classes/.../test/TestServlet.class 1 kB

WEB-INF/lib/icefaces-comps-1.8.2.jar 1.94 MB

WEB-INF/classes/org/test/MyTestBean.java 3 kB

WEB-INF/.../IndeterminateProgressBarBean.class 0.5 kB

Showing 30 of 44 items Download Zip
Show

8715.war

14/Oct/09 6:21 AM

9.78 MB

Patrick Dobler
datapaginator.zip

13/Nov/09 2:50 AM

11 kB

Jacopo Dell Anno

Activity

Ascending order - Click to sort in descending order

Patrick Dobler created issue - 14/Oct/09 6:18 AM

Patrick Dobler made changes - 14/Oct/09 6:21 AM

Field	Original Value	New Value
Attachment		8715.war [ 12029 ]

Patrick Dobler made changes - 14/Oct/09 6:24 AM

Salesforce Case		[]
Description	I attached an example project that clearly shows that the validation of the calendar component is fired whenever you click an page number in the dataTable paginator component although the attribute immediate=true is set on it. If you set immediate="true" on the ice:dataPaginator it is only applied on the page 'jumper' arrow images [page jumper controller] but not on the navigation of the individual page images [page controller]. Ugly workaround: Set paginator="false" on the dataTable which will just show the page-jumper-controller-images not the page-controller-images	I attached an example project that clearly shows that the validation of the calendar component is fired whenever you click an page number in the dataTable paginator component although the attribute immediate=true is set on it. If you set immediate="true" on the ice:dataPaginator it is only applied on the page 'jumper' arrow images [page jumper controller] but not on the navigation of the individual page images [page controller]. Ugly workaround: Set paginator="false" on the dataTable which will just show the page-jumper-controller-images (which are working well with the immediate=true ) not the page-controller-images

Tyler Johnson made changes - 14/Oct/09 4:51 PM

Salesforce Case

[5007000000A7Ca0]

Hide

Permalink

Jacopo Dell Anno added a comment - 16/Oct/09 1:34 PM

I have found a solution to this bug.

I modified DataPaginator in order to transform pages' numbers into a new facet.

If you wish I can post my sources.

Hey Admin, if you are interested in this change let me know I will explain my modifications.

Bye Bye Jacopo from Florence ITALY

Show

Jacopo Dell Anno added a comment - 16/Oct/09 1:34 PM I have found a solution to this bug. I modified DataPaginator in order to transform pages' numbers into a new facet. If you wish I can post my sources. Hey Admin, if you are interested in this change let me know I will explain my modifications. Bye Bye Jacopo from Florence ITALY

Hide

Permalink

Ken Fyten added a comment - 04/Nov/09 9:59 AM

We would be pleased to accept a contribution in this case. Please consult the "How To Contribute" page on .org for details: http://www.icefaces.org/main/community/contribute.iface.

Show

Ken Fyten added a comment - 04/Nov/09 9:59 AM We would be pleased to accept a contribution in this case. Please consult the "How To Contribute" page on .org for details: http://www.icefaces.org/main/community/contribute.iface .

Hide

Permalink

Jacopo Dell Anno added a comment - 13/Nov/09 2:50 AM - edited

First of all, I must say that before may 2009 I have never seen a JSF, only jsp and tag library.
So my modifications may be incomplete.
However I found a solution to the problem regarding no validation required during the navigation from a page to another by clicking on the specific page number.
The original renderer made use of HTML DOM to build the linked pages.

I created a new facet "paginax" (x page in italian) that creates an HtmlCommandLink.

-> HtmlCommandLink link = (HtmlCommandLink) getLinkPaginaX(facesContext, scroller, facetName, idx);

This seams to work fine.

Below how to call the modified DataPaginator tag.

<ice:dataPaginator for="#

{targetTable}

" renderFacetsIfSinglePage="false"
paginatorMaxPages="#

{maxPages}

" immediate="true" paginator="true">

<f:facet name="previous">
<ice:graphicImage url="images/arrow-previous.gif" title="PREVIOUS" />
</f:facet>

<f:facet name="paginax"> </f:facet>

<f:facet name="next">
<ice:graphicImage url="images/arrow-next.gif" title="NEXT" />
</f:facet>
</ice:dataPaginator>

my source at -> http://jira.icefaces.org/secure/attachment/12095/datapaginator.zip

Show

Jacopo Dell Anno added a comment - 13/Nov/09 2:50 AM - edited First of all, I must say that before may 2009 I have never seen a JSF, only jsp and tag library. So my modifications may be incomplete. However I found a solution to the problem regarding no validation required during the navigation from a page to another by clicking on the specific page number. The original renderer made use of HTML DOM to build the linked pages. I created a new facet "paginax" (x page in italian) that creates an HtmlCommandLink. -> HtmlCommandLink link = (HtmlCommandLink) getLinkPaginaX(facesContext, scroller, facetName, idx); This seams to work fine. Below how to call the modified DataPaginator tag. <ice:dataPaginator for="# {targetTable} " renderFacetsIfSinglePage="false" paginatorMaxPages="# {maxPages} " immediate="true" paginator="true"> <f:facet name="previous"> <ice:graphicImage url="images/arrow-previous.gif" title="PREVIOUS" /> </f:facet> <f:facet name="paginax"> </f:facet> <f:facet name="next"> <ice:graphicImage url="images/arrow-next.gif" title="NEXT" /> </f:facet> </ice:dataPaginator> my source at -> http://jira.icefaces.org/secure/attachment/12095/datapaginator.zip

Jacopo Dell Anno made changes - 13/Nov/09 2:50 AM

Attachment

datapaginator.zip [ 12095 ]

Ken Fyten made changes - 19/Nov/09 10:39 AM

Assignee Priority		P1
Assignee		Adnan Durrani [ adnan.durrani ]

Ken Fyten made changes - 19/Nov/09 10:39 AM

Fix Version/s		1.8.2-EE [ 10216 ]
Fix Version/s		1.8.3 [ 10211 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#19732	Thu Nov 19 12:37:29 MST 2009	adnan.durrani	Fix for ~~ICE-5010~~ (dataPaginator immediate=true partly ignored)
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginator.java

Adnan Durrani made changes - 19/Nov/09 2:48 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Hide

Permalink

Adnan Durrani added a comment - 19/Nov/09 2:51 PM

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Completed: At revision: 19732

Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Completed: At revision: 19733

Show

Adnan Durrani added a comment - 19/Nov/09 2:51 PM Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 19732 Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 19733

Adnan Durrani made changes - 19/Nov/09 2:51 PM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Joanne Bai added a comment - 24/Nov/09 5:51 PM

Fix verified successfully on ICEfaces-1.8.2-EE build 2

Verified on Tomcat 6 using FF3.5 and IE8

Test app is checked into repo\qa\trunk\Regression\~~ICE-5010~~

Show

Joanne Bai added a comment - 24/Nov/09 5:51 PM Fix verified successfully on ICEfaces-1.8.2-EE build 2 Verified on Tomcat 6 using FF3.5 and IE8 Test app is checked into repo\qa\trunk\Regression\ ICE-5010

Ken Fyten made changes - 06/May/10 11:42 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P1
Assignee	Adnan Durrani [ adnan.durrani ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#26342	Sun Nov 13 21:42:31 MST 2011	adnan.durrani	Fix for ~~ICE-7264~~ (Regression: ~~ICE-5010~~ ice:dataPaginator immediate=true partly ignored)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/datapaginator/DataPaginator.java

People

Assignee:

Unassigned

Reporter:

Patrick Dobler

Votes:

1 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

14/Oct/09 6:18 AM

Updated:

06/May/10 11:42 AM

Resolved:

19/Nov/09 2:51 PM