ICEfaces
  1. ICEfaces
  2. ICE-4834

"... views have accumulated updates" gets logged quite extensively in synchronousMode

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8, 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces Core, ICEfaces.org

            Description

            These seem to be logged quite extensively:

            ...
            2009-08-11 13:44:03,324 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [1] views have accumulated updates
            2009-08-11 13:44:03,326 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [3] views have accumulated updates
            2009-08-11 13:44:03,326 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [2] views have accumulated updates
            2009-08-11 13:44:03,326 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [1] views have accumulated updates
            2009-08-11 13:44:13,328 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [2] views have accumulated updates
            2009-08-11 13:44:13,328 WARN  [com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet] [8] views have accumulated updates
            ...

            However, ICEfaces.org uses synchronousMode, so should this even occur?

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Changed Fix Version(s) to 1.8.2

              Show
              Jack Van Ooststroom added a comment - Changed Fix Version(s) to 1.8.2
              Hide
              Permalink
              Mircea Toma added a comment -

              > 1. Get rid of the drainUpdatedViews logic.

              I would leave it in place to avoid memory leaks.

              > 2. Be considerate of the synchronous mode when adding commands to the queue that can cause view
              > numbers to be added to the allServedViews, which only seems to need to be used in asynchronous
              > mode.

              It is true that 'session-expired' command is put into the update queue regardless of the sync/async mode but it is useful in both cases. When the session expires in synchronous mode the user is notified about it next time is interacting with the application.

              > 3. Log a warning message when a synchronous ICEfaces application tries to initiate a Server Push
              > (if not already done so), preferably as early as possible.

              The warning message is logged synchronous ICEfaces application tries to initiate a Server Push (see PersistentFacesState.warnIfSynchronous method usages).

              In conclusion I believe that just removing "... views have accumulated updates" log message to get rid of the noise is the right solution.

              Show
              Mircea Toma added a comment - > 1. Get rid of the drainUpdatedViews logic. I would leave it in place to avoid memory leaks. > 2. Be considerate of the synchronous mode when adding commands to the queue that can cause view > numbers to be added to the allServedViews, which only seems to need to be used in asynchronous > mode. It is true that 'session-expired' command is put into the update queue regardless of the sync/async mode but it is useful in both cases. When the session expires in synchronous mode the user is notified about it next time is interacting with the application. > 3. Log a warning message when a synchronous ICEfaces application tries to initiate a Server Push > (if not already done so), preferably as early as possible. The warning message is logged synchronous ICEfaces application tries to initiate a Server Push (see PersistentFacesState.warnIfSynchronous method usages). In conclusion I believe that just removing "... views have accumulated updates" log message to get rid of the noise is the right solution.
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I've changed the logging level for this message to debug (from warn) to more accurately reflect the nature of the state being reported.

              Show
              Deryk Sinotte added a comment - I've changed the logging level for this message to debug (from warn) to more accurately reflect the nature of the state being reported.

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: