ICEfaces
  1. ICEfaces
  2. ICE-4764

dataExporter should not render RowSelector

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            any

            Description

            If a table column contains a RowSelector, it should not be rendered (not even once ;-).

              Activity

              Ascending order - Click to sort in descending order
              Thomas Greve created issue -
              Hide
              Permalink
              Thomas Greve added a comment -

              The attached diff contains these bug fixes and enhancements:
              + remove duplication of child rendering results
              + do not render RowSelector (there should be more special cases)
              + use StringBuilder instead of += (can be improved further)
              + log to commons.logging Log instead of stderr

              Show
              Thomas Greve added a comment - The attached diff contains these bug fixes and enhancements: + remove duplication of child rendering results + do not render RowSelector (there should be more special cases) + use StringBuilder instead of += (can be improved further) + log to commons.logging Log instead of stderr
              Thomas Greve made changes -
              Field Original Value New Value
              Attachment dataexport.diff [ 11883 ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Assigning to Ken for further assignment to the component team for review.

              Show
              Deryk Sinotte added a comment - Assigning to Ken for further assignment to the component team for review.
              Deryk Sinotte made changes -
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 1.8.2 [ 10190 ]
              Assignee Priority P2
              Assignee Ken Fyten [ ken.fyten ] Adnan Durrani [ adnan.durrani ]
              Ken Fyten made changes -
              Comment [ We will add a new component attribute called "ignorePagination", such that specifying "ignorePagination=true" will completely ignore the following two properties on the dataModel; rows, first, when exporting data for the dataExporter, and will instead export the complete dataset.

              ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19161 Fri Aug 14 14:56:33 MDT 2009 adnan.durrani rowSelector excluded. Related to ICE-4764.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/dataexporter/DataExporter.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19162 Mon Aug 17 09:50:50 MDT 2009 adnan.durrani Fix for ICE-4764(dataExporter should not render RowSelector)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/dataexporter/DataExporter.java
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              The suggested approach has been implemented to the fix.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java
              Completed: At revision: 19162

              Show
              Adnan Durrani added a comment - The suggested approach has been implemented to the fix. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java Completed: At revision: 19162
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Joanne Bai added a comment -

              Tested on ICEfaces trunk revision 19173 + tomcat6.0

              Tested with success on FF3.5. Testing on IE are blocked by ICE-4223 - IE cannot determine the file type while exporting

              Test app committed to repo\qa\trunk\Regression\ICE-4764

              Show
              Joanne Bai added a comment - Tested on ICEfaces trunk revision 19173 + tomcat6.0 Tested with success on FF3.5. Testing on IE are blocked by ICE-4223 - IE cannot determine the file type while exporting Test app committed to repo\qa\trunk\Regression\ ICE-4764
              Ken Fyten made changes -
              Fix Version/s 1.8.2-RC1 [ 10210 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20024 Fri Dec 18 11:36:35 MST 2009 adnan.durrani 1.8.2EE DataExporter changes moved to Compat DataExporter towards ICE-4481. The changes include the fix of following JIRAs ICE-4484, ICE-4390, ICE-4660, ICE-4223, ICE-4823, ICE-4836, ICE-4837, ICE-4764, ICE-4730, ICE-4844, ICE-4289, ICE-4826, ICE-4863, ICE-4934, ICE-4955
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-dataExporter-props.xml
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/META-INF/resources/ice-extras.js
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/dataTable-dataExporter.xhtml
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/dataexporter/DataExporter.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/dataexporter/DataExporterRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/util/CoreUtils.java
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Thomas Greve
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: