ICEfaces
  1. ICEfaces
  2. ICE-4764

dataExporter should not render RowSelector

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            any

            Description

            If a table column contains a RowSelector, it should not be rendered (not even once ;-).

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Thomas Greve added a comment -

              The attached diff contains these bug fixes and enhancements:
              + remove duplication of child rendering results
              + do not render RowSelector (there should be more special cases)
              + use StringBuilder instead of += (can be improved further)
              + log to commons.logging Log instead of stderr

              Show
              Thomas Greve added a comment - The attached diff contains these bug fixes and enhancements: + remove duplication of child rendering results + do not render RowSelector (there should be more special cases) + use StringBuilder instead of += (can be improved further) + log to commons.logging Log instead of stderr
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Assigning to Ken for further assignment to the component team for review.

              Show
              Deryk Sinotte added a comment - Assigning to Ken for further assignment to the component team for review.
              Hide
              Permalink
              Adnan Durrani added a comment -

              The suggested approach has been implemented to the fix.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java
              Completed: At revision: 19162

              Show
              Adnan Durrani added a comment - The suggested approach has been implemented to the fix. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\dataexporter\DataExporter.java Completed: At revision: 19162
              Hide
              Permalink
              Joanne Bai added a comment -

              Tested on ICEfaces trunk revision 19173 + tomcat6.0

              Tested with success on FF3.5. Testing on IE are blocked by ICE-4223 - IE cannot determine the file type while exporting

              Test app committed to repo\qa\trunk\Regression\ICE-4764

              Show
              Joanne Bai added a comment - Tested on ICEfaces trunk revision 19173 + tomcat6.0 Tested with success on FF3.5. Testing on IE are blocked by ICE-4223 - IE cannot determine the file type while exporting Test app committed to repo\qa\trunk\Regression\ ICE-4764

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Thomas Greve
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: