[ICE-4758] inputRichtext: Can't remove style that is applies to text in IE - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.1
Fix Version/s: 1.8.2-RC1, 1.8.2
Component/s: ICE-Components
Labels:
None
Environment:
IE

Description

In IE if some text is highlighted and then style is applied via the drop down menu. These styles can't be removed. This isn't a problem in Firefox.

Sample code:
<ice:inputRichText height="300px" width="600px"
                                   skin="silver" toolbar="Default"
                                   saveOnSubmit="true"
                                   value="contentField" rendered="true" >
</ice:inputRichText>

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case8512Example2.war

04/Aug/09 11:05 AM

6.14 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/.../example/TestBean.class 1 kB

WEB-INF/faces-config.xml 0.5 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-el.jar 110 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-lang.jar 240 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.93 MB

WEB-INF/lib/icefaces.jar 1.06 MB

WEB-INF/lib/jsf-api.jar 356 kB

WEB-INF/lib/jsf-impl.jar 778 kB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/web.xml 3 kB

index.jsp 0.1 kB

js/config.js 1 kB

main.jspx 4 kB

Download Zip
Show

Case8512Example2.war

04/Aug/09 11:05 AM

6.14 MB

Arran Mccullough

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 23/Jul/09 4:49 PM

Arran Mccullough made changes - 23/Jul/09 4:49 PM

Field	Original Value	New Value
Salesforce Case		[50070000009Mnig]

Deryk Sinotte made changes - 29/Jul/09 11:57 AM

Fix Version/s		1.8.2 [ 10190 ]
Assignee Priority		P2
Assignee		Adnan Durrani [ adnan.durrani ]

Adnan Durrani made changes - 31/Jul/09 4:03 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Hide

Permalink

Adnan Durrani added a comment - 31/Jul/09 4:04 PM

I am not able to reproduce it, can you please post some steps and screen shots?

Show

Adnan Durrani added a comment - 31/Jul/09 4:04 PM I am not able to reproduce it, can you please post some steps and screen shots?

Arran Mccullough made changes - 04/Aug/09 11:05 AM

Attachment

Case8512Example2.war [ 11906 ]

Hide

Permalink

Arran Mccullough added a comment - 04/Aug/09 11:09 AM

I've attached a test case where I can replicate this issue. Steps to reproduce:

Type in some text in the text field.
Highlight the text.
Change the style for the text, for example: "Deleted Text".
Go back and try and remove the "Deleted Text" style, in IE it doesn't get removed.

Also one thing to note is that I can't replicate this in the Component Showcase.

Show

Arran Mccullough added a comment - 04/Aug/09 11:09 AM I've attached a test case where I can replicate this issue. Steps to reproduce: Type in some text in the text field. Highlight the text. Change the style for the text, for example: "Deleted Text". Go back and try and remove the "Deleted Text" style, in IE it doesn't get removed. Also one thing to note is that I can't replicate this in the Component Showcase.

Hide

Permalink

Adnan Durrani added a comment - 04/Aug/09 3:24 PM

Is this specific to any version of IE?

Show

Adnan Durrani added a comment - 04/Aug/09 3:24 PM Is this specific to any version of IE?

Hide

Permalink

Arran Mccullough added a comment - 04/Aug/09 3:35 PM

I've only tested with IE7.

Show

Arran Mccullough added a comment - 04/Aug/09 3:35 PM I've only tested with IE7.

Hide

Permalink

Adnan Durrani added a comment - 04/Aug/09 5:31 PM

Arran can you please apply above steps to the following link unde IE 7:
http://www.fckeditor.net/demo

Did you see the same behaviour?

Show

Adnan Durrani added a comment - 04/Aug/09 5:31 PM Arran can you please apply above steps to the following link unde IE 7: http://www.fckeditor.net/demo Did you see the same behaviour?

Hide

Permalink

Arran Mccullough added a comment - 05/Aug/09 9:49 AM

I don't see the same behavior on the FCKEditor demo. I have noticed that when its working the added style is highlighted the same as the text (in white). When the added style can't be removed it is in black when the text is in white. This is when everything is highlighted/selected.

Show

Arran Mccullough added a comment - 05/Aug/09 9:49 AM I don't see the same behavior on the FCKEditor demo. I have noticed that when its working the added style is highlighted the same as the text (in white). When the added style can't be removed it is in black when the text is in white. This is when everything is highlighted/selected.

Hide

Permalink

Adnan Durrani added a comment - 27/Aug/09 4:08 PM

After testing FCK API painstakingly, It came across that its due to a call of editor.GetXHTML function. After google I found that this bug was introduced to the FCKEditor since FCKeditor 2.6.3 and seems like its fixed a month ago and targeted to FCKeditor 2.6.5.

The FCKEditor release is used by ICEFaces is 2.6.4

http://dev.fckeditor.net/ticket/325
http://dev.fckeditor.net/ticket/2834
http://dev.fckeditor.net/ticket/2156

Show

Adnan Durrani added a comment - 27/Aug/09 4:08 PM After testing FCK API painstakingly, It came across that its due to a call of editor.GetXHTML function. After google I found that this bug was introduced to the FCKEditor since FCKeditor 2.6.3 and seems like its fixed a month ago and targeted to FCKeditor 2.6.5. The FCKEditor release is used by ICEFaces is 2.6.4 http://dev.fckeditor.net/ticket/325 http://dev.fckeditor.net/ticket/2834 http://dev.fckeditor.net/ticket/2156

Adnan Durrani made changes - 27/Aug/09 4:10 PM

Assignee

Adnan Durrani [ adnan.durrani ]

Ken Fyten [ ken.fyten ]

Ken Fyten made changes - 27/Aug/09 5:52 PM

Assignee

Ken Fyten [ ken.fyten ]

Adnan Durrani [ adnan.durrani ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#19205	Tue Sep 01 10:02:25 MDT 2009	adnan.durrani	Fix for ~~ICE-4758~~ (inputRichtext: Can't remove style that is applies to text in IE) Following FCK patch applied: http://dev.fckeditor.net/changeset/3882
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputrichtext/fckeditor.zip

Hide

Permalink

Adnan Durrani added a comment - 01/Sep/09 12:19 PM

Following FCK patch applied:
http://dev.fckeditor.net/changeset/3882

The following 3 files were involved in the patch. Further patch details can be found in above link.
editor/_source/internals/fckdomtools.js
editor/_source/internals/fckxhtml_ie.js
editor/_source/internals/fckxhtml.js

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputrichtext\fckeditor.zip
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputrichtext\fckeditor.zip
Completed: At revision: 19205

Show

Adnan Durrani added a comment - 01/Sep/09 12:19 PM Following FCK patch applied: http://dev.fckeditor.net/changeset/3882 The following 3 files were involved in the patch. Further patch details can be found in above link. editor/_source/internals/fckdomtools.js editor/_source/internals/fckxhtml_ie.js editor/_source/internals/fckxhtml.js Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputrichtext\fckeditor.zip Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputrichtext\fckeditor.zip Completed: At revision: 19205

Adnan Durrani made changes - 01/Sep/09 12:19 PM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Joanne Bai added a comment - 06/Sep/09 11:30 AM

Test result on ICEfaces trunk revision 19228

In IE6 and 7 the applied style ("Deleted Text", for example) doesn't get removed
Works fine in FF3.5

Test app committed to repo\qa\trunk\Regression\~~ICE-4758~~

Show

Joanne Bai added a comment - 06/Sep/09 11:30 AM Test result on ICEfaces trunk revision 19228 In IE6 and 7 the applied style ("Deleted Text", for example) doesn't get removed Works fine in FF3.5 Test app committed to repo\qa\trunk\Regression\ ICE-4758

Ken Fyten made changes - 15/Sep/09 11:42 AM

Fix Version/s

1.8.2-RC1 [ 10210 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#19943	Thu Dec 10 14:01:36 MST 2009	adnan.durrani	1.8.2EE inputRichText changes moved to Compat inputRichText towards ~~ICE-4481~~. The changes include the fix of following JIRAs ~~ICE-4495~~, ~~ICE-4424~~, ~~ICE-3965~~, ~~ICE-4698~~, ~~ICE-4760~~, ~~ICE-4850~~, ~~ICE-4758~~, ~~ICE-4961~~
				Files Changed
				MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/fckeditor_ext.js MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/fckeditor.zip MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/InputRichTextRenderer.java

Ken Fyten made changes - 07/Jan/10 12:04 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2

People

Assignee:

Adnan Durrani

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

23/Jul/09 4:49 PM

Updated:

07/Jan/10 12:04 PM

Resolved:

01/Sep/09 12:19 PM