ICEfaces
  1. ICEfaces
  2. ICE-4738

REGRESSION: PanelCollapsible styling problem

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            IE7 and IE8 styling collapsible

            Description

            IE7 and IE8 has styling problem displaying the collapsible title bars (see the attached screen shot).

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19101 Tue Jul 21 18:04:16 MDT 2009 adnan.durrani Fix for ICE-4738 (REGRESSION: PanelCollapsible styling problem)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
              Adnan Durrani created issue -
              Adnan Durrani made changes -
              Field Original Value New Value
              Assignee Adnan Durrani [ adnan.durrani ]
              Adnan Durrani made changes -
              Attachment IE7-stylingProblem.JPG [ 11868 ]
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Its a regression of ICE-4674

              Show
              Adnan Durrani added a comment - Its a regression of ICE-4674
              Hide
              Permalink
              Adnan Durrani added a comment -

              Fixed.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java
              Completed: At revision: 19101

              Show
              Adnan Durrani added a comment - Fixed. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java Completed: At revision: 19101
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Fix Version/s 1.8.2 [ 10190 ]
              Resolution Fixed [ 1 ]
              Adnan Durrani made changes -
              Attachment ICE-4738-After-Fix.jpg [ 11869 ]
              Hide
              Permalink
              Krashan Brahmanjara added a comment -

              I suppose that is not good solution. Div reflects onClick and anchor is not necessary. What element/attribute need this anchor?

              Under IE6 also we can see that collapsible got header structure (<div><a><div/></div>) .This sometimes generates collapsible header with double height.

              Invalid anchor
              <a onfocus="Ice.pnlClpFocus(this);" onblur="Ice.pnlClpBlur(this);" href="#">
              <img \="" src="/oss-web/xmlhttp/css/xp/css-images/spacer.gif"/>
              </a>

              We got success with this code disabled (PanelCollapsibleRenderer.java Lines 72 to 78)
              // Element anchor = domContext.createElement (HTML.ANCHOR_ELEM);
              // anchor.setAttribute(HTML.ONFOCUS_ATTR, "Ice.pnlClpFocus (this);");
              // anchor.setAttribute(HTML.ONBLUR_ATTR, "Ice.pnlClpBlur (this);");
              // anchor.setAttribute(HTML.HREF_ATTR, "#");
              // anchor.appendChild(domContext.createTextNode("<img src='"+ CoreUtils.resolveResourceURL(facesContext,
              // "/xmlhttp/css/xp/css-images/spacer.gif") + "'
              >"));
              // header.appendChild(anchor);

              Show
              Krashan Brahmanjara added a comment - I suppose that is not good solution. Div reflects onClick and anchor is not necessary. What element/attribute need this anchor? Under IE6 also we can see that collapsible got header structure (<div><a><div/></div>) .This sometimes generates collapsible header with double height. Invalid anchor <a onfocus="Ice.pnlClpFocus(this);" onblur="Ice.pnlClpBlur(this);" href="#"> <img \="" src="/oss-web/xmlhttp/css/xp/css-images/spacer.gif"/> </a> We got success with this code disabled (PanelCollapsibleRenderer.java Lines 72 to 78) // Element anchor = domContext.createElement (HTML.ANCHOR_ELEM); // anchor.setAttribute(HTML.ONFOCUS_ATTR, "Ice.pnlClpFocus (this);"); // anchor.setAttribute(HTML.ONBLUR_ATTR, "Ice.pnlClpBlur (this);"); // anchor.setAttribute(HTML.HREF_ATTR, "#"); // anchor.appendChild(domContext.createTextNode("<img src='"+ CoreUtils.resolveResourceURL(facesContext, // "/xmlhttp/css/xp/css-images/spacer.gif") + "' >")); // header.appendChild(anchor);
              Hide
              Permalink
              Adnan Durrani added a comment -

              The anchor is there not for onclick, its there for div to simulate focus. You can create a separate JIRA for wrong behaviour or style related problem if you have any.

              Show
              Adnan Durrani added a comment - The anchor is there not for onclick, its there for div to simulate focus. You can create a separate JIRA for wrong behaviour or style related problem if you have any.
              Ken Fyten made changes -
              Fix Version/s 1.8.2-RC1 [ 10210 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19932 Thu Dec 10 09:02:04 MST 2009 adnan.durrani 1.8.2EE panelCollapsible changes moved to Compat panelCollapsible towards ICE-4481. The changes include the fix of following JIRAs: ICE-4674, ICE-4738
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/META-INF/resources/ice-extras.js
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/css/showcase_style.css
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsible.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/util/CoreUtils.java
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Adnan Durrani
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: