ICEfaces
  1. ICEfaces
  2. ICE-4738

REGRESSION: PanelCollapsible styling problem

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.1
    • Fix Version/s: 1.8.2-RC1, 1.8.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      IE7 and IE8 styling collapsible

      Description

      IE7 and IE8 has styling problem displaying the collapsible title bars (see the attached screen shot).

        Activity

        Hide
        Adnan Durrani added a comment -

        Its a regression of ICE-4674

        Show
        Adnan Durrani added a comment - Its a regression of ICE-4674
        Hide
        Adnan Durrani added a comment -

        Fixed.

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java
        Completed: At revision: 19101

        Show
        Adnan Durrani added a comment - Fixed. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsibleRenderer.java Completed: At revision: 19101
        Hide
        Krashan Brahmanjara added a comment -

        I suppose that is not good solution. Div reflects onClick and anchor is not necessary. What element/attribute need this anchor?

        Under IE6 also we can see that collapsible got header structure (<div><a><div/></div>) .This sometimes generates collapsible header with double height.

        Invalid anchor
        <a onfocus="Ice.pnlClpFocus(this);" onblur="Ice.pnlClpBlur(this);" href="#">
        <img \="" src="/oss-web/xmlhttp/css/xp/css-images/spacer.gif"/>
        </a>

        We got success with this code disabled (PanelCollapsibleRenderer.java Lines 72 to 78)
        // Element anchor = domContext.createElement (HTML.ANCHOR_ELEM);
        // anchor.setAttribute(HTML.ONFOCUS_ATTR, "Ice.pnlClpFocus (this);");
        // anchor.setAttribute(HTML.ONBLUR_ATTR, "Ice.pnlClpBlur (this);");
        // anchor.setAttribute(HTML.HREF_ATTR, "#");
        // anchor.appendChild(domContext.createTextNode("<img src='"+ CoreUtils.resolveResourceURL(facesContext,
        // "/xmlhttp/css/xp/css-images/spacer.gif") + "'
        >"));
        // header.appendChild(anchor);

        Show
        Krashan Brahmanjara added a comment - I suppose that is not good solution. Div reflects onClick and anchor is not necessary. What element/attribute need this anchor? Under IE6 also we can see that collapsible got header structure (<div><a><div/></div>) .This sometimes generates collapsible header with double height. Invalid anchor <a onfocus="Ice.pnlClpFocus(this);" onblur="Ice.pnlClpBlur(this);" href="#"> <img \="" src="/oss-web/xmlhttp/css/xp/css-images/spacer.gif"/> </a> We got success with this code disabled (PanelCollapsibleRenderer.java Lines 72 to 78) // Element anchor = domContext.createElement (HTML.ANCHOR_ELEM); // anchor.setAttribute(HTML.ONFOCUS_ATTR, "Ice.pnlClpFocus (this);"); // anchor.setAttribute(HTML.ONBLUR_ATTR, "Ice.pnlClpBlur (this);"); // anchor.setAttribute(HTML.HREF_ATTR, "#"); // anchor.appendChild(domContext.createTextNode("<img src='"+ CoreUtils.resolveResourceURL(facesContext, // "/xmlhttp/css/xp/css-images/spacer.gif") + "' >")); // header.appendChild(anchor);
        Hide
        Adnan Durrani added a comment -

        The anchor is there not for onclick, its there for div to simulate focus. You can create a separate JIRA for wrong behaviour or style related problem if you have any.

        Show
        Adnan Durrani added a comment - The anchor is there not for onclick, its there for div to simulate focus. You can create a separate JIRA for wrong behaviour or style related problem if you have any.

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Adnan Durrani
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: