[ICE-4685] Issues with autoCentre, draggable, positioning, and modal background with multiple modal popups - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.1
Fix Version/s: 1.8.2-RC1, 1.8.2
Component/s: ICE-Components
Labels:
None
Environment:
All

Description

There are a few strange behaviors when using multiple modal popups on a page. The attached example has a commandButton that opens a modal popup. On this modal popup there is another commandButton that opens another modal popup. This second popup is defined outside of the first popup, it is included with a ui:include on its own page.

Issue #1: At first load everything is auto centered as it should be. When the popups are closed and then opened again, they are not auto centered.

Issue #2: Including the fixes made for ~~ICE-4475~~ and ~~ICE-4595~~ into ICEfaces 1.8.1. When the second popup is shown with the first popup, closing the second/top most popup removes the modal background for all popups. This is not an issue with regular 1.8.1.

Issue #3: When both popups are shown and one popup is dragged the other popup changes its position on the screen in a random way.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Case8410Example3.zip

14/Jul/09 11:01 AM

17 kB

Arran Mccullough
Hide
ICE-4685.war

28/Jul/09 4:25 PM

5.55 MB

yip.ng
META-INF/MANIFEST.MF 0.1 kB

WEB-INF/classes/.../beans/PopupBean.class 1 kB

WEB-INF/classes/com/.../beans/PopupBean.java 1.0 kB

WEB-INF/faces-config.xml 0.6 kB

WEB-INF/ibm-web-bnd.xmi 0.3 kB

WEB-INF/ibm-web-ext.xmi 0.4 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-el.jar 110 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.93 MB

WEB-INF/lib/icefaces.jar 1.17 MB

WEB-INF/lib/jsf-api-1.2.jar 350 kB

WEB-INF/lib/jsf-impl-1.2.jar 816 kB

WEB-INF/lib/jstl.jar 20 kB

index.jsp 0.1 kB

testFile.jspx 2 kB

WEB-INF/web.xml 6 kB

Download Zip
Show

ICE-4685.war

28/Jul/09 4:25 PM

5.55 MB

yip.ng
ICE-4685.zip

28/Jul/09 4:28 PM

6 kB

yip.ng

ScreenHunter_01.jpg

187 kB

13/Jul/09 3:22 PM
Screenshot-02.JPG

236 kB

28/Jul/09 10:56 AM

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 08/Jul/09 4:37 PM

Arran Mccullough made changes - 08/Jul/09 4:37 PM

Field	Original Value	New Value
Salesforce Case		[50070000009KDJN]

Hide

Permalink

Arran Mccullough added a comment - 08/Jul/09 4:39 PM

NetBeans created test case

Show

Arran Mccullough added a comment - 08/Jul/09 4:39 PM NetBeans created test case

Arran Mccullough made changes - 08/Jul/09 4:39 PM

Attachment

Case8410Example2.zip [ 11824 ]

Ken Fyten made changes - 10/Jul/09 1:29 PM

Fix Version/s		1.8.2 [ 10190 ]
Assignee Priority		P2
Assignee		Yip Ng [ yip.ng ]

yip.ng made changes - 13/Jul/09 3:22 PM

Attachment

ScreenHunter_01.jpg [ 11837 ]

Hide

Permalink

yip.ng added a comment - 13/Jul/09 3:24 PM

Got an error when clicking on the "open First popup" button. See screenshot 01.

Show

yip.ng added a comment - 13/Jul/09 3:24 PM Got an error when clicking on the "open First popup" button. See screenshot 01.

Arran Mccullough made changes - 14/Jul/09 11:01 AM

Attachment

Case8410Example3.zip [ 11840 ]

Hide

Permalink

Arran Mccullough added a comment - 14/Jul/09 11:02 AM

Added a new scaled down test-case.

In creating this case I found out a few things. Issue #2 seems to only happen when Facelets is used. Issue #1 now only happens with the second popup and not the first. Issue #3 still remains as the same.

Show

Arran Mccullough added a comment - 14/Jul/09 11:02 AM Added a new scaled down test-case. In creating this case I found out a few things. Issue #2 seems to only happen when Facelets is used. Issue #1 now only happens with the second popup and not the first. Issue #3 still remains as the same.

Arran Mccullough made changes - 14/Jul/09 11:03 AM

Attachment

Case8410Example2.zip [ 11824 ]

yip.ng made changes - 28/Jul/09 10:56 AM

Attachment

Screenshot-02.JPG [ 11891 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#19125	Tue Jul 28 13:34:52 MDT 2009	yip.ng	~~ICE-4685~~ Added handling of multi-layer modal dialogs.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js

yip.ng made changes - 28/Jul/09 4:25 PM

Attachment

ICE-4685.war [ 11893 ]

yip.ng made changes - 28/Jul/09 4:28 PM

Attachment

ICE-4685.zip [ 11894 ]

Hide

Permalink

yip.ng added a comment - 28/Jul/09 4:41 PM - edited

Issue #2 fixed by adding/changing code to handle more than one modal popup. (Note that you have to make sure that the popups have unique id's.)

Issue #1 split into ~~ICE-4780~~.

Issue #3 split into ~~ICE-4781~~.

Show

yip.ng added a comment - 28/Jul/09 4:41 PM - edited Issue #2 fixed by adding/changing code to handle more than one modal popup. (Note that you have to make sure that the popups have unique id's.) Issue #1 split into ICE-4780 . Issue #3 split into ICE-4781 .

yip.ng made changes - 28/Jul/09 4:41 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 30/Jul/09 4:17 PM - edited

Similar problem in ICE-4734.
Patch not fix all problems. Somewhere beetwen revisions 19035 and 19123 iframes started disappears.

On modal start. Modal window is shown but without iframe.

response on modal start
new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable
.onLoad('tbd2:tabList2');Ice.autoPosition.stop('tbd2:de0');Ice.autoCentre.start('tbd2:de0');Ice.iFrameFix
.start('tbd2:de0','/oss-web/xmlhttp/blank');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2:j_id27'
);//-32312256

response on modal close
new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable
.onLoad('tbd2:tabList2');Ice.modal.stop('tbd2:de0');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2
:anulujEdytor');//1740165098

As you see sometimes Ice.modal.stop is called onstart and twice onclose ???

Show

Krashan Brahmanjara added a comment - 30/Jul/09 4:17 PM - edited Similar problem in ICE-4734 . Patch not fix all problems. Somewhere beetwen revisions 19035 and 19123 iframes started disappears. On modal start. Modal window is shown but without iframe. response on modal start new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable .onLoad('tbd2:tabList2');Ice.autoPosition.stop('tbd2:de0');Ice.autoCentre.start('tbd2:de0');Ice.iFrameFix .start('tbd2:de0','/oss-web/xmlhttp/blank');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2:j_id27' );//-32312256 response on modal close new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable .onLoad('tbd2:tabList2');Ice.modal.stop('tbd2:de0');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2 :anulujEdytor');//1740165098 As you see sometimes Ice.modal.stop is called onstart and twice onclose ???

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#19139	Fri Jul 31 17:10:07 MDT 2009	yip.ng	~~ICE-4685~~ Added handling of multi-layer modal dialogs.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/dragdrop_custom.js

Hide

Permalink

Krashan Brahmanjara added a comment - 05/Aug/09 6:37 AM

After last modification up to revison 19140 popup almost works in simply cases.

I got some apps with complex views. If I open second popup on top of first popup then console logs shows to many callse to ice.modal.start. Popup in background is already openeded and positioned but framework force next start? Also resize command is sometimes called twice.

Console log show actions on second popup view request, page:je1 is first already opened popup.

window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:je1', '/aweb/xmlhttp/blank', '',false);
[window.dragDrop] : Ice.modal.start id:page:je1
[window.dragDrop] : Ice.modal.start iframe creator id:page:je1
[window.dragDrop] : Ice.modal.resize id:page:je1
[window.dragDrop] : Ice.modal.resize id:page:je1
window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:fip1', '/aweb/xmlhttp/blank', '',false);
[window.dragDrop] : Ice.modal.start id:page:fip1
[window.dragDrop] : Ice.modal.start iframe creator id:page:fip1
[window.dragDrop] : Ice.modal.resize id:page:fip1
[window.dragDrop] : Ice.modal.resize id:page:je1
[window.dragDrop] : Ice.autoPosition.stop id:page:je1
[window.dragDrop] : Ice.autoCentre.stop id:page:je1
[window.dragDrop] : Ice.autoPosition.stop id:page:fip1
[window.dragDrop] : Ice.autoCentre.stop id:page:fip1
window.5C6h#1 : applied update : <script id="5C6hOkss32ychqHUI-Wohg:1:dynamic-code" type="text/javascript">...</script>

Show

Krashan Brahmanjara added a comment - 05/Aug/09 6:37 AM After last modification up to revison 19140 popup almost works in simply cases. I got some apps with complex views. If I open second popup on top of first popup then console logs shows to many callse to ice.modal.start. Popup in background is already openeded and positioned but framework force next start? Also resize command is sometimes called twice. Console log show actions on second popup view request, page:je1 is first already opened popup. window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:je1', '/aweb/xmlhttp/blank', '',false); [window.dragDrop] : Ice.modal.start id:page:je1 [window.dragDrop] : Ice.modal.start iframe creator id:page:je1 [window.dragDrop] : Ice.modal.resize id:page:je1 [window.dragDrop] : Ice.modal.resize id:page:je1 window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:fip1', '/aweb/xmlhttp/blank', '',false); [window.dragDrop] : Ice.modal.start id:page:fip1 [window.dragDrop] : Ice.modal.start iframe creator id:page:fip1 [window.dragDrop] : Ice.modal.resize id:page:fip1 [window.dragDrop] : Ice.modal.resize id:page:je1 [window.dragDrop] : Ice.autoPosition.stop id:page:je1 [window.dragDrop] : Ice.autoCentre.stop id:page:je1 [window.dragDrop] : Ice.autoPosition.stop id:page:fip1 [window.dragDrop] : Ice.autoCentre.stop id:page:fip1 window.5C6h#1 : applied update : <script id="5C6hOkss32ychqHUI-Wohg:1:dynamic-code" type="text/javascript">...</script>

Hide

Permalink

Joanne Bai added a comment - 19/Aug/09 3:03 PM

QA successfully verified all three issues on ICEfaces trunk revision 19173.

Also, a header/body width issue was found during the verifying. New JIRA ICE-4847 has been created for the new issue.

Test app committed to repo\qa\trunk\Regression\~~ICE-4685~~

Show

Joanne Bai added a comment - 19/Aug/09 3:03 PM QA successfully verified all three issues on ICEfaces trunk revision 19173. Also, a header/body width issue was found during the verifying. New JIRA ICE-4847 has been created for the new issue. Test app committed to repo\qa\trunk\Regression\ ICE-4685

Ken Fyten made changes - 15/Sep/09 11:42 AM

Fix Version/s

1.8.2-RC1 [ 10210 ]

Ken Fyten made changes - 07/Jan/10 12:04 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2

People

Assignee:

yip.ng

Reporter:

Arran Mccullough

Votes:

1 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

08/Jul/09 4:37 PM

Updated:

07/Jan/10 12:04 PM

Resolved:

28/Jul/09 4:41 PM