ICEfaces
  1. ICEfaces
  2. ICE-4685

Issues with autoCentre, draggable, positioning, and modal background with multiple modal popups

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            There are a few strange behaviors when using multiple modal popups on a page. The attached example has a commandButton that opens a modal popup. On this modal popup there is another commandButton that opens another modal popup. This second popup is defined outside of the first popup, it is included with a ui:include on its own page.

            Issue #1: At first load everything is auto centered as it should be. When the popups are closed and then opened again, they are not auto centered.

            Issue #2: Including the fixes made for ICE-4475 and ICE-4595 into ICEfaces 1.8.1. When the second popup is shown with the first popup, closing the second/top most popup removes the modal background for all popups. This is not an issue with regular 1.8.1.

            Issue #3: When both popups are shown and one popup is dragged the other popup changes its position on the screen in a random way.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              NetBeans created test case

              Show
              Arran Mccullough added a comment - NetBeans created test case
              Hide
              Permalink
              yip.ng added a comment -

              Got an error when clicking on the "open First popup" button. See screenshot 01.

              Show
              yip.ng added a comment - Got an error when clicking on the "open First popup" button. See screenshot 01.
              Hide
              Permalink
              Arran Mccullough added a comment -

              Added a new scaled down test-case.

              In creating this case I found out a few things. Issue #2 seems to only happen when Facelets is used. Issue #1 now only happens with the second popup and not the first. Issue #3 still remains as the same.

              Show
              Arran Mccullough added a comment - Added a new scaled down test-case. In creating this case I found out a few things. Issue #2 seems to only happen when Facelets is used. Issue #1 now only happens with the second popup and not the first. Issue #3 still remains as the same.
              Hide
              Permalink
              yip.ng added a comment - - edited

              Issue #2 fixed by adding/changing code to handle more than one modal popup. (Note that you have to make sure that the popups have unique id's.)

              Issue #1 split into ICE-4780.

              Issue #3 split into ICE-4781.

              Show
              yip.ng added a comment - - edited Issue #2 fixed by adding/changing code to handle more than one modal popup. (Note that you have to make sure that the popups have unique id's.) Issue #1 split into ICE-4780 . Issue #3 split into ICE-4781 .
              Hide
              Permalink
              Krashan Brahmanjara added a comment - - edited

              Similar problem in ICE-4734.
              Patch not fix all problems. Somewhere beetwen revisions 19035 and 19123 iframes started disappears.

              On modal start. Modal window is shown but without iframe.

              response on modal start
              new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable
              .onLoad('tbd2:tabList2');Ice.autoPosition.stop('tbd2:de0');Ice.autoCentre.start('tbd2:de0');Ice.iFrameFix
              .start('tbd2:de0','/oss-web/xmlhttp/blank');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2:j_id27'
              );//-32312256

              response on modal close
              new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable
              .onLoad('tbd2:tabList2');Ice.modal.stop('tbd2:de0');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2
              :anulujEdytor');//1740165098

              As you see sometimes Ice.modal.stop is called onstart and twice onclose ???

              Show
              Krashan Brahmanjara added a comment - - edited Similar problem in ICE-4734 . Patch not fix all problems. Somewhere beetwen revisions 19035 and 19123 iframes started disappears. On modal start. Modal window is shown but without iframe. response on modal start new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable .onLoad('tbd2:tabList2');Ice.autoPosition.stop('tbd2:de0');Ice.autoCentre.start('tbd2:de0');Ice.iFrameFix .start('tbd2:de0','/oss-web/xmlhttp/blank');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2:j_id27' );//-32312256 response on modal close new Ice.MenuBarKeyNavigator('menuActions:menuBar', true);Ice.dataTable.onLoad('tbd2:tabList');Ice.dataTable .onLoad('tbd2:tabList2');Ice.modal.stop('tbd2:de0');Ice.modal.stop('tbd2:de0');Ice.Focus.setFocus('tbd2 :anulujEdytor');//1740165098 As you see sometimes Ice.modal.stop is called onstart and twice onclose ???
              Hide
              Permalink
              Krashan Brahmanjara added a comment -

              After last modification up to revison 19140 popup almost works in simply cases.

              I got some apps with complex views. If I open second popup on top of first popup then console logs shows to many callse to ice.modal.start. Popup in background is already openeded and positioned but framework force next start? Also resize command is sometimes called twice.

              Console log show actions on second popup view request, page:je1 is first already opened popup.

              window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:je1', '/aweb/xmlhttp/blank', '',false);
              [window.dragDrop] : Ice.modal.start id:page:je1
              [window.dragDrop] : Ice.modal.start iframe creator id:page:je1
              [window.dragDrop] : Ice.modal.resize id:page:je1
              [window.dragDrop] : Ice.modal.resize id:page:je1
              window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:fip1', '/aweb/xmlhttp/blank', '',false);
              [window.dragDrop] : Ice.modal.start id:page:fip1
              [window.dragDrop] : Ice.modal.start iframe creator id:page:fip1
              [window.dragDrop] : Ice.modal.resize id:page:fip1
              [window.dragDrop] : Ice.modal.resize id:page:je1
              [window.dragDrop] : Ice.autoPosition.stop id:page:je1
              [window.dragDrop] : Ice.autoCentre.stop id:page:je1
              [window.dragDrop] : Ice.autoPosition.stop id:page:fip1
              [window.dragDrop] : Ice.autoCentre.stop id:page:fip1
              window.5C6h#1 : applied update : <script id="5C6hOkss32ychqHUI-Wohg:1:dynamic-code" type="text/javascript">...</script>

              Show
              Krashan Brahmanjara added a comment - After last modification up to revison 19140 popup almost works in simply cases. I got some apps with complex views. If I open second popup on top of first popup then console logs shows to many callse to ice.modal.start. Popup in background is already openeded and positioned but framework force next start? Also resize command is sometimes called twice. Console log show actions on second popup view request, page:je1 is first already opened popup. window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:je1', '/aweb/xmlhttp/blank', '',false); [window.dragDrop] : Ice.modal.start id:page:je1 [window.dragDrop] : Ice.modal.start iframe creator id:page:je1 [window.dragDrop] : Ice.modal.resize id:page:je1 [window.dragDrop] : Ice.modal.resize id:page:je1 window.5C6h#1.script-loader : evaluating script : Ice.modal.start('page:fip1', '/aweb/xmlhttp/blank', '',false); [window.dragDrop] : Ice.modal.start id:page:fip1 [window.dragDrop] : Ice.modal.start iframe creator id:page:fip1 [window.dragDrop] : Ice.modal.resize id:page:fip1 [window.dragDrop] : Ice.modal.resize id:page:je1 [window.dragDrop] : Ice.autoPosition.stop id:page:je1 [window.dragDrop] : Ice.autoCentre.stop id:page:je1 [window.dragDrop] : Ice.autoPosition.stop id:page:fip1 [window.dragDrop] : Ice.autoCentre.stop id:page:fip1 window.5C6h#1 : applied update : <script id="5C6hOkss32ychqHUI-Wohg:1:dynamic-code" type="text/javascript">...</script>
              Hide
              Permalink
              Joanne Bai added a comment -

              QA successfully verified all three issues on ICEfaces trunk revision 19173.

              Also, a header/body width issue was found during the verifying. New JIRA ICE-4847 has been created for the new issue.

              Test app committed to repo\qa\trunk\Regression\ICE-4685

              Show
              Joanne Bai added a comment - QA successfully verified all three issues on ICEfaces trunk revision 19173. Also, a header/body width issue was found during the verifying. New JIRA ICE-4847 has been created for the new issue. Test app committed to repo\qa\trunk\Regression\ ICE-4685

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Arran Mccullough
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: