ICEfaces
  1. ICEfaces
  2. ICE-4616

ICEfaces 2.0: compat auctionMonitor rendering and interactivity

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Alpha2, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces

      Description


      ICEfaces 2.0 compat/auctionMonitor does not render correctly and it is not interactive.
      1. table-element-update_ie-fix.patch
        2 kB
        Mircea Toma
      2. table-element-update.improved.patch
        2 kB
        Mircea Toma
      3. table-element-update.patch
        0.8 kB
        Mircea Toma

        Issue Links

          Activity

          Hide
          Ted Goddard added a comment -

          compat/auctionMonitor starts working for me if I make a change like the following:

          Index: compat/components/src/main/resources/META-INF/resources/icesubmit.js
          ===================================================================
          — compat/components/src/main/resources/META-INF/resources/icesubmit.js (revision 19044)
          +++ compat/components/src/main/resources/META-INF/resources/icesubmit.js (working copy)
          @@ -14,7 +14,7 @@
          return false;
          }
          }

          • ice.submitForm(evt, form || formOf(component));
            + ice.submitEvent(evt, component, form || formOf(component));
            return false;
            }

          Mircea, perhaps you have a local change of this nature that is not checked in? commandButton does not work if it is not the "component" submitting the form (the current code submits the form anonymously).

          Show
          Ted Goddard added a comment - compat/auctionMonitor starts working for me if I make a change like the following: Index: compat/components/src/main/resources/META-INF/resources/icesubmit.js =================================================================== — compat/components/src/main/resources/META-INF/resources/icesubmit.js (revision 19044) +++ compat/components/src/main/resources/META-INF/resources/icesubmit.js (working copy) @@ -14,7 +14,7 @@ return false; } } ice.submitForm(evt, form || formOf(component)); + ice.submitEvent(evt, component, form || formOf(component)); return false; } Mircea, perhaps you have a local change of this nature that is not checked in? commandButton does not work if it is not the "component" submitting the form (the current code submits the form anonymously).
          Hide
          Mircea Toma added a comment -

          You're right I missed to commit icesubmit.js changes. The fix is committed now.

          Show
          Mircea Toma added a comment - You're right I missed to commit icesubmit.js changes. The fix is committed now.
          Hide
          Mircea Toma added a comment -

          > Which browsers?

          Firefox, for sure.

          > Let's refine the patch a bit before we send it to Sun again – they've already applied the
          > previous one. For instance, perhaps we can factor out parent.replaceChild().

          The patch is almost similar with what we have in Trunk. With the first patch I completely forgot about the fact that browser are inserting intermediate elements. When I went back to Trunk code I remembered why I had to do the "while" loop.

          Show
          Mircea Toma added a comment - > Which browsers? Firefox, for sure. > Let's refine the patch a bit before we send it to Sun again – they've already applied the > previous one. For instance, perhaps we can factor out parent.replaceChild(). The patch is almost similar with what we have in Trunk. With the first patch I completely forgot about the fact that browser are inserting intermediate elements. When I went back to Trunk code I remembered why I had to do the "while" loop.
          Hide
          Mircea Toma added a comment -

          OutOfMemoryError is gone since the state saving was fixed. See https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1142 .

          Show
          Mircea Toma added a comment - OutOfMemoryError is gone since the state saving was fixed. See https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1142 .
          Hide
          Mircea Toma added a comment -

          Fix table element update in IE. IE creates the "table" element only if "table" tag is part of the innerHTML markup. Also reverted the search in the array of table element names, native arrays are not indexed by cell values. See patch file: table-element-update_ie-fix.patch

          Show
          Mircea Toma added a comment - Fix table element update in IE. IE creates the "table" element only if "table" tag is part of the innerHTML markup. Also reverted the search in the array of table element names, native arrays are not indexed by cell values. See patch file: table-element-update_ie-fix.patch

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Ted Goddard
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: