ICEfaces
  1. ICEfaces
  2. ICE-4586

domDiffing algorithm confused with identical documents

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: None
          • Labels:
            None
          • Environment:
            ICEfaces 2.0

            Description

            The domDiff method in DOMUtils returned a NULL value if the document arguments refer to identical documents. This can happen quite legitimately and is difficult to distinguish between the case where one of the documents actually is null.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18964 Thu Jun 11 10:07:00 MDT 2009 greg.dick ICE-4586 changed test code to reflect new behaviour in DOMUtils
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/test/java/org/icefaces/domDiff/DomDiffTest.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18963 Wed Jun 10 16:12:28 MDT 2009 greg.dick ICE-4586 fixed log message error
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18962 Wed Jun 10 16:11:45 MDT 2009 greg.dick ICE-4586 return an empty array of diffs if the documents are identical
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/util/DOMUtils.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18961 Wed Jun 10 16:11:10 MDT 2009 greg.dick ICE-4586 log a warning if one of the documents is null, and don't execute the domDiff method if so.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: