ICEfaces
  1. ICEfaces
  2. ICE-4586

domDiffing algorithm confused with identical documents

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: None
          • Labels:
            None
          • Environment:
            ICEfaces 2.0

            Description

            The domDiff method in DOMUtils returned a NULL value if the document arguments refer to identical documents. This can happen quite legitimately and is difficult to distinguish between the case where one of the documents actually is null.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18961 Wed Jun 10 16:11:10 MDT 2009 greg.dick ICE-4586 log a warning if one of the documents is null, and don't execute the domDiff method if so.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18962 Wed Jun 10 16:11:45 MDT 2009 greg.dick ICE-4586 return an empty array of diffs if the documents are identical
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/util/DOMUtils.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18963 Wed Jun 10 16:12:28 MDT 2009 greg.dick ICE-4586 fixed log message error
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
              Greg Dick created issue -
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18964 Thu Jun 11 10:07:00 MDT 2009 greg.dick ICE-4586 changed test code to reflect new behaviour in DOMUtils
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/test/java/org/icefaces/domDiff/DomDiffTest.java
              Hide
              Permalink
              Ken Fyten added a comment -

              Not sure if this is still relevant?

              Show
              Ken Fyten added a comment - Not sure if this is still relevant?
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Alpha3 [ 10032 ]
              Assignee Priority P2
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Hide
              Permalink
              Greg Dick added a comment -

              The fix from 1.8 has made it to 2.0. Closing this issue

              Show
              Greg Dick added a comment - The fix from 1.8 has made it to 2.0. Closing this issue
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: