ICEfaces
  1. ICEfaces
  2. ICE-4246

submitOnUpload="postUpload" does not work in FF 3.0.7 with 1.7-branch

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.2 SP1
    • Fix Version/s: 1.7.2-SP2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      FF 3.0.7

      Description

      In IE7, clicking upload (with submitOnUpload="postUpload") succesfully updates a dataTable that keeps a list of uploaded files. On FF3, you need to click upload and then the submit button in order to see the updated table.

        Activity

        Hide
        Adnan Durrani added a comment -

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18639

        Show
        Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18639
        Hide
        Adnan Durrani added a comment -

        Fix to the trunk modified so the change can apply to FF 3.0.7 only
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18643

        Fix backported to 1.7 branch.

        Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18644

        Show
        Adnan Durrani added a comment - Fix to the trunk modified so the change can apply to FF 3.0.7 only Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18643 Fix backported to 1.7 branch. Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18644
        Hide
        Adnan Durrani added a comment -

        Event based fixed added (patch from Mircea)
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18648

        branch 1.7
        Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18649

        Show
        Adnan Durrani added a comment - Event based fixed added (patch from Mircea) Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18648 branch 1.7 Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18649
        Hide
        Tyler Johnson added a comment -

        Customer has reported that the issue in indeed fixed in firefox (3.0.7). However, they still the issue in Opera as well as in older version of firefox (3.0.3). Looking at the change, this mod is specific to Firefox 3.07:

        "if (navigator.userAgent.indexOf('Firefox/3.0.7')> 0) setTimeout(register, 400); else setTimeout(register, 0);", null);

        Can we create a more general case?

        Show
        Tyler Johnson added a comment - Customer has reported that the issue in indeed fixed in firefox (3.0.7). However, they still the issue in Opera as well as in older version of firefox (3.0.3). Looking at the change, this mod is specific to Firefox 3.07: "if (navigator.userAgent.indexOf('Firefox/3.0.7')> 0) setTimeout(register, 400); else setTimeout(register, 0);", null); Can we create a more general case?
        Hide
        Adnan Durrani added a comment -

        Tyler, on 25th Mar we committed event based fixed which should work with all browsers. Can you please retest it.

        Show
        Adnan Durrani added a comment - Tyler, on 25th Mar we committed event based fixed which should work with all browsers. Can you please retest it.
        Hide
        Tyler Johnson added a comment -

        Still not fixed in Opera.

        Ty

        Show
        Tyler Johnson added a comment - Still not fixed in Opera. Ty
        Hide
        Adnan Durrani added a comment -

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18671

        Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Completed: At revision: 18673

        Show
        Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18671 Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\branches\icefaces-1.7\icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java Completed: At revision: 18673
        Hide
        Adnan Durrani added a comment -

        Tyler, can you please retest the app?

        Show
        Adnan Durrani added a comment - Tyler, can you please retest the app?
        Hide
        Tyler Johnson added a comment -

        Comment from customer:

        So, the results are mostly positive. I am now able to upload files in all of the 4 browsers we've tested. I did notice one thing that is less critical, but would still be nice if it was working correctly.

        When I go to the page in Safari 3 on the mac, I upload a file. I then hit reload (this was part of the test, since previously the problem seemed intermittent). What happens is that the iframe comes up with HTTP Server error 500:

        [#|2009-03-27T11:29:41.659-0400|SEVERE|sun-appserver2.1|javax.enterprise.system.container.web|_ThreadID=19;_ThreadName=httpSSLWorkerThread-8080-0;_RequestID=f625b5ab-1e6a-4958-9790-30cbf919c12d;|StandardWrapperValve[uploadServlet]: PWC1406: Servlet.service() for servlet uploadServlet threw exception
        org.apache.commons.fileupload.FileUploadBase$InvalidContentTypeException: the request doesn't contain a multipart/form-data or multipart/mixed stream, content type header is null
        at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.<init>(FileUploadBase.java:862)
        at org.apache.commons.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:325)
        at org.apache.commons.fileupload.servlet.ServletFileUpload.getItemIterator(ServletFileUpload.java:148)
        at com.icesoft.faces.webapp.http.core.UploadServer$2.servlet(UploadServer.java:53)
        at com.icesoft.faces.webapp.http.servlet.ServletRequestResponse.detectEnvironment(ServletRequestResponse.java:228)
        at com.icesoft.faces.webapp.http.core.UploadServer.service(UploadServer.java:50)
        at com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer.service(PathDispatcherServer.java:24)
        at com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet.service(MainSessionBoundServlet.java:160)
        at com.icesoft.faces.webapp.http.servlet.SessionDispatcher$1.service(SessionDispatcher.java:38)
        at com.icesoft.faces.webapp.http.servlet.GlassFishAdaptingServlet.service(GlassFishAdaptingServlet.java:60)
        at

        I tried this while reloading the page when coming to it fresh (before uploading a file) and it also happened. When we did the same test on Safari 4 on Windows, this did not happen. Still waiting to test on Safari 3 for Windows (or 4 for Mac, for that matter).

        Show
        Tyler Johnson added a comment - Comment from customer: So, the results are mostly positive. I am now able to upload files in all of the 4 browsers we've tested. I did notice one thing that is less critical, but would still be nice if it was working correctly. When I go to the page in Safari 3 on the mac, I upload a file. I then hit reload (this was part of the test, since previously the problem seemed intermittent). What happens is that the iframe comes up with HTTP Server error 500: [#|2009-03-27T11:29:41.659-0400|SEVERE|sun-appserver2.1|javax.enterprise.system.container.web|_ThreadID=19;_ThreadName=httpSSLWorkerThread-8080-0;_RequestID=f625b5ab-1e6a-4958-9790-30cbf919c12d;|StandardWrapperValve [uploadServlet] : PWC1406: Servlet.service() for servlet uploadServlet threw exception org.apache.commons.fileupload.FileUploadBase$InvalidContentTypeException: the request doesn't contain a multipart/form-data or multipart/mixed stream, content type header is null at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.<init>(FileUploadBase.java:862) at org.apache.commons.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:325) at org.apache.commons.fileupload.servlet.ServletFileUpload.getItemIterator(ServletFileUpload.java:148) at com.icesoft.faces.webapp.http.core.UploadServer$2.servlet(UploadServer.java:53) at com.icesoft.faces.webapp.http.servlet.ServletRequestResponse.detectEnvironment(ServletRequestResponse.java:228) at com.icesoft.faces.webapp.http.core.UploadServer.service(UploadServer.java:50) at com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer.service(PathDispatcherServer.java:24) at com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet.service(MainSessionBoundServlet.java:160) at com.icesoft.faces.webapp.http.servlet.SessionDispatcher$1.service(SessionDispatcher.java:38) at com.icesoft.faces.webapp.http.servlet.GlassFishAdaptingServlet.service(GlassFishAdaptingServlet.java:60) at I tried this while reloading the page when coming to it fresh (before uploading a file) and it also happened. When we did the same test on Safari 4 on Windows, this did not happen. Still waiting to test on Safari 3 for Windows (or 4 for Mac, for that matter).
        Hide
        Joanne Bai added a comment -

        Test environment: 1.7.2-SP2 build 3 + Tomcat 6 on Win XP

        • Tested with success on FF3.0.8, Safari 3.1, IE8
        • Not working on Opera
        Show
        Joanne Bai added a comment - Test environment: 1.7.2-SP2 build 3 + Tomcat 6 on Win XP Tested with success on FF3.0.8, Safari 3.1, IE8 Not working on Opera
        Hide
        Vladimir Putin added a comment - - edited

        Still not fixed in Firefox 3.0.8. submitOnUpload="preAndPostUpload" has no effect ("postUpload" is OK). ICEFaces 1.8.0, Glassfish 2.1, (ICEFaces asynchronous mode is off).

        in Chrome 1.0 any value of submitOnUpload has no effect

        Show
        Vladimir Putin added a comment - - edited Still not fixed in Firefox 3.0.8. submitOnUpload="preAndPostUpload" has no effect ("postUpload" is OK). ICEFaces 1.8.0, Glassfish 2.1, (ICEFaces asynchronous mode is off). in Chrome 1.0 any value of submitOnUpload has no effect

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: