ICEfaces
  1. ICEfaces
  2. ICE-4221

Vertical menuitem alignment off in IE7 and Rime theme

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8RC2
    • Fix Version/s: 1.8RC2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      IE7, Rime theme only

      Description

      The menubar demo in component showcase shows that the vertical alignment of menuitem label in IE7 is off, labels are too high and not centered. This only affect the Rime theme and IE7 (IE6 not tested). Firefox is fine.
      1. IE6.JPG
        12 kB
      2. IE7.JPG
        13 kB
      3. Picture 3.png
        10 kB
      4. ScreenHunter_01 Mar. 19 11.13.jpg
        168 kB

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P3
        Assignee Yip Ng [ yip.ng ]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Ken Fyten added a comment -

        See screenshot attached.

        Show
        Ken Fyten added a comment - See screenshot attached.
        Ken Fyten made changes -
        Attachment Picture 3.png [ 11592 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18607 Wed Mar 18 15:36:10 MDT 2009 yip.ng ICE-4221
        Fixed alignment problems in menu items.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.8RC2 [ 10163 ]
        Fix Version/s 1.8 [ 10161 ]
        Resolution Fixed [ 1 ]
        Hide
        Joanne Bai added a comment -

        On 1.8.0-RC2 build 5, the menuitem alignment problem is fixed for IE7, but still presents on IE6. Please see the pics attached.

        Show
        Joanne Bai added a comment - On 1.8.0-RC2 build 5, the menuitem alignment problem is fixed for IE7, but still presents on IE6. Please see the pics attached.
        Joanne Bai made changes -
        Attachment IE6.JPG [ 11603 ]
        Attachment IE7.JPG [ 11604 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Priority P3 P2
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8 [ 10161 ]
        Fix Version/s 1.8RC2 [ 10163 ]
        yip.ng made changes -
        Attachment ScreenHunter_01 Mar. 19 11.13.jpg [ 11605 ]
        Hide
        yip.ng added a comment -

        If you compare the before and after screenshots of IE6, you will see that IE6 already looks much better after the fix. The slight difference between IE6 and IE7 is probably due to inconsistent interpretations of center vertical alignment. (Our use of float, and what's worse, float within an anchor tag, may also be a cause.) In the word "Copy", the letters "p" and "y" extend below the text baseline. If you take the letter extensions into consideration, then the word is actually better centered than first appears.

        I can try other tweaks, but I don't think you can make IE6 look exactly the same as IE7 with the current layout. Further, I don't think you can make IE6 look better without making Firefox look worse.

        Show
        yip.ng added a comment - If you compare the before and after screenshots of IE6, you will see that IE6 already looks much better after the fix. The slight difference between IE6 and IE7 is probably due to inconsistent interpretations of center vertical alignment. (Our use of float, and what's worse, float within an anchor tag, may also be a cause.) In the word "Copy", the letters "p" and "y" extend below the text baseline. If you take the letter extensions into consideration, then the word is actually better centered than first appears. I can try other tweaks, but I don't think you can make IE6 look exactly the same as IE7 with the current layout. Further, I don't think you can make IE6 look better without making Firefox look worse.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s 1.8RC2 [ 10163 ]
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P2
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: