ICEfaces
  1. ICEfaces
  2. ICE-4156

SelectInputDate is incorrectly initialized

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8RC1
          • Fix Version/s: 1.8RC2, 1.8
          • Component/s: None
          • Labels:
            None
          • Environment:
            Icefaces RC! rev.18438
          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            public void validate(FacesContext context) {
            (..)
                            if (isShowPopup()) setSubmittedValue(null); // if popup was closed, process submitted value
            > else setPopupDate(null);
            (...)
            }
            Show
            public void validate(FacesContext context) { (..)                 if (isShowPopup()) setSubmittedValue(null); // if popup was closed, process submitted value > else setPopupDate(null); (...) }

            Description

            Scenario:
            - datatable with popup editor opened on selected row
            - popup contain selectInpudDate field
            - open popup on first row, select date, close popup
            - open popup on another row, you see date from previous row

            Bug is in SelectInpuDate.java. Popup date shold be cleared on date popup close
            Patch can be included in validate method.


              Activity

              Ascending order - Click to sort in descending order
              Krashan Brahmanjara created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P1
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Summary Select inpud date is incorrectly initialized SelectInputDate is incorrectly initialized
              Salesforce Case []
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18506 Mon Mar 09 18:12:01 MDT 2009 mark.collette ICE-4156 : SelectInputDate is incorrectly initialized
              ICE-4184 : Setting selectInputDate value in dataTable issue
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
              Hide
              Permalink
              Mark Collette added a comment -

              I investigated various means of limiting the duration we maintain the popupDate field, but it ended up being more straightforward to fix this with ICE-4184, of instead better saving popupDate, rather than trying to discard it.

              Subversion 18506
              icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java

              Show
              Mark Collette added a comment - I investigated various means of limiting the duration we maintain the popupDate field, but it ended up being more straightforward to fix this with ICE-4184 , of instead better saving popupDate, rather than trying to discard it. Subversion 18506 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              1) Open popup calendar for any row that doesnot have a date in it
              2) Make sure no date is highlighted in the calendar and the time selected is current time
              3) Select a date and time & close the calendar
              4) The selected date should be displayed in the date input box

              The test is failing because condition (4) is not being met.

              Show
              Mandeep Hayher added a comment - 1) Open popup calendar for any row that doesnot have a date in it 2) Make sure no date is highlighted in the calendar and the time selected is current time 3) Select a date and time & close the calendar 4) The selected date should be displayed in the date input box The test is failing because condition (4) is not being met.
              Mandeep Hayher made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Security Private [ 10001 ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Test application available at '\repo\qa\trunk\Regression\ICE-4156'.

              Show
              Mandeep Hayher added a comment - Test application available at '\repo\qa\trunk\Regression\ ICE-4156 '.
              Ken Fyten made changes -
              Salesforce Case []
              Security Private [ 10001 ]
              Hide
              Permalink
              Krashan Brahmanjara added a comment -

              Last changes from Mark does'nt help in sequence described at beginning.

              If user change row data calendar must be reinitialized not restored.

              At current moment workaround with setPopupDate(null); onClose is better.

              Show
              Krashan Brahmanjara added a comment - Last changes from Mark does'nt help in sequence described at beginning. If user change row data calendar must be reinitialized not restored. At current moment workaround with setPopupDate(null); onClose is better.
              Hide
              Permalink
              Mark Collette added a comment -

              I tried using setPopup(null), as you described, and the component did not function properly. And irrespective of the symptoms you're interested in, the state has to be saved, per row, for the component to work properly. The real fix should be finshed soon.

              Show
              Mark Collette added a comment - I tried using setPopup(null), as you described, and the component did not function properly. And irrespective of the symptoms you're interested in, the state has to be saved, per row, for the component to work properly. The real fix should be finshed soon.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18562 Fri Mar 13 15:27:13 MDT 2009 mark.collette ICE-4156 : SelectInputDate is incorrectly initialized
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
              Ken Fyten made changes -
              Fix Version/s 1.8RC2 [ 10163 ]
              Fix Version/s 1.8 [ 10161 ]
              Hide
              Permalink
              Mark Collette added a comment -

              Better delineated the value from the popupDate.

              Subversion 18562
              icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
              icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java

              Show
              Mark Collette added a comment - Better delineated the value from the popupDate. Subversion 18562 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
              Mark Collette made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Joanne Bai added a comment -

              QA verified it on 1.8.0 RC2 build 1 (tomcat6 + FF2 and IE6 and Opera9.27)

              It works fine except that on IE6, the selected drop-down list (month, year, time, AM/PM) items all flicker when there's a click/select on items of the popup calendar.

              For the test code, there was some issue of directly using a List or Dates, which was resolved when Mark suggested to use a List of Objects that refer to Dates

              Show
              Joanne Bai added a comment - QA verified it on 1.8.0 RC2 build 1 (tomcat6 + FF2 and IE6 and Opera9.27) It works fine except that on IE6, the selected drop-down list (month, year, time, AM/PM) items all flicker when there's a click/select on items of the popup calendar. For the test code, there was some issue of directly using a List or Dates, which was resolved when Mark suggested to use a List of Objects that refer to Dates
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P1
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Krashan Brahmanjara
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: