Another bug of ice:radio.

In above sequence of ice:selectOneRadio / f:selectItems / ice:radio spread radios are generated correctly only for regular list of values stared with 0 like 0,1,2,3....

Other sequances are rendered incorrectly, like 1,2,3,4 - some labels and values are multiplicated.

One more bug for this example.

Readonly attribute are not apllied to rendered radios.

Workaround patch for RadioRendered.java rev.18438

protected void renderOption{
(...)
row 195

Element input = domContext.createElement(HTML.INPUT_ELEM);
input.setAttribute(HTML.TYPE_ATTR, HTML.INPUT_TYPE_RADIO);
input.setAttribute(HTML.ID_ATTR, radioClientId);
input.setAttribute(HTML.NAME_ATTR, selectOneClientId);
input.setAttribute(HTML.VALUE_ATTR, selectItemValue);

< if (selectItem.isDisabled()) {
> Boolean readonly = (Boolean) selectOne.getAttributes().get(HTML.READONLY_ATTR);
> if (readonly != null && readonly.booleanValue())

> Boolean disabled = (Boolean) selectOne.getAttributes().get(HTML.DISABLED_ATTR);
> if (selectItem.isDisabled() || (disabled != null && disabled.booleanValue()))

if (isValueSelected(facesContext, selectItem, selectOne,
submittedValue, componentValue))

}

We don't use the "enabledClass" and "disabledClass". We use "styleClass" and "disabled". But even then there were some bugs. These have now been fixed. The markup would look like this:

<ice:selectOneRadio ... layout="spread" styleClass="rbStyle" disabled="true" ...>

The output would look like this:

<input type="radio" ... disabled="disabled"/>
<label for="..." class="iceSelOneRb-dis rbStyle-dis">...</label>

Labels can be disabled by setting the select item's label to null or empty string, e.g.:

SelectItem item = new SelectItem("sprite", "");

See attached screenshot.

The list of selectItems is zero-based, and there is range checking to prevent out-of-bounds errors. Out-of-range indexes are reset to the first or last index:

if (radioIndex < 0) radioIndex = 0;
if (radioIndex >= selectItemList.size()) radioIndex = selectItemList.size() - 1;

So, as can be seen from the attached screenshot, index 4 is reset to index 3, resulting in the last 2 items looking duplicated.

It is the user's responsibility to make sure that the select item indexes are not out of range.

Readonly attribute is working now. See attached screenshot. Fixed by changing the call to the PassThruAttributeRenderer. No need for the patch.

"We don't use the "enabledClass" and "disabledClass"."

Current revision 18478. In tld users still see "enabledClass" and "disabledClass".

New JIRA created: ICE-4187.

I see a label generation bug after last changes .

The same scenario described at beggining. Now radio's are generated with correct value and incorrect labels.
Example for one item (value=32 but label is from third item)

<input id="UE:icePnlTbSet:0:woi13:_4" type="radio" value="32" onkeypress="Ice.util.radioCheckboxEnter(form,this,event);" onfocus="setFocus(this.id);" onblur="setFocus('');" name="UE:icePnlTbSet:0:woi13" disabled="disabled"/>
<label class="iceSelOneRb-dis" for="UE:icePnlTbSet:0:woi13:_4">DEM</label>

BTW
Styles are now applied but only to label element, not to input.

Value is a key, not an index. It could be a string, not a number. It is matched to the select item with the same value, not the same index. The index is used solely for layout purposes.

For applying the style to input, see ICE-4187.