Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.8DR#2
-
Component/s: ICE-Components
-
Labels:None
-
Environment:java
Description
for instance in UISeries:
else if (currentValue instanceof Map) {
this.dataModel = new SetDataModel(((Map) currentValue).entrySet());
else if (currentValue instanceof Map) {
this.dataModel = new SetDataModel(((Map) currentValue).entrySet());
Activity
Keith Garry Boyce
created issue -
Tyler Johnson
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [50070000007ybzm] |
Ken Fyten
made changes -
Fix Version/s | 1.8 [ 10161 ] | |
Assignee Priority | P2 | |
Assignee | Mark Collette [ mark.collette ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #18418 | Tue Feb 24 12:00:29 MST 2009 | mark.collette | |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java
|
Mark Collette
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 1.8RC2 [ 10163 ] | |
Fix Version/s | 1.8 [ 10161 ] |
Ken Fyten
made changes -
Fix Version/s | 1.8 [ 10161 ] | |
Assignee Priority | P2 |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee | Mark Collette [ mark.collette ] |
We shouldn't support Map or Set, because they don't have orderings, which could cause problems for users, when any modification can drastically affect the subsequent iteration, or in the case of LinkedHashMap no modification would be necessary. What that means is, the data model will render in one sequence, and then a post-back could apply input values to any element of the Set or Map, instantly corrupting the data model.
I'm not sure why
ICE-2755added support for Set, given these concerns. Perhaps this would be useful for SortedMap and SortedSet? Or just when used with output components.I'm just worried that new users will see their code "work" and be caught unawares with these issues, whereas if it failed immediately, they would then find out about this issue, and know to use a more appropriate data structure.