Details
-
Type: New Feature
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.8RC1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:JSF Mojarra 1.2_05 and up
Description
This is a subset of ICE-3729, where we can make the h: components' pass-through attribute rendering take advantage of the attributesThatAreSet optimisation in JSF RI 1.2_05+.
Issue Links
- blocks
-
ICE-3729 Components use attributesThatAreSet
- Closed
Activity
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #18311 | Mon Feb 09 14:54:37 MST 2009 | mark.collette | |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeWriter.java
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ImplementationUtil.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/effects/LocalEffectEncoder.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/DomBasicRenderer.java |
Mark Collette
created issue -
Mark Collette
made changes -
Mark Collette
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Fix Version/s | 1.8RC1 [ 10143 ] | |
Resolution | Fixed [ 1 ] | |
Assignee | Mark Collette [ mark.collette ] |
Ken Fyten
made changes -
Fix Version/s | 1.8 [ 10161 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee | Mark Collette [ mark.collette ] |
It was a pretty centralised change to the PassThruAttributeRenderer and PassThruAttributeWriter to support the attributesThatAreSet feature for h: components. And even though effects don't exist for h: components, LocalEffectEncoder was also updated to use the attributesThatAreSet List, for completeness.
Basically, attributesThatAreSet is a List in UIComponent, accessible from UIComponentBase.getAttributes.get("javax.faces.component.UIComponentBase.attributesThatAreSet"), which is a List of all set attributes. This way, we don't have to iterate over all possible pass-through attributes, or effect attributes, for a component, but can instead iterate over the set attributes which are relevant to pass-through or effect rendering. Unfortunately, this feature only exists for stock components, and not third party components, even if they extend stock ones.
Subversion 18311
icefaces\core\src\com\icesoft\faces\context\effects\LocalEffectEncoder.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\DomBasicRenderer.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeWriter.java
icefaces\core\src\com\icesoft\faces\webapp\parser\ImplementationUtil.java