ICEfaces
  1. ICEfaces
  2. ICE-3984

compressDOM TextArea may be null

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#2
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces, compressDOM=true

      Description


      component-showcase throws a NullPointerException in applyBrowserDOMChanges() when DOM compression is used.

        Activity

        Ted Goddard created issue -
        Ted Goddard made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8DR#3 [ 10143 ]
        Hide
        Ted Goddard added a comment -

        There are several sources of "non-normalized" DOM values:

        • text nodes with empty strings may be appended to the DOM (DOMResponseWriter can skip these)
        • the ConnectionStatus component may append an empty string as a label
        • the state saving marker is encoded as a series of text nodes
        • Facelets appears to pass CDATA sections through to the component when XML parsing of the input would dictate direct conversion to character data
        Show
        Ted Goddard added a comment - There are several sources of "non-normalized" DOM values: text nodes with empty strings may be appended to the DOM (DOMResponseWriter can skip these) the ConnectionStatus component may append an empty string as a label the state saving marker is encoded as a series of text nodes Facelets appears to pass CDATA sections through to the component when XML parsing of the input would dictate direct conversion to character data
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18206 Thu Jan 22 09:43:02 MST 2009 ted.goddard ensure DOM is initially normalized for compressDOM (ICE-3984)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18210 Thu Jan 22 11:03:37 MST 2009 ted.goddard ensure DOM is initially normalized for compressDOM (ICE-3984)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
        Hide
        Ted Goddard added a comment -

        fix checked in for applyBrowserDOMChanges()

        Show
        Ted Goddard added a comment - fix checked in for applyBrowserDOMChanges()
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mandeep Hayher added a comment -

        Tested successfully on ICEFaces1.8RC1 build2, jsp component-showcase & Tomcat5 server using following steps:
        1) Set compressDOM to true in web.xml
        2) Text input components should behave normally for test to be considered as pass

        Show
        Mandeep Hayher added a comment - Tested successfully on ICEFaces1.8RC1 build2, jsp component-showcase & Tomcat5 server using following steps: 1) Set compressDOM to true in web.xml 2) Text input components should behave normally for test to be considered as pass
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: