ICEfaces
  1. ICEfaces
  2. ICE-3977

Preselection of radio or checkbox with layout=spread not working

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2, 1.7.2 SP1, 1.8DR#1, 1.8DR#2
          • Fix Version/s: 1.7.2-SP2, 1.8RC1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When pre-selecting a value for ice:radio or ice:checkbox is not working with 1.7.2 SP1. It was working with ICEfaces 1.7.1

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [50070000007bKwp]
              Arran Mccullough made changes -
              Attachment main.jspx [ 11451 ]
              Attachment TestBean.java [ 11452 ]
              Sam Xiao made changes -
              Salesforce Case [50070000007bKwp] [50070000007bKwp, 50070000007bgKY]
              Sam Xiao made changes -
              Salesforce Case [50070000007bKwp, 50070000007bgKY] [50070000007bKwp, 50070000007b20Z]
              Ken Fyten made changes -
              Assignee Priority P1
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Fix Version/s 1.8DR#3 [ 10143 ]
              Ken Fyten made changes -
              Fix Version/s 1.7.3 [ 10162 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18262 Fri Jan 30 11:51:13 MST 2009 mark.collette ICE-3977 : Preselection of radio or checkbox with layout=spread not working
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18263 Fri Jan 30 11:51:36 MST 2009 mark.collette ICE-3977 : Preselection of radio or checkbox with layout=spread not working
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Hide
              Permalink
              Mark Collette added a comment -

              The checkbox rendering code was incorrectly getting the component selection value from the checkbox, when it should have gotten it from the UISelectMany referenced by the for attribute.

              Subversion 18262
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java

              Subversion 18263
              icefaces17\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java

              Show
              Mark Collette added a comment - The checkbox rendering code was incorrectly getting the component selection value from the checkbox, when it should have gotten it from the UISelectMany referenced by the for attribute. Subversion 18262 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java Subversion 18263 icefaces17\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Sam Xiao added a comment -

              checkbox now works but problem still exists from radio button

              Show
              Sam Xiao added a comment - checkbox now works but problem still exists from radio button
              Sam Xiao made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Sam Xiao made changes -
              Attachment ICE-3977.war [ 11492 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18275 Mon Feb 02 15:01:58 MST 2009 mark.collette ICE-3977 : Preselection of radio or checkbox with layout=spread not working
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18276 Mon Feb 02 15:03:38 MST 2009 mark.collette ICE-3977 : Preselection of radio or checkbox with layout=spread not working
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Hide
              Permalink
              Mark Collette added a comment -

              Included the radio components in the fix, and noticed an oversight in the checkbox fix as well.

              TRUNK
              Subversion 18275
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java

              ICEfaces 1.7 Branch
              Subversion 18276
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java

              Show
              Mark Collette added a comment - Included the radio components in the fix, and noticed an oversight in the checkbox fix as well. TRUNK Subversion 18275 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java ICEfaces 1.7 Branch Subversion 18276 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
              Mark Collette made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Werner Mueller made changes -
              Link This issue is duplicated by ICE-3646 [ ICE-3646 ]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P1
              Mark Collette made changes -
              Link This issue is duplicated by ICE-3646 [ ICE-3646 ]
              Hide
              Permalink
              Joanne Bai added a comment -

              verified with success on 1.7.2-SP2 build 3 (tested on tomcat6 + FF2 and IE6)

              Show
              Joanne Bai added a comment - verified with success on 1.7.2-SP2 build 3 (tested on tomcat6 + FF2 and IE6)
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Arran Mccullough
                • Votes:
                  4 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: