Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.7.2, 1.8.1
-
Component/s: None
-
Labels:None
-
Environment:XP SP3, FF3
-
Workaround Exists:Yes
-
Workaround Description:HideWorkaround for me, patch the TableRenderer by replacing
if (isScrollable(uiComponent) &&
columnWitdths != null &&
columnWitdths.hasMoreTokens()) {
width = columnWitdths.nextToken();
}
with:
if (columnWitdths != null &&
columnWitdths.hasMoreTokens()) {
width = columnWitdths.nextToken();
}ShowWorkaround for me, patch the TableRenderer by replacing if (isScrollable(uiComponent) && columnWitdths != null && columnWitdths.hasMoreTokens()) { width = columnWitdths.nextToken(); } with: if (columnWitdths != null && columnWitdths.hasMoreTokens()) { width = columnWitdths.nextToken(); }
Description
String width = "150px;";
if (isScrollable(uiComponent) &&
columnWitdths != null &&
columnWitdths.hasMoreTokens()) {
width = columnWitdths.nextToken();
}
-
- 3943-TableRenderer-UIColumns.patch
- 4 kB
- Ed Hillmann
-
Hide
- Case8549Example.war
- 5.37 MB
- Arran Mccullough
-
- META-INF/MANIFEST.MF 0.1 kB
- META-INF/context.xml 0.1 kB
- WEB-INF/classes/com/.../example/Item.class 0.8 kB
- WEB-INF/classes/.../example/TestBean.class 2 kB
- WEB-INF/faces-config.xml 0.5 kB
- WEB-INF/lib/FastInfoset.jar 285 kB
- WEB-INF/lib/backport-util-concurrent.jar 343 kB
- WEB-INF/lib/commons-beanutils.jar 113 kB
- WEB-INF/lib/commons-collections.jar 162 kB
- WEB-INF/lib/commons-digester.jar 104 kB
- WEB-INF/lib/commons-fileupload.jar 56 kB
- WEB-INF/lib/commons-logging.jar 30 kB
- WEB-INF/lib/icefaces-comps.jar 1.93 MB
- WEB-INF/lib/icefaces.jar 1.06 MB
- WEB-INF/lib/jsf-api.jar 350 kB
- WEB-INF/lib/jsf-impl.jar 816 kB
- WEB-INF/lib/jstl.jar 20 kB
- WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB
- WEB-INF/web.xml 3 kB
- index.jsp 0.1 kB
- main.jspx 2 kB
Issue Links
- blocks
-
ICE-4979 ArrayIndexOutOfBoundsException from TableRenderer.getWidthFromColumnWidthsArray
- Closed
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
with the <ice:column> there is no problem, but with the <ice:columns>
I've found a new problem, because i was using before always the same width for my columns.
My list of columns widths looks like this:
<ice:dataTable
columnWidths="30px,50px,100px" ...
Using the <ice:columns> tag only the first defined width is apllied on all my columns:
<tr>
<th style="width: 30px;" />
<th style="width: 30px;" />
<th style="width: 30px;" />
</tr>
Attached test case that shows the columnWidths not being applies properly to a table using <ice:columns/> component. Also has a table that uses the <ice:column/> component and it is working properly.
Hi. I've attached a patch that allows the columnWidths attribute to be applied to a table that uses a UIColumns component (as opposed to defining individual UIColumn components). This works in my environment, as it also works for the attached example WAR file. The changes are contained within the file component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java. I've made this against the 1.8.1 version of the ICEfaces source.
Fix added so the "width" will be apply on each column defined to the "columnWidths" attribute, regardless of the any combination of column and columns component.
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Completed: At revision: 19203
Verified with success on ICEfaces trunk revision 19228 + tomcat6.0
Tested on FF3.5, IE6 and IE7
Test app committed to repo\qa\trunk\Regression\ICE-3943
The change for this issue is causing the following regression test failures using IE7 and FF2:
ICE-3136: failed on IE and FF (works fine on Opera) - column.rendered is not interpreted inside a headerRow element
ICE-3057: failed - columns are not resizable when resize: true clientOnly: false
ICE-2371: failed on IE and FF (works fine on Opera) - things wrong with the column headers
ICE-2234: failed on IE and FF (works fine on Opera) - things wrong with the column headers
More details on the regression failures:
ICE-3136: failed on IE and FF (works fine on Opera) - column.rendered is not interpreted inside a headerRow element
ICE-3057: failed - columns are not resizable when resize: true clientOnly: false
ICE-2371: failed on IE and FF (works fine on Opera) - things wrong with the column headers
ICE-2234: failed on IE and FF (works fine on Opera) - things wrong with the column headers
They seem all column headers related. The column header row disappears when multiple clicks apply to it. It affects column resizable and sortable on IE and FF. Opera is fine.
Backed out original changes for now. Need more time to debug. (There were 48 differences in the diff.)
Re-instated original changes for this issue. The actual cause of regression was related to changes made for ICE-4916.
I don't see any problems. Use numer of columntWitdth's equal to number of columns.