[ICE-3943] columnWidths not applied on ice:columns - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7.2, 1.8.1
Fix Version/s: 1.8.2-RC1, 1.8.2
Component/s: None
Labels:
None
Environment:
XP SP3, FF3

Workaround Exists:

Yes
Workaround Description:

Hide
Workaround for me, patch the TableRenderer by replacing

if (isScrollable(uiComponent) &&
   columnWitdths != null &&
   columnWitdths.hasMoreTokens()) {
   width = columnWitdths.nextToken();
}

with:

if (columnWitdths != null &&
   columnWitdths.hasMoreTokens()) {
   width = columnWitdths.nextToken();
}

Show
Workaround for me, patch the TableRenderer by replacing if (isScrollable(uiComponent) &&    columnWitdths != null &&    columnWitdths.hasMoreTokens()) {    width = columnWitdths.nextToken(); } with: if (columnWitdths != null &&    columnWitdths.hasMoreTokens()) {    width = columnWitdths.nextToken(); }

Description

TableRenderer puts always the hardcoded width 150px (Line: 659):

String width = "150px;";
if (isScrollable(uiComponent) &&
   columnWitdths != null &&
   columnWitdths.hasMoreTokens()) {
   width = columnWitdths.nextToken();
}

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

3943-TableRenderer-UIColumns.patch

24/Aug/09 6:49 PM

4 kB

Ed Hillmann
Hide
Case8549Example.war

10/Aug/09 11:44 AM

5.37 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Item.class 0.8 kB

WEB-INF/classes/.../example/TestBean.class 2 kB

WEB-INF/faces-config.xml 0.5 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 343 kB

WEB-INF/lib/commons-beanutils.jar 113 kB

WEB-INF/lib/commons-collections.jar 162 kB

WEB-INF/lib/commons-digester.jar 104 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-logging.jar 30 kB

WEB-INF/lib/icefaces-comps.jar 1.93 MB

WEB-INF/lib/icefaces.jar 1.06 MB

WEB-INF/lib/jsf-api.jar 350 kB

WEB-INF/lib/jsf-impl.jar 816 kB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB

WEB-INF/web.xml 3 kB

index.jsp 0.1 kB

main.jspx 2 kB

Download Zip
Show

Case8549Example.war

10/Aug/09 11:44 AM

5.37 MB

Arran Mccullough

Issue Links

blocks

ICE-4979 ArrayIndexOutOfBoundsException from TableRenderer.getWidthFromColumnWidthsArray

Closed

Activity

Descending order - Click to sort in ascending order

Hide

Permalink

Ken Fyten added a comment - 10/Sep/09 3:28 PM

Re-instated original changes for this issue. The actual cause of regression was related to changes made for ~~ICE-4916~~.

Show

Ken Fyten added a comment - 10/Sep/09 3:28 PM Re-instated original changes for this issue. The actual cause of regression was related to changes made for ICE-4916 .

Hide

Permalink

yip.ng added a comment - 09/Sep/09 10:37 AM

Backed out original changes for now. Need more time to debug. (There were 48 differences in the diff.)

Show

yip.ng added a comment - 09/Sep/09 10:37 AM Backed out original changes for now. Need more time to debug. (There were 48 differences in the diff.)

Hide

Permalink

Ken Fyten added a comment - 08/Sep/09 1:16 PM

More details on the regression failures:

~~ICE-3136~~: failed on IE and FF (works fine on Opera) - column.rendered is not interpreted inside a headerRow element
~~ICE-3057~~: failed - columns are not resizable when resize: true clientOnly: false
~~ICE-2371~~: failed on IE and FF (works fine on Opera) - things wrong with the column headers
~~ICE-2234~~: failed on IE and FF (works fine on Opera) - things wrong with the column headers
They seem all column headers related. The column header row disappears when multiple clicks apply to it. It affects column resizable and sortable on IE and FF. Opera is fine.

Show

Ken Fyten added a comment - 08/Sep/09 1:16 PM More details on the regression failures: ICE-3136 : failed on IE and FF (works fine on Opera) - column.rendered is not interpreted inside a headerRow element ICE-3057 : failed - columns are not resizable when resize: true clientOnly: false ICE-2371 : failed on IE and FF (works fine on Opera) - things wrong with the column headers ICE-2234 : failed on IE and FF (works fine on Opera) - things wrong with the column headers They seem all column headers related. The column header row disappears when multiple clicks apply to it. It affects column resizable and sortable on IE and FF. Opera is fine.

Hide

Permalink

Ken Fyten added a comment - 08/Sep/09 12:32 PM

The change for this issue is causing the following regression test failures using IE7 and FF2:

Show

Ken Fyten added a comment - 08/Sep/09 12:32 PM The change for this issue is causing the following regression test failures using IE7 and FF2: ICE-3136 : failed on IE and FF (works fine on Opera) - column.rendered is not interpreted inside a headerRow element ICE-3057 : failed - columns are not resizable when resize: true clientOnly: false ICE-2371 : failed on IE and FF (works fine on Opera) - things wrong with the column headers ICE-2234 : failed on IE and FF (works fine on Opera) - things wrong with the column headers

Hide

Permalink

Joanne Bai added a comment - 06/Sep/09 12:15 PM

Verified with success on ICEfaces trunk revision 19228 + tomcat6.0

Tested on FF3.5, IE6 and IE7

Test app committed to repo\qa\trunk\Regression\~~ICE-3943~~

Show

Joanne Bai added a comment - 06/Sep/09 12:15 PM Verified with success on ICEfaces trunk revision 19228 + tomcat6.0 Tested on FF3.5, IE6 and IE7 Test app committed to repo\qa\trunk\Regression\ ICE-3943

5 older comments

Hide

Permalink

Krashan Brahmanjara added a comment - 17/Jan/09 5:30 AM

I don't see any problems. Use numer of columntWitdth's equal to number of columns.

Show

Krashan Brahmanjara added a comment - 17/Jan/09 5:30 AM I don't see any problems. Use numer of columntWitdth's equal to number of columns.

People

Assignee:

yip.ng

Reporter:

Tobias Schafer

Votes:

4 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

07/Jan/09 8:08 AM

Updated:

07/Jan/10 12:04 PM

Resolved:

10/Sep/09 3:28 PM