ICEfaces
  1. ICEfaces
  2. ICE-3916

Pressing enter key when radio or checkbox has focus causes submit to occur on closest button

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2
          • Fix Version/s: 1.8RC1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When a selectOneRadio or selectBooleanCheckbox has focus and the user hits the enter key the closest commandButton gets submitted. Here is some sample code to reproduce this issue:

                         <ice:form id="form1">
                            <ice:selectOneRadio id="idCommitmentTime" value="1">
                                <f:selectItems id="sel1" value="#{testBean.selList}"/>
                            </ice:selectOneRadio>
                            <br/>
                            <ice:commandButton value="test it" onclick="javascript:testOne();" tabindex="2"/>
                        </ice:form>

            <script>
                        function testOne(){
                            alert('ICEfaces');
                        }
            </script>

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [50070000007ZDaj]
              Ken Fyten made changes -
              Summary Hiting enter key when radio or checkbox has focus causes submit to occur on closest button Pressing enter key when radio or checkbox has focus causes submit to occur on closest button
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Problem also reproducible on SelectManyCheckBox component.

              Show
              Mandeep Hayher added a comment - Problem also reproducible on SelectManyCheckBox component.
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Test application available in qa repository 'repo\qa\trunk\Regression\ICE-3916'.

              Show
              Mandeep Hayher added a comment - Test application available in qa repository 'repo\qa\trunk\Regression\ ICE-3916 '.
              Ken Fyten made changes -
              Fix Version/s 1.8DR#3 [ 10143 ]
              Assignee Priority P2
              Assignee Yip Ng [ yip.ng ]
              Ken Fyten made changes -
              Comment [ Isn't this the standard HTML behavior? To toggle the radio button or check box, you should use the space bar, not the enter key.
              ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18192 Mon Jan 19 15:04:48 MST 2009 yip.ng ICE-3916
              Made enter key on radio and checkbox do a submit.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras_util.js
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18193 Mon Jan 19 16:36:15 MST 2009 yip.ng ICE-3916
              Added onclick property.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_properties/ice-selectBooleanCheckbox-props.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18194 Mon Jan 19 16:39:45 MST 2009 yip.ng ICE-3916
              Added onkeypress property.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_properties/ice-selectBooleanCheckbox-props.xml
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              yip.ng made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18204 Wed Jan 21 10:36:14 MST 2009 yip.ng ICE-3916
              Made enter key on radio and checkbox do a submit.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_properties/ice-selectBooleanCheckbox-props.xml
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CheckboxRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P2
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Yip Ng [ yip.ng ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: