ICEfaces
  1. ICEfaces
  2. ICE-3906

JavaScript error is caught when closing a popupPanel with inputFile

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1, 1.7.2, 1.7.2 SP1
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ANY

      Description

      When closed a panelPopup with inputFile component, the following JavaScript error is caught:

      document.getElementById("iceForm:j_id19:uploadFrame") is null
      [Break on this error] [Ice.Script=new Object,Ice.Ajax.Client]....o evaluate script: \n"+code,e);}}}});});

      This issue occurs only when value specified for attribute "submitOnUpload" of inputFile is not "none"
      It seems that ICEfaces 1.7.0 doesn't have this issue.

        Activity

        Sam Xiao created issue -
        Sam Xiao made changes -
        Field Original Value New Value
        Salesforce Case [50070000007ZFC7]
        Hide
        Sam Xiao added a comment -

        Test case with ICEfaces 1.7.2 SP1 and for Tomcat 6.0

        Show
        Sam Xiao added a comment - Test case with ICEfaces 1.7.2 SP1 and for Tomcat 6.0
        Sam Xiao made changes -
        Attachment support7852.war [ 11412 ]
        Hide
        Sam Xiao added a comment -

        test

        Show
        Sam Xiao added a comment - test
        Sam Xiao made changes -
        Attachment test.jpg [ 11420 ]
        Sam Xiao made changes -
        Attachment test.jpg [ 11420 ]
        Ken Fyten made changes -
        Fix Version/s 1.8DR#3 [ 10143 ]
        Assignee Priority P1
        Assignee Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Component/s Components [ 10012 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18197 Tue Jan 20 15:54:48 MST 2009 mark.collette ICE-3906 : JavaScript error is caught when closing a popupPanel with inputFile
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFileRenderer.java
        Hide
        Mark Collette added a comment -

        The inputFile makes use of an onunload event on the iframe for detecting when the upload has completed, for the postUpload form submission. The problem was that when the iframe was unloaded, not because of an upload, but because it was not being rendered anymore, due to the container panelPopup ceasing to be rendered, that specific handler code shouldn't run. Now it makes a few more sanity tests as it goes.

        Subversion 18197
        icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java

        Show
        Mark Collette added a comment - The inputFile makes use of an onunload event on the iframe for detecting when the upload has completed, for the postUpload form submission. The problem was that when the iframe was unloaded, not because of an upload, but because it was not being rendered anymore, due to the container panelPopup ceasing to be rendered, that specific handler code shouldn't run. Now it makes a few more sanity tests as it goes. Subversion 18197 icefaces\component\src\com\icesoft\faces\component\inputfile\InputFileRenderer.java
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Sam Xiao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: