ICEfaces
  1. ICEfaces
  2. ICE-3871

OutputResource link shows xml page when session is expired

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.2 SP1
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When the session expires on a screen with an OutputResource link, clicking that link will you to an xml page that has only a <session-expired/> tag.
      The desired behavior should be to give the regular session expired popup or atleast a more user friendly message.

        Activity

        Tyler Johnson created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Salesforce Case [50070000007Yl2y]
        Hide
        Tyler Johnson added a comment -

        OutputResource test case

        Show
        Tyler Johnson added a comment - OutputResource test case
        Tyler Johnson made changes -
        Attachment support5311-11052008.war [ 11396 ]
        Ken Fyten made changes -
        Fix Version/s 1.8DR#3 [ 10143 ]
        Assignee Priority P2
        Assignee Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Assignee Mark Collette [ mark.collette ] Yip Ng [ yip.ng ]
        Hide
        Ken Fyten added a comment -

        Framework should return a human-readable session expired message.

        Show
        Ken Fyten added a comment - Framework should return a human-readable session expired message.
        Ken Fyten made changes -
        Assignee Yip Ng [ yip.ng ] Deryk Sinotte [ deryk.sinotte ]
        Deryk Sinotte made changes -
        Assignee Deryk Sinotte [ deryk.sinotte ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18165 Mon Jan 12 05:55:23 MST 2009 mircea.toma ICE-3871 Modify SessionVerifier.class to also send normal HTTP error responses for coresponding resource requests.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/SessionExpiredException.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainServlet.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/SessionVerifier.java
        Hide
        Mircea Toma added a comment -

        Rendering "User Session Expired" is not possible since a resource does not have an associated running bridge.
        Also, if plain text message is rendered, message that explains why the resource is not served up it will eventually have to be localized and styled.

        So to avoid previously mentioned complexities SessionVerifier.class was modified to also send normal HTTP error responses for coresponding resource requests. This gives the application developer the opportunity to capture SessionExpiredException using container's error handling mechanism and render a customized message.

        Show
        Mircea Toma added a comment - Rendering "User Session Expired" is not possible since a resource does not have an associated running bridge. Also, if plain text message is rendered, message that explains why the resource is not served up it will eventually have to be localized and styled. So to avoid previously mentioned complexities SessionVerifier.class was modified to also send normal HTTP error responses for coresponding resource requests. This gives the application developer the opportunity to capture SessionExpiredException using container's error handling mechanism and render a customized message.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Keith Garry Boyce added a comment -

        There was another issue i saw with this.. continual interaction with output resource window.. i.e refreshing.. does not keep session alive hence leading to session expired on page which you clicked on openResource link

        Show
        Keith Garry Boyce added a comment - There was another issue i saw with this.. continual interaction with output resource window.. i.e refreshing.. does not keep session alive hence leading to session expired on page which you clicked on openResource link
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P2
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Mircea Toma [ mircea.toma ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: