ICEfaces
  1. ICEfaces
  2. ICE-3858

Add ability to specify destination target with OutputResource

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.2 SP1
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When there are two or more outputResource components, if one is already open, opening a second one will overwrite the first. The improvement is to add a way to change the destination target of the component. Right now in our source it is hard coded to traget="blank".

        Activity

        Tyler Johnson created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Salesforce Case [50070000007DQdY]
        Description When there are two or more outputResource components, if one is already open, opening a second one will overwrite the first. The improvement is to add a way to change the destination target of the component. Right now in our source it is hard coded to blank. When there are two or more outputResource components, if one is already open, opening a second one will overwrite the first. The improvement is to add a way to change the destination target of the component. Right now in our source it is hard coded to traget="blank".
        Hide
        Keith Garry Boyce added a comment -

        consider: resource.setAttribute("target", outputResource.getPath());

        as a default if a passed through target is not supplied to component

        Show
        Keith Garry Boyce added a comment - consider: resource.setAttribute("target", outputResource.getPath()); as a default if a passed through target is not supplied to component
        Ken Fyten made changes -
        Fix Version/s 1.8DR#3 [ 10143 ]
        Assignee Priority P1
        Assignee Yip Ng [ yip.ng ]
        Hide
        yip.ng added a comment -

        The reason a new browser window (or tab) is not open is that the hard coded target value should be "_blank", not "blank". (Common HTML mistake.) But I will add the target attribute anyway and make "_blank" the default value.

        Show
        yip.ng added a comment - The reason a new browser window (or tab) is not open is that the hard coded target value should be "_blank", not "blank". (Common HTML mistake.) But I will add the target attribute anyway and make "_blank" the default value.
        yip.ng made changes -
        Attachment ScreenHunter_01 Dec. 22 10.36.jpg [ 11424 ]
        yip.ng made changes -
        Attachment ScreenHunter_01 Dec. 22 10.48.jpg [ 11425 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18119 Wed Dec 24 13:53:30 MST 2008 yip.ng ICE-3858
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputresource/OutputResource.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputresource/OutputResourceRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-outputresource-props.xml
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18120 Mon Dec 29 08:03:47 MST 2008 frank.ye ICE-3858 add default-value for target attribute with OutputResource
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-outputresource-props.xml
        Hide
        Keith Garry Boyce added a comment -

        Does this handle the case where you want to overwrite? i.e: you want the same target

        Show
        Keith Garry Boyce added a comment - Does this handle the case where you want to overwrite? i.e: you want the same target
        Hide
        yip.ng added a comment -

        Yes. Just set the target attribute explicitly. Anything other than "_blank" (default) will reuse an existing target window with the same name, if any. Otherwise a new window with the specified name will be created.

        Show
        yip.ng added a comment - Yes. Just set the target attribute explicitly. Anything other than "_blank" (default) will reuse an existing target window with the same name, if any. Otherwise a new window with the specified name will be created.
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: