ICEfaces
  1. ICEfaces
  2. ICE-3833

DataPaginator calls actionListener before changing page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.8RC1, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      There's a couple forum posting about this. Here's the method from DataPaginator.java:

          public void broadcast(FacesEvent event) throws AbortProcessingException {
              super.broadcast(event);

              if (event instanceof PaginatorActionEvent) {
                  PaginatorActionEvent scrollerEvent = (PaginatorActionEvent) event;
                  broadcastToActionListener(scrollerEvent);
                  UIData uiData = getUIData();
                  if (uiData == null) {
                      return;
                  }

                  // Now, all the code to actually change the page
              }
          }


      Because of this, applications can't act on which page is going to be changed to, since they really only have the current/old page info. Also, it looks like PaginatorActionEvent can have a page index if the user clicked on a specific page, but will just know the facet name if the user clicked on a relative link, like next, previous, etc. It would be nice if the new page index was resolved, from the relative info, and set into the PaginatorActionEvent, before the event was broadcast, so all the info would be readily available in a single place.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18134 Fri Jan 02 08:23:07 MST 2009 adnan.durrani Fix for ICE-3833 (DataPaginator calls actionListener before changing page)
        Changes has been made so the actionListener will be called after the page change, in addition to that PaginatorActionEvent would have the right page index even if the relative link (e.g. fast-forward) was clicked.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginator.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/PaginatorActionEvent.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: