ICEfaces
  1. ICEfaces
  2. ICE-3816

ICEfaces AHS: Possible Throwables should be caught and dealt with during request processing

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.2, 1.8DR#1
    • Fix Version/s: 1.7.2 SP1, 1.8DR#2, 1.8
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces AHS

      Description

      Any possible Throwables should be caught during request processing. These Throwables should be logged, and if possible a 500 Internal Server Error should be send as a response to the Bridge.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17931 Tue Nov 25 17:50:49 MST 2008 jack.van.ooststroom Fixed JIRA ICE-3816 : ICEfaces AHS: Possible Throwables should be caught and dealt with during request processing
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/WriteHandler.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/ProcessHandler.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/AbstractHttpConnection.java
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/HttpVersionNotSupportedResponse.java
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/ServerErrorResponse.java
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/NotImplementedResponse.java
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/InternalServerErrorResponse.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/ReadHandler.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/HttpConnection.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17932 Tue Nov 25 19:19:04 MST 2008 jack.van.ooststroom Fixed JIRA ICE-3816 : ICEfaces AHS: Possible Throwables should be caught and dealt with during request processing; Fixed sloppy copy-past issue
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/ahs/src/com/icesoft/faces/async/server/AbstractHttpConnection.java
        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Jack Van Ooststroom added a comment -

        Changed Fix Version(s) to 1.7.2-SP1 and 1.8-DR#2

        Show
        Jack Van Ooststroom added a comment - Changed Fix Version(s) to 1.7.2-SP1 and 1.8-DR#2
        Jack Van Ooststroom made changes -
        Salesforce Case []
        Fix Version/s 1.7.2 SP1 [ 10144 ]
        Fix Version/s 1.8DR#2 [ 10142 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17936 Wed Nov 26 14:08:48 MST 2008 jack.van.ooststroom Fixed JIRA ICE-3816 : ICEfaces AHS: Possible Throwables should be caught and dealt with during request processing
        Files Changed
        Commit graph ADD /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/ServerErrorResponse.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/WriteHandler.java
        Commit graph ADD /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/NotImplementedResponse.java
        Commit graph ADD /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/HttpVersionNotSupportedResponse.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/ReadHandler.java
        Commit graph ADD /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/InternalServerErrorResponse.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/HttpConnection.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/AbstractHttpConnection.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/ProcessHandler.java
        Hide
        Jack Van Ooststroom added a comment -

        When an unexpected Throwable is thrown during request processing, done by the ReadHandler, ProcessHandler and WriteHandler, it is caught and dealt with:

        • The Throwable is logged on the server end
        • If an HTTP Response can still be send back to the Bridge, a 500 (Internal Server Error) is send
        • If no HTTP Response can be send back, the connection is closed on the server end

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - When an unexpected Throwable is thrown during request processing, done by the ReadHandler, ProcessHandler and WriteHandler, it is caught and dealt with: The Throwable is logged on the server end If an HTTP Response can still be send back to the Bridge, a 500 (Internal Server Error) is send If no HTTP Response can be send back, the connection is closed on the server end Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jack Van Ooststroom added a comment -

        Just as added info: when the Bridge receives a 500 (Internal Server Error), a pop-up appears in the browser informing of the error and the Bridge is shutdown. The pop-up contains a reload button as well, which will reload the page and instantiate a new Bridge in order for the user to continue his/her work. Please note that this error will not invalidate the session.

        Show
        Jack Van Ooststroom added a comment - Just as added info: when the Bridge receives a 500 (Internal Server Error), a pop-up appears in the browser informing of the error and the Bridge is shutdown. The pop-up contains a reload button as well, which will reload the page and instantiate a new Bridge in order for the user to continue his/her work. Please note that this error will not invalidate the session.
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Jack van Ooststroom [ jack.van.ooststroom ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: