ICEfaces
  1. ICEfaces
  2. ICE-3795

RowSelector Performance Improvement

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2
          • Fix Version/s: 1.8RC1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            The RowSelector component performs a server round trip before updating the row's styling. The speed it takes to highlight a row can depend on factors as network latency and these delays can be confusing to the user. Ideally, the RowSelector should first update the row's styling and then perform the partial submit.

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-4301 rowSelector preStyleOnSelection

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Tyler Johnson created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Assignee Ken Fyten [ ken.fyten ]
                Tyler Johnson made changes -
                Salesforce Case [50070000007CEJb]
                Ken Fyten made changes -
                Fix Version/s 1.8DR#3 [ 10143 ]
                Assignee Priority P1
                Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                True. This is old problem discussed earlier on forum and jira.
                Small update of css attribute should be done before request is send. Tables will looks much better.

                Show
                Krashan Brahmanjara added a comment - True. This is old problem discussed earlier on forum and jira. Small update of css attribute should be done before request is send. Tables will looks much better.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18157 Thu Jan 08 09:49:11 MST 2009 yip.ng ICE-3795
                Changed to update selected row style before doing submit.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
                yip.ng made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                Patch added to repository looks good. But probably better solution will be patch of javascript submit function.
                Current solution is simply but do not hides previous seleced row.

                On current trunk revision I see another problem. If user fast select few row all stay selected ...on single selection list. Up to december I didn't saw that bahaviour.

                Show
                Krashan Brahmanjara added a comment - Patch added to repository looks good. But probably better solution will be patch of javascript submit function. Current solution is simply but do not hides previous seleced row. On current trunk revision I see another problem. If user fast select few row all stay selected ...on single selection list. Up to december I didn't saw that bahaviour.
                yip.ng made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                yip.ng added a comment -

                Can't reproduce "fast select few rows all stay selected".

                Show
                yip.ng added a comment - Can't reproduce "fast select few rows all stay selected".
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                Fast selection problems I saw that on scrollable list. My temporary solution - reverting RowSelector.java do dat 5.12.2008

                Show
                Krashan Brahmanjara added a comment - Fast selection problems I saw that on scrollable list. My temporary solution - reverting RowSelector.java do dat 5.12.2008
                Hide
                Permalink
                Ken Fyten added a comment -

                Cannot reproduce any fast selection problems as of SVN rev. # 18258.

                Show
                Ken Fyten added a comment - Cannot reproduce any fast selection problems as of SVN rev. # 18258.
                Ken Fyten made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Assignee Priority P1
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18288 Wed Feb 04 10:14:53 MST 2009 yip.ng ICE-3795
                Changed to update selected row style before doing submit.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18695 Mon Mar 30 17:51:13 MDT 2009 yip.ng ICE-3795
                Added prestyleOnSelection attribute to turn on or off row selection pre-styling on client side.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
                Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/dataTable-rowSelection.jspx
                Ken Fyten made changes -
                Link This issue blocks ICE-4301 [ ICE-4301 ]
                Ken Fyten made changes -
                Fix Version/s 1.8 [ 10161 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Yip Ng [ yip.ng ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28561 Tue Mar 27 17:24:04 MDT 2012 greg.dick ICE-3795 updated dependencies and repositories to fetch webflow nightly build
                Files Changed
                Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/tutorials/booking-icefaces/pom.xml

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Tyler Johnson
                  • Votes:
                    3 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: