QA used JSP component-showcase and verified the fix again on ICEfaces trunk revision 18864

Tested successfully on ICEFaces1.8 RC1 build2, jsp version component-showcase on tomcat5 server (windows machine).

Hi Krashan Brahmanjara,

Sorry to say that you have got some misunderstanding, there are only two hidden fields added per table, not per row.

Thanks,
Adnan

Confirmed that the Mac Command key is working as expected.

I see that on every row you add two hidden inputs. I suppose that better solution will be enabling this part of code only if multiselect is enabled.
if (rowSelectorFound) {
> if (rowSelector.isEnhancedMultiple())

Also instead hidden inputs javasript array can be used. But this is feature request only for performance issues.

Doc added :
svn\ossrepo\icefaces\trunk\icefaces\component\doc\tableRowSelectionDoc.html
Trunk: revision 18202

Mac key support added.

Trunk: revision 18201

Also need to add this new feature the Description page (comp. showcase) for this component.

Need to add support for the Mac "Command" key to be used instead of the CTRL key (same functionality).

Here is a reference to the relevant keycodes, etc.: http://unixpapa.com/js/key.html

Note the section that states:

"On keydown and keyup, the event objects also have flags that indicate which modifier keys were being pressed when the key was typed. These are:

event.shiftKey
event.ctrlKey
event.altKey
event.metaKey

These all have true or false values. According to the DOM 3 standard, on the Macintosh, the Option key should activate event.altKey and the Command key should activate event.metaKey. These attributes seem to work correctly on all modern browsers tested, except event.metaKey is undefined in all versions IE. There is some freakishness in obsolete browsers that can probably be ignored these days. In Macintosh versions of IE, the Command key sets event.ctrlKey and the Control key does nothing. In Netscape 4, none of these attributes existed and the event.modifiers attribute needed to be used instead."

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelectorEvent.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-rowselector-props.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\rowSelector\RowSelectController.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_en.properties
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_es.properties
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\dataTable-rowSelection.jspx
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelectorEvent.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_es.properties
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\rowSelector\RowSelectController.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\dataTable-rowSelection.jspx
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-rowselector-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_en.properties
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Completed: At revision: 18168

revision: 18168

New enhancedMultiple boolean attribute added. When true, it offers following selection behaviour:

• "Click" selects clicked row and deselects rest
• "Click + Ctrl" flip the selection of clicked row and keeps previous selection intact
• "Click + Shift" selects all rows from last clicked row to newly clicked row, and deselect rest
• "Click + Shift + Ctrl" selects all rows from last clicked row to newly clicked row and keeps previous selection intact

java.awt.List has these two methods, showing their later addition of supporting multiple selection
int getSelectedIndex()
int[] getSelectedIndexes()

We should probably follow a similar approach, and have clickedRow:int and clickRows:int[]

See also http://jira.icefaces.org/browse/ICE-2001