ICEfaces
  1. ICEfaces
  2. ICE-3720

IE loses focus when tabbing goes beyond currently visible area of screen

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.2
    • Fix Version/s: 1.8RC2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      IE7

      Description

      When tabbing through the following page structure:

      <inputText><label><selectOneMenu id="1"><label><selectOneMenu id="2">

      <br/><br/>...... // large page break

      //fields not visible on page load
      <selectOneMenu id="3"><inputText>

      All fields have partialSubmit set to true and all tab correctly. IE7 will lose focus when tabbing from selectOneMenu id="2" to selectOneMenu id="3".

        Issue Links

          Activity

          Tyler Johnson created issue -
          Tyler Johnson made changes -
          Field Original Value New Value
          Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=5326
          Hide
          Tyler Johnson added a comment -

          Sample app intended for deployment on Jboss 4.2

          Show
          Tyler Johnson added a comment - Sample app intended for deployment on Jboss 4.2
          Tyler Johnson made changes -
          Attachment SC5326.war [ 11318 ]
          Ken Fyten made changes -
          Assignee Priority P1
          Assignee Adnan Durrani [ adnan.durrani ]
          Ken Fyten made changes -
          Fix Version/s 1.8DR#2 [ 10142 ]
          Adnan Durrani made changes -
          Assignee Adnan Durrani [ adnan.durrani ] Ken Fyten [ ken.fyten ]
          Ken Fyten made changes -
          Assignee Priority P1 P2
          Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
          Priority Major [ 3 ] Minor [ 4 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17915 Wed Nov 19 15:26:52 MST 2008 mircea.toma ICE-3720 Remove obsolete code.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/focus.js
          Hide
          Mircea Toma added a comment -

          After I researched the historical reasons why the focus is reset when scrolling I came to the conclusion that the code I no longer necessary.

          Show
          Mircea Toma added a comment - After I researched the historical reasons why the focus is reset when scrolling I came to the conclusion that the code I no longer necessary.
          Mircea Toma made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Ken Fyten added a comment -

          Mandeep Hayher added a comment - 04/Feb/09 03:55 PM
          Tooltip for provinces in component-showcase sample app still seems to have positioning problem. If the target tooltip doesnot fit below the province name in current window size, the window scroll bar is forced to move and tooltip disappears while this scrolling happens.

          Yip Ng added a comment - 09/Feb/09 02:23 PM ...it seems that the problem occurs only in Firefox, not in IE.

          Yip Ng added a comment - 10/Feb/09 11:48 AM
          Finally found what caused the problem. It was caused by the fix for ICE-3720. If we revert changes for ICE-3720, everything will work fine. See the attached screenshots.

          So, it looks like we have a regression related to the removal of this focus mgmt. code.

          Show
          Ken Fyten added a comment - Mandeep Hayher added a comment - 04/Feb/09 03:55 PM Tooltip for provinces in component-showcase sample app still seems to have positioning problem. If the target tooltip doesnot fit below the province name in current window size, the window scroll bar is forced to move and tooltip disappears while this scrolling happens. Yip Ng added a comment - 09/Feb/09 02:23 PM ...it seems that the problem occurs only in Firefox, not in IE. Yip Ng added a comment - 10/Feb/09 11:48 AM Finally found what caused the problem. It was caused by the fix for ICE-3720 . If we revert changes for ICE-3720 , everything will work fine. See the attached screenshots. So, it looks like we have a regression related to the removal of this focus mgmt. code.
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 1.8 [ 10161 ]
          Fix Version/s 1.8DR#2 [ 10142 ]
          Hide
          Ken Fyten added a comment -

          Can you make the focus setting browser specific, as it seems to cause problems for IE to have it there, but causes problems in FF if it's not there.

          Show
          Ken Fyten added a comment - Can you make the focus setting browser specific, as it seems to cause problems for IE to have it there, but causes problems in FF if it's not there.
          Hide
          Mircea Toma added a comment -

          I would prefer not to do that. Because we avoided in the past to have browser specific code, it paid off every time ICEfaces had to run on a new browser or browser version. I am not convinced that putting back the removed code is the only (or preferred) solution for fixing a component problem.

          Show
          Mircea Toma added a comment - I would prefer not to do that. Because we avoided in the past to have browser specific code, it paid off every time ICEfaces had to run on a new browser or browser version. I am not convinced that putting back the removed code is the only (or preferred) solution for fixing a component problem.
          Ken Fyten made changes -
          Link This issue blocks ICE-4069 [ ICE-4069 ]
          Hide
          Ken Fyten added a comment -

          The removal of this focus code may also be involved with a focus issue in IE, as per ICE-4069.

          Show
          Ken Fyten added a comment - The removal of this focus code may also be involved with a focus issue in IE, as per ICE-4069 .
          Hide
          Mircea Toma added a comment -

          I discovered that the difference in behavior between IE and Firefox is due to our focus preservation mechanism coupled with the difference in behavior of IE compared to Firefox.
          Every time a submit is done the bridge sends the ID of the focused element to the browser. When the server sends back the updates it will append a command that will force the bridge to re-apply the focus back on the submitting element, just in case the focus gets lost due to a larger update.
          In the case of component-showcase's tooltip panel the focus is re-applied on the "Tooltip Panel" command link found in the navigation panels. Because the command link is down at the bottom of the page Firefox will scroll to that focused command link (IE does not scroll to the focused element).
          The onscroll event handler wired previously used to set the focus on the window and also cancel the sending of the focused element. This was a brute force solution to solve the limitations of our focus preservation mechanism.
          Even if we would wire back the onscroll event handler if the "Tooltip Panel" command link would be vertically at the same level with the tooltip panel, thus not having to scroll down to the command link, we would still see this issue occurring.

          Show
          Mircea Toma added a comment - I discovered that the difference in behavior between IE and Firefox is due to our focus preservation mechanism coupled with the difference in behavior of IE compared to Firefox. Every time a submit is done the bridge sends the ID of the focused element to the browser. When the server sends back the updates it will append a command that will force the bridge to re-apply the focus back on the submitting element, just in case the focus gets lost due to a larger update. In the case of component-showcase's tooltip panel the focus is re-applied on the "Tooltip Panel" command link found in the navigation panels. Because the command link is down at the bottom of the page Firefox will scroll to that focused command link (IE does not scroll to the focused element). The onscroll event handler wired previously used to set the focus on the window and also cancel the sending of the focused element. This was a brute force solution to solve the limitations of our focus preservation mechanism. Even if we would wire back the onscroll event handler if the "Tooltip Panel" command link would be vertically at the same level with the tooltip panel, thus not having to scroll down to the command link, we would still see this issue occurring.
          Hide
          Mircea Toma added a comment -

          An easy way to test my findings is to click on the window after clicking "Tooltip Panel" link. This will remove the focus from the link and make the tooltips show up correctly the first time.

          Show
          Mircea Toma added a comment - An easy way to test my findings is to click on the window after clicking "Tooltip Panel" link. This will remove the focus from the link and make the tooltips show up correctly the first time.
          Hide
          Ken Fyten added a comment -

          May be some interactions in IE between these issues, should be reviewed together to ensure any changes will turn out positively for the related issues, etc.

          Show
          Ken Fyten added a comment - May be some interactions in IE between these issues, should be reviewed together to ensure any changes will turn out positively for the related issues, etc.
          Ken Fyten made changes -
          Link This issue blocks ICE-3693 [ ICE-3693 ]
          Mircea Toma made changes -
          Link This issue depends on ICE-4102 [ ICE-4102 ]
          Hide
          Mircea Toma added a comment -

          Resolved by the fixes for ICE-4102.

          Show
          Mircea Toma added a comment - Resolved by the fixes for ICE-4102 .
          Mircea Toma made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 1.8RC2 [ 10163 ]
          Fix Version/s 1.8 [ 10161 ]
          Ken Fyten made changes -
          Fix Version/s 1.8 [ 10161 ]
          Assignee Priority P2
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Mircea Toma [ mircea.toma ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Tyler Johnson
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: