Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#1
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      any

      Description

      Using tools from w3c, http://jigsaw.w3.org/css-validator/DOWNLOAD.html

      the style sheet is not valid.

      for example: xp.css
      >
      > /*
      > ----------- panelSeries ----------
      > */
      > .icePnlSrs {
      >
      > }
      >
      > ----------- positionedPanel ----------
      > */
      > .icePnlPos {
      >
      > }
      >
      >
      >


      suggest to include the verify process in our build bundle

        Issue Links

          Activity

          Frank Ye created issue -
          Hide
          Ken Fyten added a comment -

          Please fix the existing theme stylesheets so they pass the W3C tests, then take a look at having the test run with each build.

          Show
          Ken Fyten added a comment - Please fix the existing theme stylesheets so they pass the W3C tests, then take a look at having the test run with each build.
          Ken Fyten made changes -
          Field Original Value New Value
          Assignee Priority P1
          Assignee Adnan Durrani [ adnan.durrani ]
          Ken Fyten made changes -
          Fix Version/s 1.8DR#2 [ 10142 ]
          Hide
          Paul van Rossem added a comment -

          You guys missed ICE-3234 ?

          Show
          Paul van Rossem added a comment - You guys missed ICE-3234 ?
          Frank Ye made changes -
          Link This issue duplicates ICE-3234 [ ICE-3234 ]
          Hide
          Frank Ye added a comment -

          thanks for pointing out, this issue is marked as duplicates

          Show
          Frank Ye added a comment - thanks for pointing out, this issue is marked as duplicates
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17857 Mon Nov 03 07:43:56 MST 2008 adnan.durrani Fix for ICE-3718 (css style sheet is not valid)
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
          Hide
          Adnan Durrani added a comment -

          trunk/xp.css corrected. revision 17857

          Show
          Adnan Durrani added a comment - trunk/xp.css corrected. revision 17857
          Hide
          Adnan Durrani added a comment -

          The jar provided on the following link has some errors:
          http://jigsaw.w3.org/css-validator/DOWNLOAD.html

          After google, I found out that the jar has some bugs in it, and the code needs to be checkout and fixed by the developer, so I have checkout the src of the css-validator and build it, found some errors. I fixed some path related errors, now it runs but still gives other errors. I think its better to find some other alternate to test the css validity as part of the build.

          After fixing couple of things, I still get the following error:

          D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\css-validator>java -jar css-validator.jar http://www.w3.org/

          {output=text, medium=all, warning=2, profile=css21, lang=en}

          org.w3c.css.css.XMLStyleSheetHandler: couldn't load catalog.xml
          no protocol: "jar:file:/D:/work/development/head/svn/ossrepo/icefaces/trunk/icefaces/css-validator/css-validator.jar!/org/w3c/css/util/xml/catalog.xml"
          5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log
          INFO: Velocity not initialized yet. Calling init()...
          5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log
          INFO: FileResourceLoader : adding path '.'
          5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log
          SEVERE: ResourceManager : unable to find resource 'text.properties' in any resource loader.
          Unable to find resource 'text.properties'
          org.apache.velocity.exception.ResourceNotFoundException: Unable to find resource 'text.properties'
          at org.apache.velocity.runtime.resource.ResourceManagerImpl.loadResource(ResourceManagerImpl.java:452)
          at org.apache.velocity.runtime.resource.ResourceManagerImpl.getResource(ResourceManagerImpl.java:335)
          at org.apache.velocity.runtime.RuntimeInstance.getTemplate(RuntimeInstance.java:1102)
          at org.apache.velocity.runtime.RuntimeInstance.getTemplate(RuntimeInstance.java:1077)
          at org.apache.velocity.runtime.RuntimeSingleton.getTemplate(RuntimeSingleton.java:303)
          at org.apache.velocity.app.Velocity.getTemplate(Velocity.java:503)
          at org.w3c.css.css.StyleSheetGenerator.<init>(StyleSheetGenerator.java:161)
          at org.w3c.css.css.StyleReportFactory.getStyleReport(StyleReportFactory.java:19)
          at org.w3c.css.css.CssValidator.handleRequest(CssValidator.java:179)
          at org.w3c.css.css.CssValidator.main(CssValidator.java:152)
          java.lang.NullPointerException
          at org.w3c.css.css.StyleSheetGenerator.print(StyleSheetGenerator.java:419)
          at org.w3c.css.css.CssValidator.handleRequest(CssValidator.java:192)
          at org.w3c.css.css.CssValidator.main(CssValidator.java:152)
          <!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Strict//EN'
          "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
          <html lang='en' xml:lang='en' xmlns='http://www.w3.org/1999/xhtml'>
          <head>
          <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
          <title>CSS Validator : Error</title>
          <link type="text/css" rel='stylesheet' href='http://jigsaw.w3.org/css-validator/style/error.css' />
          </head>

          <body>
          <div>
          <a href="http://www.w3.org/"><img src="http://www.w3.org/Icons/w3c_home" alt="w3c" /></a>
          </div>
          <hr />
          <div class="t1">CSS</div>
          <div class="t2">Validator</div>
          <div class="t3">Error</div>

          <h2>Target: http://www.w3.org/</h2>
          <div class="error">
          <p>Oups! Internal error!</p><p>
          </p></div>
          <hr />
          <p><img src='images/mwcss.gif' alt='made with CSS' /></p>
          <address><a href='Email.html'>www-validator-css</a></address>
          </body></html>

          Show
          Adnan Durrani added a comment - The jar provided on the following link has some errors: http://jigsaw.w3.org/css-validator/DOWNLOAD.html After google, I found out that the jar has some bugs in it, and the code needs to be checkout and fixed by the developer, so I have checkout the src of the css-validator and build it, found some errors. I fixed some path related errors, now it runs but still gives other errors. I think its better to find some other alternate to test the css validity as part of the build. After fixing couple of things, I still get the following error: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\css-validator>java -jar css-validator.jar http://www.w3.org/ {output=text, medium=all, warning=2, profile=css21, lang=en} org.w3c.css.css.XMLStyleSheetHandler: couldn't load catalog.xml no protocol: "jar: file:/D:/work/development/head/svn/ossrepo/icefaces/trunk/icefaces/css-validator/css-validator.jar!/org/w3c/css/util/xml/catalog.xml " 5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log INFO: Velocity not initialized yet. Calling init()... 5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log INFO: FileResourceLoader : adding path '.' 5-Nov-2008 12:36:25 PM org.apache.velocity.runtime.log.JdkLogChute log SEVERE: ResourceManager : unable to find resource 'text.properties' in any resource loader. Unable to find resource 'text.properties' org.apache.velocity.exception.ResourceNotFoundException: Unable to find resource 'text.properties' at org.apache.velocity.runtime.resource.ResourceManagerImpl.loadResource(ResourceManagerImpl.java:452) at org.apache.velocity.runtime.resource.ResourceManagerImpl.getResource(ResourceManagerImpl.java:335) at org.apache.velocity.runtime.RuntimeInstance.getTemplate(RuntimeInstance.java:1102) at org.apache.velocity.runtime.RuntimeInstance.getTemplate(RuntimeInstance.java:1077) at org.apache.velocity.runtime.RuntimeSingleton.getTemplate(RuntimeSingleton.java:303) at org.apache.velocity.app.Velocity.getTemplate(Velocity.java:503) at org.w3c.css.css.StyleSheetGenerator.<init>(StyleSheetGenerator.java:161) at org.w3c.css.css.StyleReportFactory.getStyleReport(StyleReportFactory.java:19) at org.w3c.css.css.CssValidator.handleRequest(CssValidator.java:179) at org.w3c.css.css.CssValidator.main(CssValidator.java:152) java.lang.NullPointerException at org.w3c.css.css.StyleSheetGenerator.print(StyleSheetGenerator.java:419) at org.w3c.css.css.CssValidator.handleRequest(CssValidator.java:192) at org.w3c.css.css.CssValidator.main(CssValidator.java:152) <!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Strict//EN' "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html lang='en' xml:lang='en' xmlns='http://www.w3.org/1999/xhtml'> <head> <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" /> <title>CSS Validator : Error</title> <link type="text/css" rel='stylesheet' href='http://jigsaw.w3.org/css-validator/style/error.css' /> </head> <body> <div> <a href="http://www.w3.org/"><img src="http://www.w3.org/Icons/w3c_home" alt="w3c" /></a> </div> <hr /> <div class="t1">CSS</div> <div class="t2">Validator</div> <div class="t3">Error</div> <h2>Target: http://www.w3.org/ </h2> <div class="error"> <p>Oups! Internal error!</p><p> </p></div> <hr /> <p><img src='images/mwcss.gif' alt='made with CSS' /></p> <address><a href='Email.html'>www-validator-css</a></address> </body></html>
          Hide
          Adnan Durrani added a comment -

          The validation can be tested online using the following URL:
          http://jigsaw.w3.org/css-validator/

          Show
          Adnan Durrani added a comment - The validation can be tested online using the following URL: http://jigsaw.w3.org/css-validator/
          Hide
          Frank Ye added a comment -
          Show
          Frank Ye added a comment - try flute-1.3.jar http://www.ibiblio.org/maven/milyn/jars/flute/1.3/
          Show
          Frank Ye added a comment - parser is here http://mirrors.ibiblio.org/pub/mirrors/maven2/org/w3c/css/sac/1.3/
          Hide
          Adnan Durrani added a comment -

          The incorrect CSS has been fixed and to make the CSS validity part of the build is a separate task, so I am closing this case and created the following new case:
          http://jira.icefaces.org/browse/ICE-3785

          Show
          Adnan Durrani added a comment - The incorrect CSS has been fixed and to make the CSS validity part of the build is a separate task, so I am closing this case and created the following new case: http://jira.icefaces.org/browse/ICE-3785
          Adnan Durrani made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 1.8 [ 10161 ]
          Assignee Priority P1
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Adnan Durrani [ adnan.durrani ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Frank Ye
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: