ICEfaces
  1. ICEfaces
  2. ICE-3695

TreeNode do saveState restoreState

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#1
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      The TreeNode component maintains references to its parent Tree component, and the current DefaultMutableTreeNode. It then tries to save and restore these fields. The Tree reference cannot be saved and restored, since upon restoration the TreeNode's parent would be a new Tree component, not the old one. So, it should probably just look up to its parent, and not even keep a reference. The DefaultMutableTreeNode reference is a hook into the entire tree data model, so we don't want to save this at all, especially since it comes from the bean anyway. The code should be refactored so that the DefaultMutableTreeNode reference is just transient, and not saved away.

        Issue Links

          Activity

          Mark Collette created issue -
          Mark Collette made changes -
          Field Original Value New Value
          Assignee Yip Ng [ yip.ng ]
          Mark Collette made changes -
          Fix Version/s 1.8DR#2 [ 10142 ]
          Assignee Priority P1
          Mark Collette made changes -
          Link This issue blocks ICE-3442 [ ICE-3442 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17835 Mon Oct 27 14:06:15 MDT 2008 yip.ng ICE-3695
          Made parent tree and default mutable tree node fields transient and removed from saveState() and restoreState().
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeNode.java
          Hide
          yip.ng added a comment -

          getTree() changed to search for parent tree every time.

          defaultMutableTreeNode seems to be set every time by the renderer, which in turn gets it from a value binding, therefore no change in getter.

          Both fields marked transient.

          No fields to save anymore, therefore removed saveState() and restoreState().

          Show
          yip.ng added a comment - getTree() changed to search for parent tree every time. defaultMutableTreeNode seems to be set every time by the renderer, which in turn gets it from a value binding, therefore no change in getter. Both fields marked transient. No fields to save anymore, therefore removed saveState() and restoreState().
          yip.ng made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Mark Collette made changes -
          Link This issue blocks ICE-3696 [ ICE-3696 ]
          Ken Fyten made changes -
          Fix Version/s 1.8 [ 10161 ]
          Assignee Priority P1
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Yip Ng [ yip.ng ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Mark Collette
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: