ICEfaces
  1. ICEfaces
  2. ICE-3618

Text components no longer being cleared under compressDOM

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8DR#1
          • Fix Version/s: 1.8DR#2, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            current ICEfaces trunk

            Description

            I'm seeing that Input Text fields aren't being reset on code currently checked into the trunk. There are two places this is visible. In auctionMonitor application, if you type a text message in the chat input text and submit it, the value in the text field is not reset. Also, in the buttons and links section of component-showcase, pressing the reset button does not reset the text value in the form.

              Activity

              Ascending order - Click to sort in descending order
              Greg Dick created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 1.8DR#2 [ 10142 ]
              Fix Version/s 1.8DR#1 [ 10141 ]
              Hide
              Permalink
              Ted Goddard added a comment -

              It is possible that the release method in BridgeFacesContext is no longer necessary:

              if (null != responseWriter && compressDOM)

              { ((DOMResponseWriter) responseWriter).release(); }

              However, without it, it is likely that the DOM will persist in memory until the next request, thereby increasing the working memory required by the application. The fix for this is likely to uncompress the DOM just prior to applyBrowserDOMChanges()

              Show
              Ted Goddard added a comment - It is possible that the release method in BridgeFacesContext is no longer necessary: if (null != responseWriter && compressDOM) { ((DOMResponseWriter) responseWriter).release(); } However, without it, it is likely that the DOM will persist in memory until the next request, thereby increasing the working memory required by the application. The fix for this is likely to uncompress the DOM just prior to applyBrowserDOMChanges()
              Hide
              Permalink
              Ted Goddard added a comment -

              Enable compressDOM in the auctionMonitor web.xml to reproduce:

              <context-param>
              <param-name>com.icesoft.faces.compressDOM</param-name>
              <param-value>true</param-value>
              </context-param>

              Show
              Ted Goddard added a comment - Enable compressDOM in the auctionMonitor web.xml to reproduce: <context-param> <param-name>com.icesoft.faces.compressDOM</param-name> <param-value>true</param-value> </context-param>
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Assignee Adnan Durrani [ adnan.durrani ] Ted Goddard [ ted.goddard ]
              Priority Critical [ 2 ] Major [ 3 ]
              Ken Fyten made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Priority P2
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Comment [ Verified successfully on build 10.. Tomcat6.
              AuctionMonitor with and without state saving
              Component-showcase without state saving.
              ]
              Hide
              Permalink
              Ted Goddard added a comment -

              Verified that this is not fixed. DocumentStore.load() is being called multiple times, thereby over-writing applyBrowserDOMChanges().

              Show
              Ted Goddard added a comment - Verified that this is not fixed. DocumentStore.load() is being called multiple times, thereby over-writing applyBrowserDOMChanges().
              Ted Goddard made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18077 Wed Dec 17 14:06:23 MST 2008 ted.goddard documentStore.save after applyBrowserDOMChanges (ICE-3618)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
              Hide
              Permalink
              Ted Goddard added a comment -

              — src/com/icesoft/faces/context/BridgeFacesContext.java (revision 18074)
              +++ src/com/icesoft/faces/context/BridgeFacesContext.java (working copy)
              @@ -437,6 +437,7 @@
              }
              }
              }
              + documentStore.save(document);
              }

              This fixes the functional aspect of the bug, however there is a redundant call to documentStore.save during user input (first in applyBrowserDOMChanges and again at the end of the cycle). This should be optimized.

              Show
              Ted Goddard added a comment - — src/com/icesoft/faces/context/BridgeFacesContext.java (revision 18074) +++ src/com/icesoft/faces/context/BridgeFacesContext.java (working copy) @@ -437,6 +437,7 @@ } } } + documentStore.save(document); } This fixes the functional aspect of the bug, however there is a redundant call to documentStore.save during user input (first in applyBrowserDOMChanges and again at the end of the cycle). This should be optimized.
              Ted Goddard made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Ted Goddard [ ted.goddard ]
              Hide
              Permalink
              Joanne Bai added a comment -

              ested successfully on ICEFaces 1.8.1 build 1 + Glassfish v2.1 using component-showcase facelets-enh

              Browsers tested: Opera9.64, IE8, FF3

              Show
              Joanne Bai added a comment - ested successfully on ICEFaces 1.8.1 build 1 + Glassfish v2.1 using component-showcase facelets-enh Browsers tested: Opera9.64, IE8, FF3

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: