ICEfaces
  1. ICEfaces
  2. ICE-3550

Scrollable table columns not aligned properly when header rows are used in header facet

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      From forum:

      ICEFaces revision 17609
      JBoss 4.2.2
      Firefox 3
      OpenSuse 11

      Description

      From forum:

      I have downloaded the latest revision from the svn repository (revision 17609) and tried it, especially the bug reported for the version 1.7.1 (issue 3219).

      I realized that if the datatable does not has a header facet with a column group and a header row it works fine, but if the datatable has a header facet with a column group with a header row (or more) it still not working.
      It doesn't matter the complex of the header facet. If it could have several header rows containing columns with colspan and rowspan higher than 1 or just one header row containing columns with colspan and rowspan 1, and it doesn't work.

      Environment:
      ICEFaces revision 17609
      JBoss 4.2.2
      Firefox 3
      OpenSuse 11

      I have attached a small example that shows the problem (the libs aren't in the attach, must be compiled (revision 17609)).
      1. screenshot-1.jpg
        135 kB
      2. screenshot-2.jpg
        127 kB
      3. screenshot-3.jpg
        127 kB

        Activity

        yip.ng created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Ken Fyten [ ken.fyten ]
        Hide
        Krashan Brahmanjara added a comment -

        Complex resolution and patch was submitted in ICE-3515.

        Show
        Krashan Brahmanjara added a comment - Complex resolution and patch was submitted in ICE-3515 .
        Ken Fyten made changes -
        Fix Version/s 1.8DR#2 [ 10142 ]
        Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
        made changes -
        Attachment screenshot-1.jpg [ 11293 ]
        Hide
        yip.ng added a comment -

        See screenshot-1 for the alignment problem.

        Show
        yip.ng added a comment - See screenshot-1 for the alignment problem.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17792 Mon Oct 20 16:26:05 MDT 2008 yip.ng ICE-3550
        Fixed column alignment problems in scrollable table with header rows, with patch submitted by Krashan Brahmanjara.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/dataTable.js
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TableRenderer.java
        made changes -
        Attachment screenshot-2.jpg [ 11295 ]
        Hide
        yip.ng added a comment -

        Patch applied as contributed by Krashan Brahmanjara. See screenshot-2 for the result.

        Show
        yip.ng added a comment - Patch applied as contributed by Krashan Brahmanjara. See screenshot-2 for the result.
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Lele Man added a comment -

        I think the issue was misunderstood, when i posted this in the forum i was trying to say that the table wasn't working fine because it displays the horizontal scrollbar when it shouldn't. And watching the screenshot-2 when it supposed to be fixed, it still has the same problem. The 3 tables should display without horizontal scrollbar, like the topmost one.

        Show
        Lele Man added a comment - I think the issue was misunderstood, when i posted this in the forum i was trying to say that the table wasn't working fine because it displays the horizontal scrollbar when it shouldn't. And watching the screenshot-2 when it supposed to be fixed, it still has the same problem. The 3 tables should display without horizontal scrollbar, like the topmost one.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17808 Tue Oct 21 16:33:48 MDT 2008 yip.ng ICE-3550
        Fixed column alignment problems in scrollable table with header rows, with patch submitted by Krashan Brahmanjara.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
        yip.ng made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        made changes -
        Attachment screenshot-3.jpg [ 11298 ]
        Hide
        yip.ng added a comment -

        Fixed. See screenshot-3. Note that because there is a default padding of 5px for a table cell, you need to reduce the width of the 3rd column of the the 3rd table by 10px:

        <ice:column style="width: 140px">
        <ice:panelGroup style="width: 140px">
        <ice:outputText value="#

        {entry.c}

        "/>
        </ice:panelGroup>
        </ice:column>

        Show
        yip.ng added a comment - Fixed. See screenshot-3. Note that because there is a default padding of 5px for a table cell, you need to reduce the width of the 3rd column of the the 3rd table by 10px: <ice:column style="width: 140px"> <ice:panelGroup style="width: 140px"> <ice:outputText value="# {entry.c} "/> </ice:panelGroup> </ice:column>
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            yip.ng
          • Votes:
            4 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: