[ICE-3528] InputTextarea, inputSecret, selectInputText improperly handling boolean passthrough attributes - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7.2
Fix Version/s: 1.7.2
Component/s: ICE-Components
Labels:
None
Environment:
Unknown

ICEsoft Forum Reference:
http://www.icefaces.org/JForum/posts/list/9652.page#40320

Description

From the forum user chrishantha:
With InputTextarea and InputSecret, readonly and disabled are not rendered.
With SelectInputText, even if the input is readonly, I can get the value list and select a value.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All
- Manage Attachments

Attachments

RadioRenderer.java

21/Sep/08 2:30 PM

9 kB

Krashan Brahmanjara
RadioRenderer.java

22/Sep/08 8:12 AM

9 kB

Krashan Brahmanjara

screenshot-1.jpg

285 kB

17/Sep/08 11:17 AM
screenshot-2.jpg

303 kB

17/Sep/08 12:14 PM
screenshot-3.jpg

279 kB

17/Sep/08 6:43 PM

Activity

Ascending order - Click to sort in descending order

Mark Collette created issue - 12/Sep/08 5:14 PM

Mark Collette made changes - 12/Sep/08 5:14 PM

Field	Original Value	New Value
Fix Version/s		1.7.2 [ 10130 ]
Assignee Priority		P2
Assignee		Mark Collette [ mark.collette ]

Hide

Permalink

Krashan Brahmanjara added a comment - 13/Sep/08 1:04 PM

Patch for ice:inputtextarea was submitted in attachment to ~~ICE-3514~~

Show

Krashan Brahmanjara added a comment - 13/Sep/08 1:04 PM Patch for ice:inputtextarea was submitted in attachment to ICE-3514

Ken Fyten made changes - 16/Sep/08 4:12 PM

Assignee

Mark Collette [ mark.collette ]

Yip Ng [ yip.ng ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17594	Tue Sep 16 17:08:42 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextareaRenderer.java MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TextareaRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17595	Tue Sep 16 17:10:11 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextareaRenderer.java

Hide

Permalink

Isuru Perera added a comment - 16/Sep/08 10:15 PM

SelectOneMenu also doesn't handle pass through boolean attributes

Show

Isuru Perera added a comment - 16/Sep/08 10:15 PM SelectOneMenu also doesn't handle pass through boolean attributes

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17599	Wed Sep 17 10:22:29 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/SecretRenderer.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SecretRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17600	Wed Sep 17 10:23:12 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SecretRenderer.java

made changes - 17/Sep/08 11:17 AM

Attachment

screenshot-1.jpg [ 11248 ]

made changes - 17/Sep/08 12:14 PM

Attachment

screenshot-2.jpg [ 11249 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17603	Wed Sep 17 16:12:54 MDT 2008	yip.ng	~~ICE-3528~~ Changed to not include onkeypress submit event or popup list when input field is disabled or readonly.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputText.java MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17604	Wed Sep 17 16:14:44 MDT 2008	yip.ng	~~ICE-3528~~ Changed to not include onkeypress submit event or popup list when input field is disabled or readonly.
				Files Changed
				MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputText.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17605	Wed Sep 17 16:43:39 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#17606	Wed Sep 17 16:45:13 MDT 2008	yip.ng	~~ICE-3528~~ Added rendering of disabled and readonly attributes.
				Files Changed
				MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java

made changes - 17/Sep/08 6:43 PM

Attachment

screenshot-3.jpg [ 11250 ]

yip.ng made changes - 18/Sep/08 11:17 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 21/Sep/08 2:28 PM

Not fixed yet.

You forget about ice:selectOneRadio and ice:radio relations.

For example In spread mode I see that radio's disable/readonly doesn't work. In current version every radio item must by disabled by hand.

Child radio's should be disabled by parent selectOneRadio tag attribute's.

In attachment file \core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java with patch (lines signed by //byrt )

Show

Krashan Brahmanjara added a comment - 21/Sep/08 2:28 PM Not fixed yet. You forget about ice:selectOneRadio and ice:radio relations. For example In spread mode I see that radio's disable/readonly doesn't work. In current version every radio item must by disabled by hand. Child radio's should be disabled by parent selectOneRadio tag attribute's. In attachment file \core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java with patch (lines signed by //byrt )

Hide

Permalink

Krashan Brahmanjara added a comment - 21/Sep/08 2:30 PM

Patch for ice:selectOneRadio / ice:radio. Radio item's should be disabled by parent component.

Show

Krashan Brahmanjara added a comment - 21/Sep/08 2:30 PM Patch for ice:selectOneRadio / ice:radio. Radio item's should be disabled by parent component.

Krashan Brahmanjara made changes - 21/Sep/08 2:30 PM

Attachment

RadioRenderer.java [ 11253 ]

Hide

Permalink

Krashan Brahmanjara added a comment - 22/Sep/08 3:44 AM

Another suggestion
In file com.icesoft.faces.renderkit.dom_html_basic.InputTextRenderer.java, line 42, null may be instead new String[0].

PassThruAttributeWriter.renderBooleanAttributes(
writer,
uiComponent,
null /new String[0]/ );

Show

Krashan Brahmanjara added a comment - 22/Sep/08 3:44 AM Another suggestion In file com.icesoft.faces.renderkit.dom_html_basic.InputTextRenderer.java, line 42, null may be instead new String [0] . PassThruAttributeWriter.renderBooleanAttributes( writer, uiComponent, null / new String [0] / );

Hide

Permalink

Krashan Brahmanjara added a comment - 22/Sep/08 8:11 AM

Update from revision 17586 to 17613 will change behaviour of ice:radio. i see two another bugs

readonly are not aplplied to each ice:radio
initial values are not passed and checked attribute are not set

Patch

around line 154 is
< Object[] submittedValue = getSubmittedSelectedValues(uiComponent);
< Object componentValue = (submittedValue != null) ? null :
< getCurrentSelectedValues(uiComponent);
< UISelectOne selectOne = (UISelectOne) forComponent;

instead component items should be analized

> UISelectOne selectOne = (UISelectOne) forComponent;
> Object[] submittedValue = getSubmittedSelectedValues(selectOne);
> Object componentValue = (submittedValue != null) ? null :
> getCurrentSelectedValues(selectOne);

Readonly attributes can be added around line 195 as below

> Boolean readonly = (Boolean) selectOne.getAttributes().get(HTML.READONLY_ATTR);
> if (readonly != null && readonly.booleanValue())

{ > input.setAttribute(HTML.READONLY_ATTR, HTML.READONLY_ATTR); > }

> Boolean disabled = (Boolean) selectOne.getAttributes().get(HTML.DISABLED_ATTR);
< if (selectItem.isDisabled()) {
> if (selectItem.isDisabled() || (disabled != null && disabled.booleanValue()))

{ input.setAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR); }

Show

Krashan Brahmanjara added a comment - 22/Sep/08 8:11 AM Update from revision 17586 to 17613 will change behaviour of ice:radio. i see two another bugs readonly are not aplplied to each ice:radio initial values are not passed and checked attribute are not set Patch around line 154 is < Object[] submittedValue = getSubmittedSelectedValues(uiComponent); < Object componentValue = (submittedValue != null) ? null : < getCurrentSelectedValues(uiComponent); < UISelectOne selectOne = (UISelectOne) forComponent; instead component items should be analized > UISelectOne selectOne = (UISelectOne) forComponent; > Object[] submittedValue = getSubmittedSelectedValues(selectOne); > Object componentValue = (submittedValue != null) ? null : > getCurrentSelectedValues(selectOne); Readonly attributes can be added around line 195 as below > Boolean readonly = (Boolean) selectOne.getAttributes().get(HTML.READONLY_ATTR); > if (readonly != null && readonly.booleanValue()) { > input.setAttribute(HTML.READONLY_ATTR, HTML.READONLY_ATTR); > } > Boolean disabled = (Boolean) selectOne.getAttributes().get(HTML.DISABLED_ATTR); < if (selectItem.isDisabled()) { > if (selectItem.isDisabled() || (disabled != null && disabled.booleanValue())) { input.setAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR); }

Hide

Permalink

Krashan Brahmanjara added a comment - 22/Sep/08 8:12 AM

Final patch for RadioRenderer, adds READONLY and CHECKED attributes

Show

Krashan Brahmanjara added a comment - 22/Sep/08 8:12 AM Final patch for RadioRenderer, adds READONLY and CHECKED attributes

Krashan Brahmanjara made changes - 22/Sep/08 8:12 AM

Attachment

RadioRenderer.java [ 11255 ]

Hide

Permalink

Isuru Perera added a comment - 25/Sep/08 5:14 AM

HtmlCommandButton also doesn't handle pass through boolean attributes

Show

Isuru Perera added a comment - 25/Sep/08 5:14 AM HtmlCommandButton also doesn't handle pass through boolean attributes

Ken Fyten made changes - 27/Oct/08 3:46 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2
Assignee	Yip Ng [ yip.ng ]

People

Assignee:

Unassigned

Reporter:

Mark Collette

Votes:

2 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

12/Sep/08 5:14 PM

Updated:

27/Oct/08 3:46 PM

Resolved:

18/Sep/08 11:17 AM