Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7.1
-
Component/s: Framework
-
Labels:None
-
Environment:Facelets
-
Support Case References:
Description
Here is a description of the issue based on the attached test case:
A message is being added to the faces context in a phase listener (TestPhaseListener.java):
public void beforePhase(PhaseEvent arg0) {
logger.info("before:" + arg0.getPhaseId());
if (arg0.getPhaseId().equals(PhaseId.APPLY_REQUEST_VALUES)) {
arg0.getFacesContext().addMessage("global",new FacesMessage( FacesMessage.SEVERITY_ERROR, "error", "error"));
}
The page contains a panelTabSet that includes a nested tabSet along with ui:composition's. In the inner most ui:composition is where the message is being rendered (TabChangeTemplate.xhtml):
<ice:panelGroup id="enclosingFormData">
<ice:panelGroup>
<ice:messages id="myMessage1" showDetail="true" showSummary="false"/>
</ice:panelGroup>
<ui:insert/>
</ice:panelGroup>
</ui:composition>
However, this configuration causes a duplicate message to be displayed under the panelTabSet. This issue can only be reproduce when clicking for the first time from the first tab to the second tab. All subsequent tab changes do not exhibit this behavior. Attached are screenshots and a test case.
A message is being added to the faces context in a phase listener (TestPhaseListener.java):
public void beforePhase(PhaseEvent arg0) {
logger.info("before:" + arg0.getPhaseId());
if (arg0.getPhaseId().equals(PhaseId.APPLY_REQUEST_VALUES)) {
arg0.getFacesContext().addMessage("global",new FacesMessage( FacesMessage.SEVERITY_ERROR, "error", "error"));
}
The page contains a panelTabSet that includes a nested tabSet along with ui:composition's. In the inner most ui:composition is where the message is being rendered (TabChangeTemplate.xhtml):
<ice:panelGroup id="enclosingFormData">
<ice:panelGroup>
<ice:messages id="myMessage1" showDetail="true" showSummary="false"/>
</ice:panelGroup>
<ui:insert/>
</ice:panelGroup>
</ui:composition>
However, this configuration causes a duplicate message to be displayed under the panelTabSet. This issue can only be reproduce when clicking for the first time from the first tab to the second tab. All subsequent tab changes do not exhibit this behavior. Attached are screenshots and a test case.
-
Hide
-
-
META-INF/MANIFEST.MF
-
WEB-INF/classes/.../TestPhaseListener.class
-
WEB-INF/classes/log4j.xml
-
WEB-INF/faces-config.xml
-
WEB-INF/lib/backport-util-concurrent.jar
-
WEB-INF/lib/commons-beanutils.jar
-
WEB-INF/lib/commons-collections.jar
-
WEB-INF/lib/commons-digester.jar
-
WEB-INF/lib/commons-discovery.jar
-
WEB-INF/lib/commons-el.jar
-
WEB-INF/lib/commons-fileupload.jar
-
WEB-INF/lib/commons-lang.jar
-
WEB-INF/lib/commons-logging-api.jar
-
WEB-INF/lib/commons-logging.jar
-
WEB-INF/lib/el-api.jar
-
WEB-INF/lib/el-ri.jar
-
WEB-INF/lib/icefaces-comps.jar
-
WEB-INF/lib/icefaces-facelets.jar
-
WEB-INF/lib/icefaces.jar
-
WEB-INF/lib/jsf-api.jar
-
WEB-INF/lib/jsf-impl.jar
-
WEB-INF/lib/xercesImpl.jar
-
WEB-INF/lib/xml-apis.jar
-
WEB-INF/web.xml
-
index.jsp
-
index.xhtml
-
page1.xhtml
-
page2.xhtml
-
secondlevel.xhtml
-
secure/template/.../tabPageTemplate.xhtml
-
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
A message is being added to the faces context in a phase listener (TestPhaseListener.java): public void beforePhase(PhaseEvent arg0) { logger.info("before:" + arg0.getPhaseId()); if (arg0.getPhaseId().equals(PhaseId.APPLY_REQUEST_VALUES)) { arg0.getFacesContext().addMessage("global",new FacesMessage( FacesMessage.SEVERITY_ERROR, "error", "error")); } The page contains a panelTabSet that includes a nested tabSet along with some tabs including ui:composition's. In the inner most ui:composition is where the message is being rendered (TabChangeTemplate.xhtml): <ice:panelGroup id="enclosingFormData"> <ice:panelGroup> <ice:messages id="myMessage1" showDetail="true" showSummary="false"/> </ice:panelGroup> <ui:insert/> </ice:panelGroup> </ui:composition> However, this configuration causes a duplicate message to be displayed under the panelTabSet. This issue can also only be reproduce when clicking for the first time from the first tab to the second tab. All subsequent tab changes do not exhibit this behavior. Attached are screenshots and a test case. |
Here is a description of the issue based on the attached test case: A message is being added to the faces context in a phase listener (TestPhaseListener.java): public void beforePhase(PhaseEvent arg0) { logger.info("before:" + arg0.getPhaseId()); if (arg0.getPhaseId().equals(PhaseId.APPLY_REQUEST_VALUES)) { arg0.getFacesContext().addMessage("global",new FacesMessage( FacesMessage.SEVERITY_ERROR, "error", "error")); } The page contains a panelTabSet that includes a nested tabSet along with ui:composition's. In the inner most ui:composition is where the message is being rendered (TabChangeTemplate.xhtml): <ice:panelGroup id="enclosingFormData"> <ice:panelGroup> <ice:messages id="myMessage1" showDetail="true" showSummary="false"/> </ice:panelGroup> <ui:insert/> </ice:panelGroup> </ui:composition> However, this configuration causes a duplicate message to be displayed under the panelTabSet. This issue can only be reproduce when clicking for the first time from the first tab to the second tab. All subsequent tab changes do not exhibit this behavior. Attached are screenshots and a test case. |
| Support Case References | https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=5119 |
| Attachment | screenshot-incorrect.jpg [ 11185 ] |
| Attachment | SC_5119.war [ 11186 ] |
| Environment | All | Facelets |
| Summary | ice:messages printing duplicates | ice:messages component causing duplicate rendering |
| Fix Version/s | 1.7.2 [ 10130 ] | |
| Assignee Priority | P3 | |
| Assignee | Mark Collette [ mark.collette ] | |
| Priority | Major [ 3 ] | Minor [ 4 ] |
| Fix Version/s | 1.7.2 [ 10130 ] |
| Fix Version/s | 1.8DR#2 [ 10142 ] | |
| Assignee Priority | P3 | P1 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #18019 | Wed Dec 10 16:01:42 MST 2008 | mark.collette | |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMContext.java
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessagesRenderer.java
|
There was some negotiation between the FormRenderer and the MessagesRenderer, to allow an HtmlMessages component to render again, after all the other components in the form had rendered. The flag to do so wasn't being cleared properly, resulting in an HtmlMessages from one lifecycle, that had rendered again later, to still be trying to render again in the next lifecycle, even though it shouldn't even be displayed. Since it wasn't being displayed, it had no idea where to properly render, so it was just rendering inside the end of the form element. A second messages component, that should be displayed, was correctly rendering its messages in the correct location. And that is how we were getting duplicate rendered messages.
Subversion 18019
icefaces\core\src\com\icesoft\faces\context\DOMContext.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\MessagesRenderer.java
Show
Mark Collette
added a comment - There was some negotiation between the FormRenderer and the MessagesRenderer, to allow an HtmlMessages component to render again, after all the other components in the form had rendered. The flag to do so wasn't being cleared properly, resulting in an HtmlMessages from one lifecycle, that had rendered again later, to still be trying to render again in the next lifecycle, even though it shouldn't even be displayed. Since it wasn't being displayed, it had no idea where to properly render, so it was just rendering inside the end of the form element. A second messages component, that should be displayed, was correctly rendering its messages in the correct location. And that is how we were getting duplicate rendered messages.
Subversion 18019
icefaces\core\src\com\icesoft\faces\context\DOMContext.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\MessagesRenderer.java
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #18057 | Mon Dec 15 15:45:08 MST 2008 | mark.collette | |
| Files Changed | ||||
|
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/DOMContext.java
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessagesRenderer.java
|
Ported the fix to the ICEfaces 1.7 branch.
Subversion 18057
icefaces\core\src\com\icesoft\faces\context\DOMContext.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\MessagesRenderer.java
Show
Mark Collette
added a comment - Ported the fix to the ICEfaces 1.7 branch.
Subversion 18057
icefaces\core\src\com\icesoft\faces\context\DOMContext.java
icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\MessagesRenderer.java
| Fix Version/s | 1.8 [ 10161 ] | |
| Assignee Priority | P1 |
Confirm fix with success on 1.7.2-SP2 build 3
Tested on Tomcat 6 + FF2 and IE6
Show
Joanne Bai
added a comment - Confirm fix with success on 1.7.2-SP2 build 3
Tested on Tomcat 6 + FF2 and IE6
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee | Mark Collette [ mark.collette ] |
Ready for deployment on tomcat 5.5.