ICEfaces
  1. ICEfaces
  2. ICE-3424

ICEfaces 1.7.1 not compatible with JSF version 1.2_09

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Critical Critical
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.7.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 1.7.1 and JSF 1.2_09

            Description

            An incompatibility between ICEfaces and JSF 1.2_09 exists. Users are reporting blank pages showing up in rendering phases.

              Issue Links

              depends on

              Bug - A problem which impairs or prevents the functions of the product. ICE-3664 Component attribute state overwritten with webflow1.0.x

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Greg Dick created issue -
                Greg Dick made changes -
                Field Original Value New Value
                Summary ICEfaces 1.7,1 not compatible with JSF version 1.2_09 ICEfaces 1.7.1 not compatible with JSF version 1.2_09
                Greg Dick made changes -
                Assignee Greg Dick [ greg.dick ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Affects [Compatibility/Configuration]
                Assignee Priority P2
                Priority Major [ 3 ] Critical [ 2 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17377 Wed Aug 20 15:14:41 MDT 2008 greg.dick ICE-3424 on a page reload, allow the ViewRoot property to be cleared.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17378 Wed Aug 20 15:15:27 MDT 2008 greg.dick ICE-3424 on a page reload clear the preserved viewRoot in the FacesContext instance
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17379 Wed Aug 20 15:23:51 MDT 2008 greg.dick ICE-3424 on a page reload, allow the ViewRoot property to be cleared.
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17380 Wed Aug 20 15:24:25 MDT 2008 greg.dick ICE-3424 on a page reload clear the preserved viewRoot in the FacesContext instance
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/View.java
                Hide
                Permalink
                Greg Dick added a comment -

                In the JSF RestoreViewPhase implementation there are a couple of paths of execution. If the UIViewRoot is stored in the FacesContext implementation, that object is used and restoreView/createView are never called. If the request is deemed to be a postback, this UIViewRoot is used for the rest of the lifecycle.

                If the request is not deemed to be a postback, the responseComplete flag is set in the facesContext. This will prevent any further processing being done on the lifecycle, including rendering. This is the nature of the problem. We have knowledge of what type of request is incoming and this allows us to clear the viewRoot instance from the FacesContext. Our use of the perisistent FacesContext is the root of the difficulty. We preserve some of its state if a non-faces request is used in a redirect, but we don't if the non-faces request is part of a page reload.

                I've made some changes to the View and to the BridgeFacesContext, and am in the process of checking for regressions.

                Show
                Greg Dick added a comment - In the JSF RestoreViewPhase implementation there are a couple of paths of execution. If the UIViewRoot is stored in the FacesContext implementation, that object is used and restoreView/createView are never called. If the request is deemed to be a postback, this UIViewRoot is used for the rest of the lifecycle. If the request is not deemed to be a postback, the responseComplete flag is set in the facesContext. This will prevent any further processing being done on the lifecycle, including rendering. This is the nature of the problem. We have knowledge of what type of request is incoming and this allows us to clear the viewRoot instance from the FacesContext. Our use of the perisistent FacesContext is the root of the difficulty. We preserve some of its state if a non-faces request is used in a redirect, but we don't if the non-faces request is part of a page reload. I've made some changes to the View and to the BridgeFacesContext, and am in the process of checking for regressions.
                Ken Fyten made changes -
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Fix Version/s 1.7.2 [ 10130 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17548 Thu Sep 11 10:14:09 MDT 2008 mircea.toma ICE-3424, ICE-3477, ICE-3479 Bypass JSF lifecycle on forced page load.
                Files Changed
                Commit graph DEL /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/PageServer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/SingleViewServer.java
                Commit graph ADD /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/NoCacheContentHandler.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17549 Thu Sep 11 10:22:44 MDT 2008 mircea.toma ICE-3424, ICE-3477, ICE-3479 Bypass JSF lifecycle on forced page load.
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/SingleViewServer.java
                Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/PageServer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java
                Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/NoCacheContentHandler.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/View.java
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17571 Sat Sep 13 04:38:25 MDT 2008 mircea.toma ICE-3424, ICE-3477, ICE-3479 Clear ViewRoot on non-postback requests.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17572 Sat Sep 13 04:39:03 MDT 2008 mircea.toma ICE-3424, ICE-3477, ICE-3479 Clear ViewRoot on non-postback requests.
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
                Ken Fyten made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Assignee Priority P2
                Resolution Fixed [ 1 ]
                Errorken Errorken made changes -
                Link This issue depends on ICE-3664 [ ICE-3664 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Greg Dick [ greg.dick ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Greg Dick
                  • Votes:
                    8 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: