ICEfaces
  1. ICEfaces
  2. ICE-3374

Add partialSubmit attribute to selectInputText

          Details

            Description

            Currently, when an item from the drop down is selected the selectInputText fires a full submit event. This makes it difficult to use the component in a form with other required input components, as the full submit will fire the required validation for the other components.

            suggested fix:

            ### Eclipse Workspace Patch 1.0
            #P ICEfaces-ossrepo
            Index: bridge/lib/extras/autocomplete_ext.js
            ===================================================================
            --- bridge/lib/extras/autocomplete_ext.js (revision 17263)
            +++ bridge/lib/extras/autocomplete_ext.js (working copy)
            @@ -591,8 +591,8 @@
                     var form = Ice.util.findForm(this.element);
                     // form.focus_hidden_field.value=this.element.id;
                     if (isEnterKey) {
            - Ice.Autocompleter.logger.debug("Sending submit");
            - iceSubmit(form, this.element, event);
            + Ice.Autocompleter.logger.debug("Sending partial submit for enter key");
            + iceSubmitPartial(form, this.element, event);
                     }
                     else {
                         Ice.Autocompleter.logger.debug("Sending partial submit");

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Philip Breau added a comment -

              patch

              Show
              Philip Breau added a comment - patch
              Hide
              Permalink
              Stephan Anft added a comment -

              Works nice. Wouldn't it make sense to let the "partialSubmit" attribute control whether a partial or full submit is triggered by the Javascript?

              Show
              Stephan Anft added a comment - Works nice. Wouldn't it make sense to let the "partialSubmit" attribute control whether a partial or full submit is triggered by the Javascript?
              Hide
              Permalink
              Vasanth Dharmaraj added a comment -

              Are there any plans to apply this patch? It has been more than a year since this issue was opened.

              Show
              Vasanth Dharmaraj added a comment - Are there any plans to apply this patch? It has been more than a year since this issue was opened.
              Hide
              Permalink
              Night Scorpion added a comment -

              Is there any alternative solution to this problem or can i expect to see this bug resolved in the near future?

              Show
              Night Scorpion added a comment - Is there any alternative solution to this problem or can i expect to see this bug resolved in the near future?
              Hide
              Permalink
              Michael Mesiti added a comment -

              Has it been fixed in the latest release of Icefaces 2?

              Show
              Michael Mesiti added a comment - Has it been fixed in the latest release of Icefaces 2?
              Hide
              Permalink
              yip.ng added a comment -

              Applied.

              Revision: 24601

              Modified : /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js

              Revision: 24602

              Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

              Revision: 24603

              Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js

              Show
              yip.ng added a comment - Applied. Revision: 24601 Modified : /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js Revision: 24602 Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js Revision: 24603 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js
              Hide
              Permalink
              yip.ng added a comment -

              From Ken:

              I think having the partialSubmit attribute determine whether the selection was a partialSubmit or not makes sense.

              Show
              yip.ng added a comment - From Ken: I think having the partialSubmit attribute determine whether the selection was a partialSubmit or not makes sense.
              Hide
              Permalink
              yip.ng added a comment -

              Changed to check partial submit flag as well.

              Revision: 24605

              Modified : /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js
              Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java

              Revision: 24606

              Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
              Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

              Revision: 24607

              Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
              Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js

              Show
              yip.ng added a comment - Changed to check partial submit flag as well. Revision: 24605 Modified : /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Revision: 24606 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js Revision: 24607 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Philip Breau
                • Votes:
                  14 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: