ICEfaces
  1. ICEfaces
  2. ICE-3346

Pass-through Attribute Optimization and Rationalization

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Passthru attributes

            Description

            Improve passThru attributes rendering

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3082 CPU performance/efficiency

              • Major - Major loss of function.
              • Closed
              depends on

              Bug - A problem which impairs or prevents the functions of the product. ICE-3373 jsf 12 baseline "dir" "lang" attributes for text base comp

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17233 Fri Jul 25 12:02:55 MDT 2008 adnan.durrani Fix for ICE-3346 (Improve passThru attributes rendering)
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputprogress/OutputProgressRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelstack/PanelStackRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuBarRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/OutputMessageRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CheckboxRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextRenderer.java
                Adnan Durrani created issue -
                Adnan Durrani made changes -
                Field Original Value New Value
                Assignee Adnan Durrani [ adnan.durrani ]
                Adnan Durrani made changes -
                Summary Imporve passThru attributes rendering Improve passThru attributes rendering
                Description Imporve passThru attributes rendering Improve passThru attributes rendering
                Adnan Durrani made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                revision 17233.
                List has been replaced with sorted array and some stale code has been removed from the different renderers.

                Show
                Adnan Durrani added a comment - revision 17233. List has been replaced with sorted array and some stale code has been removed from the different renderers.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17243 Mon Jul 28 11:32:51 MDT 2008 adnan.durrani Fix for ICE-3346 (Improve passThru attributes rendering)
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/RendererUtil.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Hide
                Permalink
                Adnan Durrani added a comment -

                revision: 17243
                The com.icesoft.faces.renderkit.dom_html_basic.PassThruAttributeRenderer has been changed, There are two code paths added. The first one look for if the supportedPassThru attribute list is defined on the component, if so then iterate through the supported attributes list else iterate through the list of all possible passThru attribute list.

                So in the components we just need to define an array of supported passThru attributes and it must needs to have a getter with the following name. This array should not have any effect related attribute.

                private static String[] supportedPassThru =

                { "title", "dir", "lang", "style" }

                ;

                public String[] getSupportedPassThru()

                { return supportedPassThru; }
                Show
                Adnan Durrani added a comment - revision: 17243 The com.icesoft.faces.renderkit.dom_html_basic.PassThruAttributeRenderer has been changed, There are two code paths added. The first one look for if the supportedPassThru attribute list is defined on the component, if so then iterate through the supported attributes list else iterate through the list of all possible passThru attribute list. So in the components we just need to define an array of supported passThru attributes and it must needs to have a getter with the following name. This array should not have any effect related attribute. private static String[] supportedPassThru = { "title", "dir", "lang", "style" } ; public String[] getSupportedPassThru() { return supportedPassThru; }
                Adnan Durrani made changes -
                Summary Improve passThru attributes rendering Pass-through Attribute Optimization and Rationalization
                Adnan Durrani made changes -
                Assignee Adnan Durrani [ adnan.durrani ] Frank Ye [ frank.ye ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17267 Thu Jul 31 13:23:02 MDT 2008 frank.ye ICE-3346 add AttributeConstants, add renderHtmlAttributes method for Renderer.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Commit graph ADD /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17273 Fri Aug 01 08:22:52 MDT 2008 frank.ye ICE-3346 validate integer sentinel value
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17274 Fri Aug 01 11:41:54 MDT 2008 frank.ye ICE-3346 update attributeConstants according to TLD
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17277 Fri Aug 01 13:35:59 MDT 2008 frank.ye ICE-3346 change inputTextRenderer
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeWriter.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/InputTextRender.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17282 Tue Aug 05 07:51:58 MDT 2008 frank.ye ICE-3346 attributeConstants for H:
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17283 Tue Aug 05 07:52:28 MDT 2008 frank.ye ICE-3346 ExtendedAttributeConstants for ICE:
                Files Changed
                Commit graph ADD /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17284 Tue Aug 05 08:15:10 MDT 2008 frank.ye ICE-3346 remove reference to ICE_COMPONENT
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/OutputTextRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/InputTextRender.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17285 Tue Aug 05 12:23:09 MDT 2008 frank.ye ICE-3346 update TableRenderer passThruAttribute list
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TableRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17286 Tue Aug 05 12:54:59 MDT 2008 frank.ye ICE-3346 update FormRenderer passThruAttribute list
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17287 Tue Aug 05 13:19:19 MDT 2008 frank.ye ICE-3346 update ImageRenderer passThruAttribute list
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ImageRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17288 Tue Aug 05 14:09:29 MDT 2008 frank.ye ICE-3346 update ImageRenderer to handle ismap
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ImageRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17289 Tue Aug 05 14:23:38 MDT 2008 frank.ye ICE-3346 update SecretRenderer passThruAttributes
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SecretRenderer.java
                Hide
                Permalink
                Frank Ye added a comment -

                Documented Approach:

                The Helper class will be separated into two AttributeConstants H: and ExtendedAttributeConstants ICE:. H: does not change over time. Each ICE: needs a new one. This helps with build cycle.

                com.icesoft.faces.components.AttributeConstants
                com.icesoft.faces.components.ExtendedAttributeConstants

                Pass thru attributes:

                A list of attributes from w3c html attributes where component has concrete implementation, the attribute in the list doe not need to handled specifically. the attribute contain String and integer type only, no other types.

                Coding style with PassThruAttributes in Renderer, the following suggestion as a format (not only for Performance, but also as coding style to avoid further confusion). This includes using the entire list as well.

                Each Renderer if required to output PassThruAttributes.

                For example:

                //private static final String[] passThruAttributes = AttributeConstants.getAttributes(AttributeCOnstants.H_COMMANDBUTTON);
                //handled "type",
                private static final String[] passThruAttributes = new String

                {"","",""}

                ;

                handle specific code. getType outout
                PassThruAttributeRenderer.renderHtmlAttributes(facesContext, uiComponent, passThruAttributes);

                Show
                Frank Ye added a comment - Documented Approach: The Helper class will be separated into two AttributeConstants H: and ExtendedAttributeConstants ICE:. H: does not change over time. Each ICE: needs a new one. This helps with build cycle. com.icesoft.faces.components.AttributeConstants com.icesoft.faces.components.ExtendedAttributeConstants Pass thru attributes: A list of attributes from w3c html attributes where component has concrete implementation, the attribute in the list doe not need to handled specifically. the attribute contain String and integer type only, no other types. Coding style with PassThruAttributes in Renderer, the following suggestion as a format (not only for Performance, but also as coding style to avoid further confusion). This includes using the entire list as well. Each Renderer if required to output PassThruAttributes. For example: //private static final String[] passThruAttributes = AttributeConstants.getAttributes(AttributeCOnstants.H_COMMANDBUTTON); //handled "type", private static final String[] passThruAttributes = new String {"","",""} ; handle specific code. getType outout PassThruAttributeRenderer.renderHtmlAttributes(facesContext, uiComponent, passThruAttributes);
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17292 Wed Aug 06 08:28:14 MDT 2008 frank.ye ICE-3346 update AttributeConstants with HTML attribute constants
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/HTML.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17293 Wed Aug 06 08:28:36 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants with HTML attribute constants
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17294 Wed Aug 06 09:17:31 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants with HTML attribute constants
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17297 Wed Aug 06 12:54:21 MDT 2008 frank.ye ICE-3346 update Renderer with passThruAttributes
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextareaRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/OutputLinkRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/LabelRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessageRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/BaseRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/OutputMessageRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessagesRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/InputTextRender.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17298 Wed Aug 06 14:26:47 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants with jsf 12 base
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17306 Thu Aug 07 11:51:32 MDT 2008 mark.collette ICE-3346 : Pass-through Attribute Optimization and Rationalization
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/DomBasicRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17315 Fri Aug 08 10:02:11 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/OutputHeadRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17316 Fri Aug 08 10:29:21 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants and test case with it
                Files Changed
                Commit graph ADD /icefaces/trunk/icefaces/component/test/java/com/icesoft/faces/metadata/AttributeConstantsTest.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17317 Fri Aug 08 10:48:49 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputmedia/OutputMediaRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17318 Fri Aug 08 12:47:48 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/portlet/PortletRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17319 Fri Aug 08 12:57:55 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputprogress/OutputProgressRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17320 Fri Aug 08 13:44:38 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ButtonRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/ButtonRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17321 Fri Aug 08 14:18:38 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ButtonRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17322 Fri Aug 08 15:22:32 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17323 Fri Aug 08 15:51:07 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputprogress/OutputProgressRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuBarRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17324 Fri Aug 08 16:37:36 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/OutputBodyRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17325 Mon Aug 11 09:51:04 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputchart/OutputChartRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17326 Mon Aug 11 10:00:27 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17327 Mon Aug 11 10:08:31 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants and test case where type attribute removed from CommandButton and OutputChart
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/test/java/com/icesoft/faces/metadata/AttributeConstantsTest.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17328 Mon Aug 11 10:17:15 MDT 2008 yip.ng ICE-3346
                Pass-through attributes optimization.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17329 Mon Aug 11 11:03:44 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants and test case where autocomplete removed. size in select one and select many component removed.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/test/java/com/icesoft/faces/metadata/AttributeConstantsTest.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17333 Tue Aug 12 09:00:45 MDT 2008 adnan.durrani Fix related to ICE-3346 (Pass-through Attribute Optimization and Rationalization) AttributeConstants used.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17334 Tue Aug 12 09:26:48 MDT 2008 adnan.durrani Fix related to ICE-3346 (Pass-through Attribute Optimization and Rationalization) AttributeConstants used.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CheckboxRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17341 Tue Aug 12 15:02:15 MDT 2008 frank.ye ICE-3346 update ExtendedAttributeConstants and AttributeConstants with latest
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17342 Tue Aug 12 15:23:39 MDT 2008 frank.ye ICE-3346 autocomplete only check off value
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17345 Tue Aug 12 15:42:58 MDT 2008 frank.ye ICE-3346 update baseline
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/jar_xml_dtd/jsfmeta-resources.jar
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17349 Wed Aug 13 10:44:43 MDT 2008 frank.ye ICE-3346 ExtendedAttributeConstants update
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17353 Wed Aug 13 14:47:08 MDT 2008 frank.ye ICE-3346 revert to use TextRenderer, update passThruAttributes and js handler
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextareaRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/conf/META-INF/faces-config.xml
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SecretRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TextRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17354 Wed Aug 13 14:47:11 MDT 2008 frank.ye ICE-3346 update with passThruAttributes and js handler
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/test/java/com/icesoft/faces/metadata/AttributeConstantsTest.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/SecretRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/OutputHeadRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TextRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/OutputBodyRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TextareaRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/conf/META-INF/faces-config.xml
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Hide
                Permalink
                Frank Ye added a comment -

                difference when comparing with jsf1.2_09 AttributeManager, AttributeConstants has more attributes:

                CommandLink:
                target

                OutputLink:
                target

                SelectManyCheckbox:
                style

                SelectOneRadio:
                style

                Show
                Frank Ye added a comment - difference when comparing with jsf1.2_09 AttributeManager, AttributeConstants has more attributes: CommandLink: target OutputLink: target SelectManyCheckbox: style SelectOneRadio: style
                Hide
                Permalink
                Frank Ye added a comment -

                ExtendedAttributeConstants is the last one using Generator.
                revision 17349.

                Show
                Frank Ye added a comment - ExtendedAttributeConstants is the last one using Generator. revision 17349.
                Ken Fyten made changes -
                Link This issue is duplicated by ICE-3358 [ ICE-3358 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Affects Version/s 1.7.1 [ 10122 ]
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Link This issue blocks ICE-3082 [ ICE-3082 ]
                Ken Fyten made changes -
                Link This issue depends on ICE-3373 [ ICE-3373 ]
                Hide
                Permalink
                Frank Ye added a comment -

                fix metadata jsf12 difference

                Show
                Frank Ye added a comment - fix metadata jsf12 difference
                Ken Fyten made changes -
                Link This issue is duplicated by ICE-3322 [ ICE-3322 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17454 Wed Aug 27 11:40:02 MDT 2008 mark.collette ICE-3346 : Pass-through Attribute Optimization and Rationalization
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneldivider/PanelDividerRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelborder/PanelBorderRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelstack/PanelStackRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/GridRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ExtendedAttributeConstants.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltooltip/PanelTooltipRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/GroupRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/GridRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/AttributeConstants.java
                Hide
                Permalink
                Mark Collette added a comment -

                TRUNK
                Subversion 17454
                icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
                icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GridRenderer.java
                icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
                icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
                icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorderRenderer.java
                icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDividerRenderer.java
                icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java
                icefaces\component\src\com\icesoft\faces\component\panelstack\PanelStackRenderer.java
                icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
                icefaces\core\src\com\icesoft\faces\component\AttributeConstants.java
                icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GridRenderer.java
                icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java

                Show
                Mark Collette added a comment - TRUNK Subversion 17454 icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GridRenderer.java icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorderRenderer.java icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDividerRenderer.java icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java icefaces\component\src\com\icesoft\faces\component\panelstack\PanelStackRenderer.java icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java icefaces\core\src\com\icesoft\faces\component\AttributeConstants.java icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GridRenderer.java icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17455 Wed Aug 27 15:04:27 MDT 2008 frank.ye ICE-3346 mark renderAttributes method deprecated
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeWriter.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
                Hide
                Permalink
                Frank Ye added a comment -

                All renderer is updated, so closed

                Show
                Frank Ye added a comment - All renderer is updated, so closed
                Frank Ye made changes -
                Status In Progress [ 3 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Fix Version/s 1.7.2 [ 10130 ]
                Ken Fyten made changes -
                Fix Version/s 1.8DR#1 [ 10141 ]
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17779 Wed Oct 15 17:30:45 MDT 2008 mark.collette ICE-3346 : Pass-through Attribute Optimization and Rationalization
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ImageRenderer.java
                Hide
                Permalink
                Mark Collette added a comment -

                Fix the ImageRenderer ismap handling to follow the w3c spec, and handle null values.

                TRUNK
                Subversion 17779
                icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\ImageRenderer.java

                Show
                Mark Collette added a comment - Fix the ImageRenderer ismap handling to follow the w3c spec, and handle null values. TRUNK Subversion 17779 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\ImageRenderer.java
                Ken Fyten made changes -
                Fix Version/s 1.8 [ 10161 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Frank Ye [ frank.ye ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Adnan Durrani
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: