ICEfaces
  1. ICEfaces
  2. ICE-3345

optimize UIXhtmlComponent id

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: None
          • Labels:
            None
          • Environment:
            ICEfaces

            Description


            UIXhtmlComponent instances have ids of the form "icesoftXhtmlID0". These ids are certainly longer than necessary and may be entirely unnecessary since they are never transmitted to the client.

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Hide
              Permalink
              Ted Goddard added a comment -

              Mark, please comment on whether these ids are necessary. The idea is that elimination of unnecessary Strings will reduce server memory consumption.

              Show
              Ted Goddard added a comment - Mark, please comment on whether these ids are necessary. The idea is that elimination of unnecessary Strings will reduce server memory consumption.
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17278 Fri Aug 01 14:59:55 MDT 2008 mark.collette ICE-3345 : optimize UIXhtmlComponent id
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/XhtmlTag.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/IceOutputTextTag.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17279 Fri Aug 01 15:04:24 MDT 2008 mark.collette ICE-3345 : optimize UIXhtmlComponent id
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/parser/XhtmlTag.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/parser/IceOutputTextTag.java
              Hide
              Permalink
              Mark Collette added a comment -

              When I went to investigate the ids we generate, I found that the framework was already assigning them generated ids, which we were stomping over with our own custom generated id scheme. I removed the code for our custom generated ids, leaving the components with the UIViewRoot generated ids, and the Tags with null ids. This appears to work fine with JSF 1.1 and JSF 1.2.

              TRUNK
              Subversion 17278
              ICEfaces 1.7 branch
              Subversion 17279
              icefaces\core\src\com\icesoft\faces\webapp\parser\IceOutputTextTag.java
              icefaces\core\src\com\icesoft\faces\webapp\parser\XhtmlTag.java

              Show
              Mark Collette added a comment - When I went to investigate the ids we generate, I found that the framework was already assigning them generated ids, which we were stomping over with our own custom generated id scheme. I removed the code for our custom generated ids, leaving the components with the UIViewRoot generated ids, and the Tags with null ids. This appears to work fine with JSF 1.1 and JSF 1.2. TRUNK Subversion 17278 ICEfaces 1.7 branch Subversion 17279 icefaces\core\src\com\icesoft\faces\webapp\parser\IceOutputTextTag.java icefaces\core\src\com\icesoft\faces\webapp\parser\XhtmlTag.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Ken Fyten made changes -
              Fix Version/s 1.8DR#1 [ 10141 ]
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: