ICEfaces
  1. ICEfaces
  2. ICE-3308

Draggable modal popup can be dragged off the top of the screen

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      A draggable modal popup can be dragged off the top of the screen causing it to be unreachable. This is not an issue for a draggable non modal popup.

        Activity

        Tyler Johnson created issue -
        Hide
        Tyler Johnson added a comment -

        Issue can be reproduce using component showcase.

        Show
        Tyler Johnson added a comment - Issue can be reproduce using component showcase.
        Tyler Johnson made changes -
        Field Original Value New Value
        Attachment screenshot-1.jpg [ 11124 ]
        Tyler Johnson made changes -
        Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=5016
        Affects Version/s 1.7 [ 10080 ]
        Affects Version/s 1.7.1 [ 10122 ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2 [ 10130 ]
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Assignee Priority P2
        Assignee Adnan Durrani [ adnan.durrani ] Yip Ng [ yip.ng ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17262 Wed Jul 30 14:04:21 MDT 2008 yip.ng ICE-3308
        Added JavaScript to move draggable popup back into viewport if it is outside.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17263 Wed Jul 30 14:05:15 MDT 2008 yip.ng ICE-3308
        Added JavaScript to move draggable popup back into viewport if it is outside.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/lib/extras/style.js
        Hide
        yip.ng added a comment -

        Fixed. If dialog box is dragged outside of viewport, it will snap back into viewport when mouse button is released.

        Show
        yip.ng added a comment - Fixed. If dialog box is dragged outside of viewport, it will snap back into viewport when mouse button is released.
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Fix Version/s 1.7.2 [ 10130 ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2 [ 10130 ]
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Hide
        Joanne Bai added a comment -

        verified on branch 1.7 revision #17607

        test environment: tomcat 6 + IE 6, Firefox 2, opera 9.2

        Show
        Joanne Bai added a comment - verified on branch 1.7 revision #17607 test environment: tomcat 6 + IE 6, Firefox 2, opera 9.2
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17645 Thu Sep 25 14:29:55 MDT 2008 yip.ng ICE-3308
        Reverted changes for now because they caused regressions for ICE-2722.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/lib/extras/style.js
        Hide
        yip.ng added a comment -

        Fix caused regression for ICE-2722.

        Show
        yip.ng added a comment - Fix caused regression for ICE-2722 .
        yip.ng made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Fix Version/s 1.8DR#2 [ 10142 ]
        Fix Version/s 1.7.2 [ 10130 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17785 Fri Oct 17 14:03:07 MDT 2008 yip.ng ICE-3290
        Reverted changes for now because they caused regressions for ICE-3196.
        ICE-3308
        Reverted changes for now because they caused regressions for ICE-2722.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17786 Fri Oct 17 14:16:05 MDT 2008 yip.ng ICE-3308
        Reverted changes for now because they caused regressions for ICE-2722.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17791 Mon Oct 20 16:05:18 MDT 2008 yip.ng ICE-3308
        Changed to move popup dialog back when moved out of browser window.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/dom.js
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P2
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #24717 Fri May 27 09:12:49 MDT 2011 mircea.toma ICE-6889 Re-apply viewport calculation fixes introduced for ICE-3308.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/dom.js

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: