ICEfaces
  1. ICEfaces
  2. ICE-3290

portlet: modal popup screen expanding problem

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ANY (portlet and standalone component-showcase sample app).

      Description

      When displaying modal popup on the screen and scroll the mouse, the shadow area of the screen keeps expanding and also the popup window position keeps shifting.

        Activity

        Sam Xiao created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4974
        Hide
        Tyler Johnson added a comment -

        Issue reproducible with component showcase.

        Show
        Tyler Johnson added a comment - Issue reproducible with component showcase.
        Ken Fyten made changes -
        Environment ANY ANY (portlet and standalone component-showcase sample app).
        Fix Version/s 1.7.2 [ 10130 ]
        Assignee Priority P1
        Assignee Yip Ng [ yip.ng ]
        Hide
        Ken Fyten added a comment -

        To reproduce the issue:

        1. Using stock component showcase, make the browser window shorter than the height required to display the contents of the app.
        2. On the popup dialog demo view create a modal popup.
        3. Once the modal dialog is displayed, scroll the page using the scrollbar, watch as the page length increases and the modal dialog re-positions with each scroll event.

        Seems like the logic for positing and sizing the modal dialog is also causing the page itself to grow slightly. If we could make it so the page wouldn't grow that would be a good fix.

        Show
        Ken Fyten added a comment - To reproduce the issue: 1. Using stock component showcase, make the browser window shorter than the height required to display the contents of the app. 2. On the popup dialog demo view create a modal popup. 3. Once the modal dialog is displayed, scroll the page using the scrollbar, watch as the page length increases and the modal dialog re-positions with each scroll event. Seems like the logic for positing and sizing the modal dialog is also causing the page itself to grow slightly. If we could make it so the page wouldn't grow that would be a good fix.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17192 Fri Jul 18 14:09:50 MDT 2008 yip.ng ICE-3290
        Fixed expanding document width and height while scrolling with a modal dialog.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17193 Fri Jul 18 14:15:42 MDT 2008 yip.ng ICE-3290
        Fixed expanding document width and height while scrolling with a modal dialog.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/lib/extras/style.js
        Hide
        yip.ng added a comment -

        Fixed, including fix for Opera 9.5+. Tested on IE 6 & 7, FF 2 & 3, Opera pre-9.5 & 9.5+.

        There were actually several bugs (CSS, JavaScript, browser brand and browser version differences) involved, some of which might have been avoided in the first place had we made more use of Prototype functions rather than trying to "re-invent the wheel". (I have seen quite a few such cases in the past when fixing other JIRA cases.)

        Show
        yip.ng added a comment - Fixed, including fix for Opera 9.5+. Tested on IE 6 & 7, FF 2 & 3, Opera pre-9.5 & 9.5+. There were actually several bugs (CSS, JavaScript, browser brand and browser version differences) involved, some of which might have been avoided in the first place had we made more use of Prototype functions rather than trying to "re-invent the wheel". (I have seen quite a few such cases in the past when fixing other JIRA cases.)
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Fix Version/s 1.7.2 [ 10130 ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2 [ 10130 ]
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17648 Thu Sep 25 17:25:44 MDT 2008 yip.ng ICE-3290
        Reverted changes for now because they caused regressions for ICE-3196.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/lib/extras/style.js
        Hide
        Ken Fyten added a comment -

        The fix for this is causing regressions on the 1.7 branch, reverting for 1.7.2 release, will examine further for 1.8.

        Show
        Ken Fyten added a comment - The fix for this is causing regressions on the 1.7 branch, reverting for 1.7.2 release, will examine further for 1.8.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Fix Version/s 1.8DR#2 [ 10142 ]
        Fix Version/s 1.7.2 [ 10130 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17785 Fri Oct 17 14:03:07 MDT 2008 yip.ng ICE-3290
        Reverted changes for now because they caused regressions for ICE-3196.
        ICE-3308
        Reverted changes for now because they caused regressions for ICE-2722.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17790 Mon Oct 20 15:56:28 MDT 2008 yip.ng ICE-3290
        Fixed problem of iframe expanding on scrolling.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P2
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Sam Xiao
          • Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: