ICEfaces
  1. ICEfaces
  2. ICE-3066

s:link not rendering properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7.1
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Seam (any version) and ICEfaces-1.7.0 (although not quite correct in 1.6.1 either)

      Description

      Upon closer inspection of s:link and it's behaviour, we have overlooked one of it's functions (the opening of a new tab or window with the information from the link). Using 1.6.1, the new tab or window would be opened, but the same page would be viewed (and the conversation could be carried out further, etc. This was at least partially correct). Using 1.7.0, a new tab can be opened, but nothing is displayed.
      Please let me know how you want to proceed. (doing post instead of get??)
       
      The following inspections of the html reveal what is rendered:-
      ICEfaces 1.7.0

      <a onfocus="setFocus(this.id);" onclick="document.forms['j_id43']['j_id43:_idcl'].value='j_id43:hotels:2:viewHotel';iceSubmit( document.forms['j_id43'], this,event); return false;" onblur="setFocus('');" id="j_id43:hotels:2:viewHotel" href="javascript:;" class="iceCmdLnk">View Hotel</a>

       

      ICEfaces 1.6.1

      <a onfocus="setFocus(this.id);" onclick="document.forms['j_id43']['j_id43:_idcl'].value='j_id43:hotels:0:viewHotel';iceSubmit( document.forms['j_id43'], this,event); return false;" onblur="setFocus('');" id="j_id43:hotels:0:viewHotel" href="# " class="iceCmdLnk">View Hotel</a>

       

      regular Seam without ICEfaces (any version):-

      <a href="/seam-booking/main.seam?dataModelSelection=hot%3Ahotels%5B2%5D&cid=3&actionMethod=main.xhtml%3AhotelBooking.selectHotel%28hot%29"

        Activity

        Hide
        Judy Guglielmin added a comment -

        link to definition of conversation propagation behaviour using links
        http://www.redhat.com/docs/manuals/jboss/jboss-eap-4.2/doc/seam/Seam_Reference_Guide/Conversations_and_workspace_management-Seams_conversation_model.html

        if you want a sample app for this let me know. For this one, you can use the icefaces-booking example to show above behaviour.

        Show
        Judy Guglielmin added a comment - link to definition of conversation propagation behaviour using links http://www.redhat.com/docs/manuals/jboss/jboss-eap-4.2/doc/seam/Seam_Reference_Guide/Conversations_and_workspace_management-Seams_conversation_model.html if you want a sample app for this let me know. For this one, you can use the icefaces-booking example to show above behaviour.
        Hide
        Ken Fyten added a comment -

        Seems like ice:outputLink should be rendering a GET anyway, shouldn't it? Perhaps we can make ice:outputLink render a GET with the same behaviors of s:link and them you could use either interchangeably?

        Show
        Ken Fyten added a comment - Seems like ice:outputLink should be rendering a GET anyway, shouldn't it? Perhaps we can make ice:outputLink render a GET with the same behaviors of s:link and them you could use either interchangeably?
        Hide
        Mark Collette added a comment -

        In both ICEfaces releases it's rendering class="iceCmdLnk" so it's taking it from commandLink, not outputLink.

        Show
        Mark Collette added a comment - In both ICEfaces releases it's rendering class="iceCmdLnk" so it's taking it from commandLink, not outputLink.
        Hide
        Mark Collette added a comment -

        Since those weren't s:link components, should we update the Seam ICEfaces example to use s:link components?

        Show
        Mark Collette added a comment - Since those weren't s:link components, should we update the Seam ICEfaces example to use s:link components?
        Hide
        Judy Guglielmin added a comment -

        updated example for 2.1.0 trunk of seam so that s:link and not ice component is used.

        Show
        Judy Guglielmin added a comment - updated example for 2.1.0 trunk of seam so that s:link and not ice component is used.

          People

          • Assignee:
            Unassigned
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: