ICEfaces
  1. ICEfaces
  2. ICE-3014

ContentEventRepeater: buffered events should be cleaned-up more aggressively

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.8RC2, 1.8
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            When View Numbers are disposed ContextEventRepeater should clean-up its related buffered events appropriately as well. To achieve this functionality one requirement would be the introduction of a ViewNumberDisposed-like event.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-1585 Config. params missing from docs

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Jack Van Ooststroom created issue -
                Jack Van Ooststroom made changes -
                Field Original Value New Value
                Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Changed Fix Version(s) to 1.7.1

                Show
                Jack Van Ooststroom added a comment - Changed Fix Version(s) to 1.7.1
                Jack Van Ooststroom made changes -
                Fix Version/s 1.7.1 [ 10122 ]
                Affects Version/s 1.7 [ 10080 ]
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Unfortunately, I haven't been able to look at this one in more detail for the upcoming 1.7.1 release. Though I think the change should be minor, we should be cautious that it doesn't break the AHS.

                Moving this one to 1.7.2.

                Show
                Jack Van Ooststroom added a comment - Unfortunately, I haven't been able to look at this one in more detail for the upcoming 1.7.1 release. Though I think the change should be minor, we should be cautious that it doesn't break the AHS. Moving this one to 1.7.2.
                Jack Van Ooststroom made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Fix Version/s 1.7.1 [ 10122 ]
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Changed Assignee Priority to P1

                Show
                Jack Van Ooststroom added a comment - Changed Assignee Priority to P1
                Jack Van Ooststroom made changes -
                Assignee Priority P1
                Jack Van Ooststroom made changes -
                Link This issue blocks ICE-1585 [ ICE-1585 ]
                Jack Van Ooststroom made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Ken Fyten made changes -
                Assignee Priority P1 P3
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Changed Assignee Priority back to P1, to see if we can squeeze this one into the upcoming 1.7.2RC1 release.

                Show
                Jack Van Ooststroom added a comment - Changed Assignee Priority back to P1, to see if we can squeeze this one into the upcoming 1.7.2RC1 release.
                Jack Van Ooststroom made changes -
                Assignee Priority P3 P1
                Ken Fyten made changes -
                Fix Version/s 1.8DR#2 [ 10142 ]
                Fix Version/s 1.7.2 [ 10130 ]
                Deryk Sinotte made changes -
                Assignee Priority P1 P2
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Move to 1.8DR#3

                Show
                Jack Van Ooststroom added a comment - Move to 1.8DR#3
                Jack Van Ooststroom made changes -
                Fix Version/s 1.8DR#3 [ 10143 ]
                Fix Version/s 1.8DR#2 [ 10142 ]
                Ken Fyten made changes -
                Assignee Priority P2
                Ken Fyten made changes -
                Salesforce Case []
                Component/s Framework [ 10013 ]
                Deryk Sinotte made changes -
                Salesforce Case []
                Assignee Priority P2
                Jack Van Ooststroom made changes -
                Status In Progress [ 3 ] Open [ 1 ]
                Deryk Sinotte made changes -
                Salesforce Case []
                Fix Version/s 1.8 [ 10161 ]
                Fix Version/s 1.8RC1 [ 10143 ]
                Jack Van Ooststroom made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18369 Thu Feb 19 12:43:52 MST 2009 jack.van.ooststroom Fixed JIRA ICE-3014 : ContentEventRepeater: buffered events should be cleaned-up more aggressively
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/messaging/ContextEventMessageHandler.java
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/messaging/AbstractContextEventMessageHandler.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/messaging/BufferedContextEventsMessageHandler.java
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/UpdatedViewsManager.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/ContextDestroyedListener.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/ContextEventListener.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/TomcatPushServlet.java
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/UpdatedViews.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/MessagingContextEventPublisher.java
                Commit graph ADD /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/ViewNumberDisposedEvent.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/ContextEventRepeater.java
                Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/common/SessionManager.java
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                A new ContextEvent has been introduced, namely the ViewNumberDisposedEvent, which can be fired using the new ContextEventRepeater.viewNumberDisposed(HttpSession source, String iceFacesId, int viewNumber) method. This method is invoked whenever the View.dispose() method is invoked. When AHS is configured, the new event gets propagated to the AHS as well. Both the ContextEventRepeater and the AHS will do the appropriate clean up upon receiving this event. Marking this one as FIXED.

                Show
                Jack Van Ooststroom added a comment - A new ContextEvent has been introduced, namely the ViewNumberDisposedEvent, which can be fired using the new ContextEventRepeater.viewNumberDisposed(HttpSession source, String iceFacesId, int viewNumber) method. This method is invoked whenever the View.dispose() method is invoked. When AHS is configured, the new event gets propagated to the AHS as well. Both the ContextEventRepeater and the AHS will do the appropriate clean up upon receiving this event. Marking this one as FIXED.
                Jack Van Ooststroom made changes -
                Status In Progress [ 3 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s 1.8RC2 [ 10163 ]
                Fix Version/s 1.8 [ 10161 ]
                Ken Fyten made changes -
                Fix Version/s 1.8 [ 10161 ]
                Assignee Priority P2
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Jack van Ooststroom [ jack.van.ooststroom ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Jack Van Ooststroom
                  • Votes:
                    1 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: