ICEfaces
  1. ICEfaces
  2. ICE-2874

Last selection of row selection in component-showcase is not saved

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7RC1, 1.7
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces trunk revision #16039.

      Description

      The last selection of row selection in component-showcase is not saved (in single row selection mode, nothing is saved) after switching tabs

        Activity

        Hide
        Ken Fyten added a comment -

        This is a regression.

        Show
        Ken Fyten added a comment - This is a regression.
        Hide
        Mark Collette added a comment -

        I tested with ICEfaces 1.6.2, via the component-showcase example on icefaces.org, and it looks like this problem is evident there as well.

        Basically, the form field that is submitted, for selected rows, is always submitted when any component does a partialSubmit (like all form fields). But, that form field is not interpreted as an absolute value, but instead as a toggle/flip notification. So, interacting with any component, after selecting a row, will deselect that last row. Clicking to change the tabs in the component-showcase is the simplest way of showing this. It also has the effect, of making a RowSelectionEvent be fired, whenever the other components partialSubmit, which can cause problems when the selectionListener calls FacesContext.renderResponse().

        Show
        Mark Collette added a comment - I tested with ICEfaces 1.6.2, via the component-showcase example on icefaces.org, and it looks like this problem is evident there as well. Basically, the form field that is submitted, for selected rows, is always submitted when any component does a partialSubmit (like all form fields). But, that form field is not interpreted as an absolute value, but instead as a toggle/flip notification. So, interacting with any component, after selecting a row, will deselect that last row. Clicking to change the tabs in the component-showcase is the simplest way of showing this. It also has the effect, of making a RowSelectionEvent be fired, whenever the other components partialSubmit, which can cause problems when the selectionListener calls FacesContext.renderResponse().
        Hide
        Mark Collette added a comment -

        If a hidden form field doesn't have an id, then it's cleared after submission, so it's value is not re-submitted. So, I simply removed the row selection hidden form field's id, and changed the Javascript to look it up by name, not id.

        Subversion 16064
        icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        icefaces\bridge\lib\extras\extras.js

        Show
        Mark Collette added a comment - If a hidden form field doesn't have an id, then it's cleared after submission, so it's value is not re-submitted. So, I simply removed the row selection hidden form field's id, and changed the Javascript to look it up by name, not id. Subversion 16064 icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java icefaces\bridge\lib\extras\extras.js

          People

          • Assignee:
            Unassigned
            Reporter:
            Sam Xiao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: