ICEfaces
  1. ICEfaces
  2. ICE-2689

selectOneRadio not submitting with partialSubmit=true

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7DR#3
    • Fix Version/s: 1.7Beta1, 1.7
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows XP, Tomcat 5.5.20, JDK 5

      Description

      selectOneRadio does not submit when changed and partialSubmit=true. There is no sign of activity and the setter is never hit. This seems to have broken between DR2 and DR3 since it was working before.

        Activity

        Hide
        Christophe Taverne added a comment -

        I think you re perfectly right on the dates

        good news ! héhé

        Show
        Christophe Taverne added a comment - I think you re perfectly right on the dates good news ! héhé
        Hide
        Nicklas Karlsson added a comment -

        There is a checkin that looks suspicious:

        15353 Fix for ICE-2488 (Component Showcase: Stacking panel does not remember selections) [less] adnan.durrani 12/11/07 1:30 PM

        that touches

        Modified /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java

        Well, the canadians will probably know more once they get some sunshine...

        Show
        Nicklas Karlsson added a comment - There is a checkin that looks suspicious: 15353 Fix for ICE-2488 (Component Showcase: Stacking panel does not remember selections) [less] adnan.durrani 12/11/07 1:30 PM that touches Modified /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java Well, the canadians will probably know more once they get some sunshine...
        Hide
        Mark Collette added a comment -

        Thanks to our wonderful, and persistent, open source community, I've duplicated the problem by setting layout="pageDirection".

        Show
        Mark Collette added a comment - Thanks to our wonderful, and persistent, open source community, I've duplicated the problem by setting layout="pageDirection".
        Hide
        Mark Collette added a comment -

        When the selectOneRadio had layout="pageDirection", the code was creating a <fieldset> and a <table> with the partialSubmit handler, but rendered the <tr> and <input> tags outside of them, into the parent panelGrid's <table>. This effectively broke partialSubmit for that component's configuration.

        Subversion 15768
        icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
        icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java

        Show
        Mark Collette added a comment - When the selectOneRadio had layout="pageDirection", the code was creating a <fieldset> and a <table> with the partialSubmit handler, but rendered the <tr> and <input> tags outside of them, into the parent panelGrid's <table>. This effectively broke partialSubmit for that component's configuration. Subversion 15768 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
        Hide
        Sam Xiao added a comment -

        fix confirmed for 1.7 beta 1 build 10

        Show
        Sam Xiao added a comment - fix confirmed for 1.7 beta 1 build 10

          People

          • Assignee:
            Unassigned
            Reporter:
            Nicklas Karlsson
          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: