ICEfaces
  1. ICEfaces
  2. ICE-2654

Gap on right side of dataTable should be removed if scrollbar not needed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.7DR#3
    • Fix Version/s: 1.7Beta1, 1.7
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      If scrollable is set to true for a datatable whose row count is small enough that a scrollbar is not needed, the gap on the right side of the data table should be removed. Attached is a screenshot comparison as well as a war file demonstrating the issue.

        Activity

        Tyler Johnson created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Attachment gap_in_table.jpg [ 10790 ]
        Tyler Johnson made changes -
        Tyler Johnson made changes -
        Attachment dataTable-selector.war [ 10792 ]
        Hide
        Ken Fyten added a comment -

        Related to ICE-2417.

        Show
        Ken Fyten added a comment - Related to ICE-2417 .
        Ken Fyten made changes -
        Fix Version/s 1.7Beta1 [ 10121 ]
        Assignee Yip Ng [ yip.ng ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #15654 Thu Jan 24 17:04:45 MST 2008 yip.ng ICE-2654
        Changed to get rid of gap on right side of table when scrollbar is not rendered by browser.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/TableRenderer.java
        Hide
        yip.ng added a comment -

        Screenshot of testing the fix.

        Note that a scrolling-enabled table is rendered differently than a scrolling-disabled table. Ideally, a scrolling-enabled table without a scrollbar should look exactly the same as a scrolling-disabled table. But since there is no way to tell for sure in advance whether a browser will eventually render a scrollbar or not, a scrolling-enabled table without the scrollbar still looks slightly different than a scrolling-disabled table.

        Show
        yip.ng added a comment - Screenshot of testing the fix. Note that a scrolling-enabled table is rendered differently than a scrolling-disabled table. Ideally, a scrolling-enabled table without a scrollbar should look exactly the same as a scrolling-disabled table. But since there is no way to tell for sure in advance whether a browser will eventually render a scrollbar or not, a scrolling-enabled table without the scrollbar still looks slightly different than a scrolling-disabled table.
        yip.ng made changes -
        Attachment screenshot-1.jpg [ 10802 ]
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Priority Major [ 3 ] Trivial [ 5 ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: